Shell command output trouble

[keeper]

I kinda new to tcl coding but by searching this great forum i mangare to almost made it work

Code: Select all

bind pub "-|-" !pp ping_proc
proc ping_proc {nick uhost handle channel arg} {
set nr [lindex $arg 0]
set target [lindex $arg 1]
set i [exec /bin/ping -c $nr $target]
fileevent $i readable "outp $i"
}
proc outp {i channel} {
putquick "PRIVMSG $channel :[gets $i]"
if [eof $i] {close $i}
}

when i type the following in the channel i get this error in the bot..

Tcl error [ping_proc]: can not find channel named "PING localhost (127.0.0.1) 56(84) bytes of data.
64 bytes from localhost (127.0.0.1): icmp_seq=1 ttl=64 time=0.055 ms

--- localhost ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 0.055/0.055/0.055/0.000 ms"

anyone know how to fix this ?

cheers!

[De Kus]

Code: Select all

proc outp {i channel} {

this wont give you the channel. you have to save it globally and retrieve it again in the proc.

But I wonder anyway in which part ever a command is called requiring a channel (putquick doesnt require a channel name).

[greenbear]

I'd use eval instead

Code: Select all

bind pub "-|-" !pp ping_proc
proc ping_proc {nick uhost handle channel arg} {
 set num [lindex [split $arg] 0]
 set target [lindex [split $arg] 1]

 set command [concat exec /bin/ping -c $num $target]
 set return [eval $command]

 foreach output [split $return \n] {
  putserv "PRIVMSG $channel :$output"
 }
}

[keeper]

Thanks