Trouble with Vars

[Dedan]

Everytime i try to make a nice timed var, i run into this problem.

you can increase the value of a var with: "incr codes_flood 1"
why can't you decrease it in a "called" proc?

<stenone> [07:47] Tcl error in script for 'timer400':
<stenone> [07:47] expected integer but got "codes_flood"

Code: Select all

proc stuff {usual stuff} {
  global stuff

   if flood stuff
    
    if {$codes_found >= $codes_max} {
      incr codes_flood 1
      utimer 7 [list flood:dec codes_flood]


}

proc flood:dec {var} {
  global codes_flood
  incr var -1
  if {$var < "0"} {set var "0"}
  return 0
}

Thanks for any help given

[user]

You pass the variable name to the proc and then try to incr the variable containing the variable name, which obviously won't work unless that name is a integer

I suggest using 'upvar' to import the variable...this way you can pass any variable name to the proc without risking screwups because the name is already taken.

Code: Select all

proc flood:dec {var} { 
  upvar 1 $var v
  if {[incr v -1]<0} {set v 0} 
}

[caesar]

In the flood:dec proc don't forget to call globaly the var variable or use what user sugested.

[Dedan]

so, it should be:

Code: Select all

proc flood:dec {var} { 
  upvar 1 $var v
  incr v -1
  if {$v < 0} {set v 0} 
}