Best way to match using regexp?

[awyeah]

I came up with this recently:

Code: Select all

if {[regexp -nocase {012-?[0-9]{7}[^A-Z0-9+&@#/%?=~_|!:,.;]|013-?[0-9]{7}[^A-Z0-9+&@#/%?=~_|!:,.;]|014-?[0-9]{7}[^A-Z0-9+&@#/%?=~_|!:,.;]|016-?[0-9]{7}[^A-Z0-9+&@#/%?=~_|!:,.;]|017-?[0-9]{7}[^A-Z0-9+&@#/%?=~_|!:,.;]|019-?[0-9]{7}[^A-Z0-9+&@#/%?=~_|!:,.;]} $text]} {

The code looks blotty right. Okay the main idea behind this is to match cell phone numbers.

The cell operator numbers are: 012, 013, 014... and so on as you can see.
Then there is a 7 digit phone number after the cell operator number.
After the last digit (7th digit) of the phone number there shouldn't be any number.

The number can be like:
0126708090

or even like:
012-6708090

This piece of code looks very long and blotty to me, although it works. Any suggestions for improvement?

[Sir_Fz]

Code: Select all

regexp {^01[234679]-?[0-9]{7}$} $number

So the number must start with a number (0) and end with a number (exactly 7 numbers after the operator).

[awyeah]

Thanks Sir_Fz that is exactly what I needed! Actually the "$" in the end did the trick, hehe

[De Kus]

thats strange, my cell phone number consists of 8 digits and has a 4 digit prefix number even without the country code. Is it supposed to match only local cellphone numbers?

[Sir_Fz]

Phone numbers differ from one country to another. For example, here in Lebanon a phone number is made up of 6 numbers, and our area code is made up of 2 numbers so it's +961-xx-xxxxxx.

[awyeah]

Exactly, Sir_Fz is right. This only matches cellphone providers in Malaysia. They have a 3 digit operator code following a 7 digit individual number. The fixed line numbers are however different.

Here is what I use now:

Code: Select all

if {[regexp {\x20(01[234679]-?[0-9]{7})\x20} $text]} {