egghelp/eggheads community

cupbot

2005-06-22T13:25:07-04:00

arrh, thanks Sir_fz and Demond, i will try and fix them myself, but im going thro a rough time atm. I got exams at school, and a relative died 3 weeks ago, and so im really busy. I dont have much time for my tcl scripting, but im trying to make this script for my channel asap, as they have been waiting for this script to be finished. So im underpressure. Thanks for your help!!

Statistics: Posted by r0t3n — Wed Jun 22, 2005 1:25 pm

cupbot

2005-06-22T13:12:23-04:00

if {![matchattr $handle C|C $chan} && ![matchattr $handle o|o $chan] {

missing close brace

why don't you stop posting already such questions and try to concentrate on fixing your syntax errors yourself?

you are becoming a nuisance

Statistics: Posted by demond — Wed Jun 22, 2005 1:12 pm

cupbot

2005-06-22T13:13:13-04:00

I don't know what's your understanding of balanced braces, but you should really understand how braces should be used. Try:

Code:

proc make:prize {nick host handle chan text} {  set newprize $text  if {![matchattr $handle C|C $chan] && ![matchattr $handle o|o $chan]} {   putserv "PRIVMSG $chan :Error: You dont not have access to this command $nick."  } elseif {($cup(cup,$chan) == off) || ($cup(cup,$chan) == "")} {   putserv "PRIVMSG $chan :Error: no cup is running."  } elseif {($newprize == "")} {   putserv "PRIVMSG $chan :Error: no prize was set, use ./!/?setprize prize."  } elseif {[matchattr $handle C|C $chan] || [matchattr $handle o|o $chan] && ($cup(cup,$chan) == on)} {   set cup(prize,$chan) $newprize   putserv "PRIVMSG $chan :The prize is now: $cup(prize,$chan)   putserv "NOTICE $nick :Done."  } }

And use spacing when writing a code.

PS: aside from the invalid structure of the code, it seems that you're using variables that do not exist in the proc. Perhaps they're global, if so then don't forget to globalize them.

Statistics: Posted by Sir_Fz — Wed Jun 22, 2005 1:08 pm

cupbot

2005-06-22T12:46:30-04:00

i made this script earlier today and have been testing it, but there is a error, which i cant seem to fix. The code:

Code:

proc make:prize {nick host handle chan text} {set newprize $textif {![matchattr $handle C|C $chan} && ![matchattr $handle o|o $chan] {putserv "PRIVMSG $chan :Error: You dont not have access to this command $nick."} elseif {($cup(cup,$chan) == off)} || ($cup(cup,$chan) == "")} {putserv "PRIVMSG $chan :Error: no cup is running."} elseif {($newprize == "")} {putserv "PRIVMSG $chan :Error: no prize was set, use ./!/?setprize prize."} elseif {[matchattr $handle C|C $chan] || [matchattr $handle o|o $chan] && ($cup(cup,$chan) == on) {set cup(prize,$chan) $newprizeputserv "PRIVMSG $chan :The prize is now: $cup(prize,$chan)putserv "NOTICE $nick :Done."}}

The error:

[17:44] CUPBOT.TCL SCRIPT LOADED!!
[17:44] Tcl error in file 'eggdrop.conf':
[17:44] wrong # args: should be "proc name args body"
while executing
"proc make:prize {nick host handle chan text} {
set newprize $text
if {![matchattr $handle C|C $chan} && ![matchattr $handle o|o $chan] {
putserv "PRIV..."
(file "scripts/cupbot.tcl" line 116)
invoked from within
"source scripts/cupbot.tcl"
(file "eggdrop.conf" line 1329)
[17:44] * CONFIG FILE NOT LOADED (NOT FOUND, OR ERROR)

C:\Documents and Settings\Chris\Desktop\eggdrops\eggy2>pause
Press any key to continue . . .

I cant seem to fix it, please help!!

Thanks in advance!!

also as you can see, the file system for the cupbot seemed to hard, so i went to vars.

Statistics: Posted by r0t3n — Wed Jun 22, 2005 12:46 pm

cupbot

2005-06-21T17:22:25-04:00

extract the list element you need, using [lindex]

Statistics: Posted by demond — Tue Jun 21, 2005 5:22 pm

cupbot

2005-06-21T17:12:52-04:00

i read that basic file operations, and what you said about not using the internal "get" command or whatever that is. The script i made worked, but replyed to the channel as: {#channel prize here}
How can i make it so it replies without the brackets and the channel name.
Thanks in advance!!

Statistics: Posted by r0t3n — Tue Jun 21, 2005 5:12 pm

cupbot

2005-06-21T13:22:35-04:00

you didn't bother to read my remarks on your approach to Tcl scripting, or did you?

Statistics: Posted by demond — Tue Jun 21, 2005 1:22 pm

cupbot

2005-06-21T13:01:24-04:00

erm, rather good, got most of it working, just need help on this !prize script, there is a error, and it does find the prize in the cupprize.db, my mate on irc said the script is correct, but he doesnt know the problem.
Can anyone help make a script to read a certain line from cupprize.db which a -string match *$chan* blah blah etc. Erm, i would post the !prize script, but i deleted it because it didnt work. Please help!!

Statistics: Posted by r0t3n — Tue Jun 21, 2005 1:01 pm

cupbot

2005-06-20T14:57:51-04:00

hello, hows the cupbot coming along? come across anymore problems? i can test itfor u if u want

Statistics: Posted by fajja — Mon Jun 20, 2005 2:57 pm

cupbot

2005-06-18T11:45:30-04:00

nor the way to ask for help. RTFM

its like asking ur mom for presents she cant even afford.

Statistics: Posted by Galadhrim — Sat Jun 18, 2005 11:45 am

cupbot

2005-06-17T22:26:04-04:00

you expect someone to run and debug that for you, without you bothering to test it yourself first? heh

that's not the way to learn Tcl/eggdrop scripting dude

anyway, some hints:

\$prize means your bind command is '$prize', which is probably not what you had in mind ($prize as variable)
your 'while' command is incorrect, use curly braces to enclose condition, not parenthesis
don't use built-in command's name ([gets]) as variable, this is bad practice
you try to use the file descriptor variable itself ([lindex $fs 0]) as data, which is nonsense
format your scripts using indentation, one statement per line

IMO, you are too lazy to bother trying to learn Tcl starting with simple and basic things first - you want to somehow jump writing complete and functional scripts, with others testing and debugging your stuff while you wait - as I said, this is not the way of becoming a scripter

Statistics: Posted by demond — Fri Jun 17, 2005 10:26 pm

cupbot

2005-06-17T19:00:44-04:00

Code:

bind pub - \$prize get:prizeproc get:prize {nick host hand chan args} {set fs [open "cupprize.db" r]set prize ""while (![eof $fs]) { set gets [gets $fs]if {[lindex $fs 0] = "$chan"} { set prize [lrange $fs 1 end] } } if {($prize == "")} { putserv "PRIVMSG $chan :No Prize Is Set..." } else { putserv "PRIVMSG $chan :The Cup Prize Is: $prize." }}

Would that work, please check, Thanks!!

Statistics: Posted by r0t3n — Fri Jun 17, 2005 7:00 pm

cupbot

2005-06-17T18:14:13-04:00

you can read it like you wrote it. however if you want to save more than 1 price at the same time, I would recommned you use a list which you can read and write to you file.

Statistics: Posted by De Kus — Fri Jun 17, 2005 6:14 pm

cupbot

2005-06-17T17:55:48-04:00

ok, i know how to write to cupprize.db but i dont know how to read from it.
i made a custom C flag for cupadmin

Code:

bind pub oC|oC !setprize cup:prizeproc cup:prize {nick host handle chan text} {global lastbindset cupprize [lindex [split $text] end]if {![matchattr $handle o|o $chan] && ![matchattr $handle C|C $chan]} {putserv "NOTICE $nick :Error: You dont not have access to this command, +o or +C flag needed on $chan."} elseif {[$cupprize == ""]} {putserv "NOTICE $nick :Error: No prize was set, use $lastbind prize"} elseif {[matchattr $handle o|o $chan] || [matchattr $handle C|C $chan] && [$cupprize != ""]} {set fs [open "cupprize.db" w]puts $fs "$chan $cupprize"close $fsputserv "NOTICE $nick :Done, Cupprize set to: $cupprize."putserv "PRIVMSG $chan :Cupprize has been set by $nick, Prize: $cupprize."}}

I hope that works, please check. But how can i read that info and display it to a channel from a !prize proc ;p please help, thanks!!

Statistics: Posted by r0t3n — Fri Jun 17, 2005 5:55 pm

cupbot

2005-06-17T16:38:20-04:00

this is a help forum for people who bother to search and read (for example Basic File Operations) before crying out loud for help

Statistics: Posted by demond — Fri Jun 17, 2005 4:38 pm