egghelp/eggheads community

kick cmd not working

2004-02-26T14:54:20-04:00

Hah!

Statistics: Posted by arcane — Thu Feb 26, 2004 2:54 pm

kick cmd not working

2004-02-26T09:04:11-04:00

After a night's sleep, I have thought about it more clearly.... Peterre's page confused me into wrongly accusing eggdrop's bind command... Of course it would be a string passed to the last parameter, and 'args' by its very nature converts to a list.... Thus by join'ing it, you would get a string still needing to be split....

What else can I say.... My bad...

Statistics: Posted by strikelight — Thu Feb 26, 2004 9:04 am

I think you're wrong.

2004-02-26T08:34:39-04:00

As noted in my previous post to arcane in another thread, if we were speaking of plain old vanilla TCL, you would be right about him using args improperly... However because of the way bind calls procedures, it produces a list of lists in this scenario... so join'ing the list of lists produces a single list.....

Since when does eggdrop do that? And what exactly do you mean? It's passed to the proc as a string in my 1.6.13 test bot.

[13:20] (@user) % bind pub n !doit doit; proc doit {n u h c args} {putserv "PRIVMSG $c :[join $args]"}
[13:21] (@user) !doit { [
[13:21] (@sh) { [

Statistics: Posted by user — Thu Feb 26, 2004 8:34 am

kick cmd not working

2004-02-26T03:01:31-04:00

strikelight, I'm not sure what you mean. Are you saying bind passes a list as the last argument, not a string? I'm pretty sure that's wrong!

Statistics: Posted by stdragon — Thu Feb 26, 2004 3:01 am

kick cmd not working

2004-02-25T23:36:07-04:00

Code:
set args [join $args]set target [lindex $args 0]set reason [lrange $args 1 end]
Do you have the slightest idea what you're doing? First you use a special argument name (args - read about it here: http://tcl.tk/man/tcl8.4/TclCmd/proc.htm) that's not needed for this kind of task (a predefined number of arguments), then you join the list created by it, so you're left with the string that was passed to the proc, and THEN you start using list commands on that string. (not a good idea)
How about NOT doing all that?

As noted in my previous post to arcane in another thread, if we were speaking of plain old vanilla TCL, you would be right about him using args improperly... However because of the way bind calls procedures, it produces a list of lists in this scenario... so join'ing the list of lists produces a single list..... But Again, I don't agree with using this method any more than you do....

Statistics: Posted by strikelight — Wed Feb 25, 2004 11:36 pm

kick cmd not working

2004-02-25T19:44:46-04:00

the users have specific host masks.

Statistics: Posted by kazoo — Wed Feb 25, 2004 7:44 pm

kick cmd not working

2004-02-25T19:38:35-04:00

Code:

set args [join $args]set target [lindex $args 0]set reason [lrange $args 1 end]

Do you have the slightest idea what you're doing? First you use a special argument name (args - read about it here: http://tcl.tk/man/tcl8.4/TclCmd/proc.htm) that's not needed for this kind of task (a predefined number of arguments), then you join the list created by it, so you're left with the string that was passed to the proc, and THEN you start using list commands on that string. (not a good idea)
How about NOT doing all that?

Is this what I should have?
Code:
...

No..you didn't listen to what Dw2k said about putkick (the only thing he got right) Try something like this (lots of extra bloat added, sorry):

Code:

bind pub o|f .kick cmd:kickproc cmd:kick {nick uhost hand chan arg} {  # extract the first word and the remaining ones (if any)  # into separate vars and store the return value from 'scan'  set i [scan $arg "%s %\[^\n\]" victim reason]  # if scan returned something > 0 we know there's a victim...  if {$i>0} {    # checking to see if there's someone by that nick present...    if {[onchan $victim $chan]} {      # did the scan find a reason or do we have to provide a default value?      if {$i!=2} {        set reason "$nick doesn't seem to like you."      }      putkick $chan $victim $reason    } else {      puthelp "NOTICE $nick :$victim is not on $chan"    }  } else {    # no arguments were provided, so we tell the stupid user    # how it should be done ;)    puthelp "NOTICE $nick :Syntax: $::lastbind nick ?reason?"  }}

This code is not tested, but should at least give you some new ideas
You're still left with an authentication problem, though. How do you make sure the people triggering the proc really are who they seem to be?

Statistics: Posted by user — Wed Feb 25, 2004 7:38 pm

kick cmd not working

2004-02-25T19:03:39-04:00

Is this what I should have?

Code:

bind pub o|f .kick cmd:kickproc cmd:kick {nick host hand chan args} {set args [join $args]set target [lindex $args 0]set reason [lrange $args 1 end]putkick "$chan [lindex $arg 1] [lrange $arg 2 end] ($nick)"puthelp "Privmsg $nick :Kicked [lindex $arg 1] from $chan"}

Statistics: Posted by kazoo — Wed Feb 25, 2004 7:03 pm

kick cmd not working

2004-02-23T19:23:22-04:00

Thanks :]

Statistics: Posted by kazoo — Mon Feb 23, 2004 7:23 pm

kick cmd not working

2004-02-23T19:06:24-04:00

You need the correcy syntax for putkick

Code:

 putkick $chan $target $reason

and if you replace

Code:

proc cmd:kick {nick host hand chan text} {

with

Code:

 proc cmd:kick {nick host hand chan args} {

and add

Code:

set args [join $args]set target [lindex $args 0]set reason [lrange $args 1 end]

Im sure you can figure the rest out

Statistics: Posted by Dw2k — Mon Feb 23, 2004 7:06 pm

kick cmd not working

2004-02-23T19:00:30-04:00

Why doesn't this work?

Code:

bind pub o|f .kick cmd:kickproc cmd:kick {nick host hand chan text} {putkick "$chan :$text"puthelp "Privmsg $nick :Kicked $text from $chan"}

I'm using eggdrop1.6.8 btw

Statistics: Posted by kazoo — Mon Feb 23, 2004 7:00 pm