egghelp/eggheads community

Kicking nicknames with brackets in them

2004-01-29T13:04:33-04:00

Your welcome.

Statistics: Posted by caesar — Thu Jan 29, 2004 1:04 pm

Kicking nicknames with brackets in them

2004-01-29T12:50:51-04:00

alright, i feel like a retard now.

Thanks a lot man, it solved the problem.

Statistics: Posted by Aron — Thu Jan 29, 2004 12:50 pm

Kicking nicknames with brackets in them

2004-01-28T12:31:38-04:00

set time [lindex $text 1]?

Statistics: Posted by user — Wed Jan 28, 2004 12:31 pm

Kicking nicknames with brackets in them

2004-01-28T12:23:18-04:00

I have looked over it time and time again, and i just dont see it. I already fixed those errors.

Code:

proc academy:ban {nick host handle chan text} {   global botnick guardmethod botname  if {(![authed $handle]) || ![string equal -nocase $chan "#jedi-academy"]} { return 0 }   set userlevel [level $handle]  set nickhost [lindex [split $text] 0]  set time [lindex $text 1]  set reason [join [lrange [split $text] 2 end]]  if {$userlevel == "Knight" || $nickhost == ""} {return 0}  if {[string tolower $time] == "perm"} { set time 0 }   if {[onchan $nickhost $chan]} {   if {[string match "*.users.quakenet.org" [getchanhost $nickhost $chan]]} {  set banmask "*!*@[join [lindex [split [getchanhost $nickhost $chan] @] 1]]"   } else {      set banmask "*!*[string trimleft [maskhost [getchanhost $nickhost $chan]] *!]" }  }  if {$reason == ""} {  set reason "Banned via JAbot by $nick. No reason specified."  }if {[matchattr [nick2hand $nickhost $chan] f|f $chan]} {  return 0}   if {[botisop $chan]} {  if {[onchan $nickhost $chan]} {         if {![string match -nocase $nickhost $botname] || ![isbotnick $nickhost]} {         if {$time == "0"} {           newchanban $chan $banmask [nick2hand $nick] "$reason (permanent)" $time        } else {           newchanban $chan $banmask [nick2hand $nick] "$reason ($time minutes)" $time            }            webbanlist_createhtml        } else {      putserv "$guardmethod $nick : $nick whats wrong with you?"          }} else {    if {![string equal -nocase [maskhost [getchanhost $botnick]] $nickhost] && ![string equal -nocase $botnick $nickhost]} { newchanban $chan $nickhost $handle "$reason" $time      putserv "$guardmethod $nick : $nick, \002$nickhost\002 has been added to the $chan banlist, and will be banned when he enters."    webbanlist_createhtml        } else {      putserv "$guardmethod $nick : $nick, quit messing around."        }                }  } else {    putserv "$guardmethod $nick  : $botnick is not opped on $chan"    } }

Statistics: Posted by Aron — Wed Jan 28, 2004 12:23 pm

Kicking nicknames with brackets in them

2004-01-23T08:49:55-04:00

Haven't you learned anything by now? In if {$foo == "foo"} { eyther do an string tolower/ toupper to the $foo or use the "string equal -nocase" to do that for you cos FOO (Foo, fOo, etc.) is not equal with "foo"..

Code:

if {![string equal -nocase [maskhost [getchanhost $botnick]] $nickhost] .. etc.

no way, better use the $botname to get it's nick!ident@host that that and cmpare it with "string match -nocase".

Code:

if {[string match -nocase $nickhost $botname]} { # etc. }

Your code is so mixed up.. confused me a a lil bit..

Code:

if {![string equal -nocase [maskhost [getchanhost $botnick]] [maskhost $nickhost]] && ![string equal -nocase $botnick $nickhost]} {

no, better use "isbotnick" instead of "![string equal -nocase $botnick $nickhost]" if you are comparing the two nicks or something similar.

Code:

if {[nick2hand $nickhost] != "*"} {   if {[matchattr [nick2hand $nickhost $chan] f|f $chan]} {     return 0   } }

Either store the [nick2hand $nickhost] in to an variable and don't call it twice or go directly to:

Code:

if {[matchattr [nick2hand $nickhost $chan] f|f $chan]} {   return 0 }

cos as far as I see there is no need of the first check.

Code:

if {$time == "perm"} { set time "0" }

should be:

Code:

if {[string tolower $time] == "perm"} { set time 0 }

Statistics: Posted by caesar — Fri Jan 23, 2004 8:49 am

Kicking nicknames with brackets in them

2004-01-23T08:06:08-04:00

alright, thanks a lot

It's working now, but now im having the same problem with my ban command... I just don't see it..

Code:

proc academy:ban {nick host handle chan text} {   global botnick guardmethod   if {(![authed $handle]) || ![string equal -nocase $chan "#jedi-academy"]} { return 0 }   set userlevel [level $handle]  set nickhost [lindex [split $text] 0]  set time [lindex $text 1]  set reason [join [lrange [split $text] 2 end]]  if {$userlevel == "Knight" || $nickhost == ""} {return 0}  if {$time == "perm"} { set time "0" }  if {[onchan $nickhost $chan]} {   if {[string match "*.users.quakenet.org" [getchanhost $nickhost $chan]]} {  set banmask "*!*@[lindex [split [getchanhost $nickhost $chan] @] 1]"   } else {      set banmask "*!*[string trimleft [maskhost [getchanhost $nickhost $chan]] *!]" }  }  if {$reason == ""} {  set reason "Banned via JAbot by $nick. No reason specified."  }  if {[nick2hand $nickhost] != "*"} {  if {[matchattr [nick2hand $nickhost $chan] f|f $chan]} {   return 0 }   }  if {[botisop $chan]} {  if {[onchan $nickhost $chan]} {    if {![string equal -nocase [maskhost [getchanhost $botnick]] [maskhost $nickhost]] && ![string equal -nocase $botnick $nickhost]} {         if {$time == "0"} {           newchanban $chan $banmask [nick2hand $nick] "$reason (permanent)" $time        } else {           newchanban $chan $banmask [nick2hand $nick] "$reason ($time minutes)" $time            }            webbanlist_createhtml        } else {      putserv "$guardmethod $nick : $nick whats wrong with you?"          }} else {    if {![string equal -nocase [maskhost [getchanhost $botnick]] $nickhost] && ![string equal -nocase $botnick $nickhost]} { newchanban $chan $nickhost $handle "$reason" $time      putserv "$guardmethod $nick : $nick, \002$nickhost\002 has been added to the $chan banlist, and will be banned when he enters."    webbanlist_createhtml        } else {      putserv "$guardmethod $nick : $nick, quit messing around."        }                }  } else {    putserv "$guardmethod $nick  : $botnick is not opped on $chan"    } }

Statistics: Posted by Aron — Fri Jan 23, 2004 8:06 am

Kicking nicknames with brackets in them

2004-01-22T22:34:35-04:00

Just to clear it up, as it may pose to some a bit of confusion...

We join the "lrange" result (the reason) because lrange returns a list of elements, and the list needs to be converted back to string...

You do NOT join the result of "lindex" (in this case, anyways), as it returns a single element, which happens to already be a string.

Usually, you will only need to use join on a lindex operation when the list you are working with is a list of lists (that is, sub-lists contained within a list).

Statistics: Posted by strikelight — Thu Jan 22, 2004 10:34 pm

Re: Kicking nicknames with brackets in them

2004-01-22T21:07:37-04:00

Don't 'join' the string returned by 'lindex' and everything should be fine

Statistics: Posted by user — Thu Jan 22, 2004 9:07 pm

Kicking nicknames with brackets in them

2004-01-22T20:30:41-04:00

the nickname is only stored in nickhost, and there are no processes interfering with it.

Statistics: Posted by Aron — Thu Jan 22, 2004 8:30 pm

Kicking nicknames with brackets in them

2004-01-22T19:39:02-04:00

read my first post

Statistics: Posted by user — Thu Jan 22, 2004 7:39 pm

Kicking nicknames with brackets in them

2004-01-22T18:57:16-04:00

Code:

proc academy:kick {nick host handle chan text} {   global botnick guardmethod   if {(![authed $handle]) || ![string equal -nocase $chan "#jedi-academy"]} { return 0 }  set userlevel [level $handle]  set reason [join [lrange [split $text] 1 end]]  if {$reason == ""} {    set reason "requested by $nick"  }    set nickhost [join [lindex [split $text] 0]]  if {[matchattr [nick2hand $nickhost $chan] f|f $chan]} { return 0 } if {[string equal -nocase $nickhost "me"]} {     set nickhost $nick    set reason "$nick is a poopoohead!"  }      if {[botisop $chan]} {  if {![string equal -nocase $botnick $nickhost]} {       putkick $chan $nickhost $reason    } else {        putserv "NOTICE $nick :Stop messing around..."    }  } else {      putserv "NOTICE $nick :I'm not opped in $chan!"  }}proc lastban_check {nick uhost hand chan mode victim } { global lastbanned  if {[lindex $mode 0] == "+b"} {   set lastbanned($chan) $victim   }  }

changed the code. Still the same error.

"[16:57] Tcl error [academy:kick]: list element in braces followed by "testing" instead of space"

The nick i tried to kick was {}testing

Statistics: Posted by Aron — Thu Jan 22, 2004 6:57 pm

Kicking nicknames with brackets in them

2004-01-22T15:55:53-04:00

After a lil discution on irc with strikelight and Souperman and thinked a lil bit at that thing I've realised that strikelight was right, so the correct and best solution is [join [lrange [split $text] 1 end]]. Thanks for clearing that out strikelight, ow you one

/me dose 20 hail mary's to be forgiven

Statistics: Posted by caesar — Thu Jan 22, 2004 3:55 pm

Kicking nicknames with brackets in them

2004-01-22T15:25:17-04:00

Umm.. actualy no, it's an string.. umm. To be honest I haven't understood completly your response..

No caesar... lrange returns a list....

from the TCL Manpages for lrange:

This command will return a new list consisting of elements first through last, inclusive.

Hence, the need for "join".

Statistics: Posted by strikelight — Thu Jan 22, 2004 3:25 pm

Kicking nicknames with brackets in them

2004-01-22T15:18:20-04:00

Umm.. actualy no, it's an string.. umm. To be honest I haven't understood completly your response..

Statistics: Posted by caesar — Thu Jan 22, 2004 3:18 pm

Kicking nicknames with brackets in them

2004-01-22T14:30:07-04:00

lrange returns a (sub)list, and from my understanding, $reason is supposed to be a string... as such you need to apply the join tcl command to the result to make it into a proper string.
Yup, you also have to [split] it before using [lrange] on it, like caesar says.

Right, however my response was in fact a reply to caesar's post.

Statistics: Posted by strikelight — Thu Jan 22, 2004 2:30 pm