egghelp/eggheads community

i need basic script: !kill, !kline

2003-09-10T01:55:04-04:00

Huh? What changes can be applied to this two then? And I'm not "spaming" around for posts

http://forum.egghelp.org/viewtopic.php?p=26837#26837
For starters.. and Sir_Fz already took care of what you repeated.

Statistics: Posted by strikelight — Wed Sep 10, 2003 1:55 am

i need basic script: !kill, !kline

2003-09-10T00:56:52-04:00

Huh? What changes can be applied to this two then? And I'm not "spaming" around for posts

Statistics: Posted by caesar — Wed Sep 10, 2003 12:56 am

i need basic script: !kill, !kline

2003-09-09T15:56:13-04:00

The

Code:

set user [lindex [split $arg] 0]set reason [lrange [split $arg] 1 end]

will do fine

Not without the mods mentioned in the last few posts...
quit trying to increase your post count, and read the posts :p

Statistics: Posted by strikelight — Tue Sep 09, 2003 3:56 pm

i need basic script: !kill, !kline

2003-09-09T15:54:51-04:00

The

Code:

set user [lindex [split $arg] 0]set reason [lrange [split $arg] 1 end]

will do fine

Statistics: Posted by caesar — Tue Sep 09, 2003 3:54 pm

i need basic script: !kill, !kline

2003-09-09T15:46:04-04:00

lol, yes you're right.. the mistake of skipping the ":" is very common
also if you see in the first code given "reason is set to [lindex $arg 1]" so its only 1 word too

Statistics: Posted by Sir_Fz — Tue Sep 09, 2003 3:46 pm

i need basic script: !kill, !kline

2003-09-09T15:42:10-04:00

Actually, upon furthur inspection of this case, with the given data,
the llength [split $arg]] == 2 is the correct assertion, and I will explain why...

The code mentioned in this thread was:

Code:

putserv "KILL $user $reason"

Now, this will result in only using word 1 from $reason to issue the kill... to have a multi-word reason, this would need to be modified to:

Code:

putserv "KILL $user :$reason"

Statistics: Posted by strikelight — Tue Sep 09, 2003 3:42 pm

i need basic script: !kill, !kline

2003-09-09T15:41:57-04:00

ok, I got how it works now, thanx

Statistics: Posted by Sir_Fz — Tue Sep 09, 2003 3:41 pm

i need basic script: !kill, !kline

2003-09-09T15:37:40-04:00

It dosen't matter what arguments you use in order to function propertly. The [lindex [split $arg] 0] and the [lrange [split $arg] 1 end] are correct. Also, it can be equal or bigger than 2 or just equal or smaller or whatever you want, it will still work.

Statistics: Posted by caesar — Tue Sep 09, 2003 3:37 pm

i need basic script: !kill, !kline

2003-09-09T15:37:28-04:00

yes but i guess the reason would be more than one element
so the user would be [lindex [split $arg] 0] and the reason would be [lrange [split $arg] 1 end] so the llength wouldn't do it in this case ?

To be honest, I wasn't really paying attention to the application, just the premise...

But yes, llength will still apply... just needs to be modded slightly...

Code:

if {[llength [split $arg]] >= 2} { acceptable parameters code goes here }

(Greater than or equal to 2 param's).

Statistics: Posted by strikelight — Tue Sep 09, 2003 3:37 pm

i need basic script: !kill, !kline

2003-09-09T15:33:37-04:00

yes but i guess the reason would be more than one element
so the user would be [lindex [split $arg] 0] and the reason would be [lrange [split $arg] 1 end] so the llength wouldn't do it in this case ?

Statistics: Posted by Sir_Fz — Tue Sep 09, 2003 3:33 pm

i need basic script: !kill, !kline

2003-09-09T15:26:44-04:00

so if {[llength [split $arg]] == 2} { ... } will check if the second word is empty then it will do whatever.... ?

Not quite...
It will check if the length of the list is 2, implying that there are (no more than, and no less than) two non-empty elements within the [split $arg] list.

Statistics: Posted by strikelight — Tue Sep 09, 2003 3:26 pm

i need basic script: !kill, !kline

2003-09-09T15:26:15-04:00

The llength check will "test" if you have specified the two arguments that are needed, that's all, so yes, basicaly it would do the trick

Statistics: Posted by caesar — Tue Sep 09, 2003 3:26 pm

i need basic script: !kill, !kline

2003-09-09T15:19:43-04:00

so if {[llength [split $arg]] == 2} { ... } will check if the second word is empty then it will do whatever.... ?

Statistics: Posted by Sir_Fz — Tue Sep 09, 2003 3:19 pm

i need basic script: !kill, !kline

2003-09-09T14:52:09-04:00

the string length is to check if the string is empty, so [split $arg] would still be recommended... or not ?

'string length' is a STRING operation (hence the 'string' word)
'llength' is a LIST operation (hence the 'l' letter in front)

Given: $arg is a string

for 'llength' we need a list parameter... thus we split the string ($arg) converting it into a list.

for 'string length', $arg is already a string thus we do not need to convert it.

Statistics: Posted by strikelight — Tue Sep 09, 2003 2:52 pm

i need basic script: !kill, !kline

2003-09-09T14:49:12-04:00

I think checking $arg as the first thing inside the proc would make the most sense. Then you would avoid all that work for nothing. No need to split an empty string just to find out it's empty
The best way to check if a variable is empty (imo) is
Code:
if {[string length $arg]} {not empty} {empty}

That's nice and all... but as in this case, we are interested in checking for TWO (2) arguments within arg... thus, if only one is set instead of two, your check would give it a pass, when it should have failed...

For this situation caesars (+users fix) would be the best answer:

Code:

if {[llength [split $arg]] == 2} { ... }

Statistics: Posted by strikelight — Tue Sep 09, 2003 2:49 pm