egghelp/eggheads community

ASCII ban

2003-06-11T01:03:21-04:00

This thing with the userlist is not a good ideea because in case someone uses a colour or something today, it's added to the list and after 24 hours when it uses it again it's directly banned so he used only one time the colours per that day.

Also, instead of adding a user, removing it and so on, just add it's host to a certain user and see if it's mask is there either by checking the masks or by matching his handle with a certain flag of that user.

Statistics: Posted by caesar — Wed Jun 11, 2003 1:03 am

ASCII ban

2003-06-10T14:52:32-04:00

Why not use global variable?

like:

Code:

# add a userproc my_adduser {mask} {    global my_users    set my_users([string tolower $mask]) ""}# return "" = not found# else return the 1st mask which matchedproc my_searchuser {uhost} {    global my_users    set uhost [string tolower $uhost]    foreach mask $my_users {        if {[string match $mask $uhost]} {            return $mask        }    }    return}# remove a userproc my_deluser {mask} {    global my_users    catch {unset my_users($mask)}}

Code:

set validuser [my_searchuser $nick!$uhost]if {$validuser == ""} {  #User isn't added, as noted  #So do this code  my_adduser [maskhost $uhost]}if {$validuser != ""} {  #User is added, we just added him above, so this gets called now  #SO we call ban code}# remove the user:my_deluser $validuser

Statistics: Posted by TsT — Tue Jun 10, 2003 2:52 pm

ASCII ban

2003-06-09T11:31:02-04:00

I'll goto bed now.

You wanna see how red my cheeks are, flame grilled steak any1.

Statistics: Posted by ppslim — Mon Jun 09, 2003 11:31 am

ASCII ban

2003-06-09T11:15:09-04:00

ppslim, actually he had it correct the first time. The reason is that he has a 'return' statement after adding the user. So basically he's using the user record as a flag to see if the person has been warned already.

1. sheep sends a msg with control chars
2. bot checks if user exists
3: no - so bot adds user and sends notice, returns
4. sheep sends another msg with control chars
5. bot checks if user exists
6. yes - so bot bans and deletes user (resetting flag), returns

It's actually a very smart way of doing it, because using the user record automatically adds permanance (e.g. bot saves user records automatically, so on .restart the user still exists).

Statistics: Posted by stdragon — Mon Jun 09, 2003 11:15 am

ASCII ban

2003-06-09T08:22:17-04:00

For the issue I posted, take this

"usera" is not added to the bot. He triggers the bind.

Code:

if {![validuser usera]} {  #User isn't added, as noted  #So do this code  adduser usera}if {[validuser usera]} {  #User is added, we just added him above, so this gets called now  #SO we call ban code}

Statistics: Posted by ppslim — Mon Jun 09, 2003 8:22 am

ASCII ban

2003-06-09T08:01:59-04:00

could u give me an example?

Statistics: Posted by ReaLz — Mon Jun 09, 2003 8:01 am

ASCII ban

2003-06-09T05:38:24-04:00

Exactly. Anyway, you should use an array to do what you do with the userlist.

Statistics: Posted by caesar — Mon Jun 09, 2003 5:38 am

ASCII ban

2003-06-09T05:27:44-04:00

you mean to write first the

Code:

[validuser

and then the

Code:

![validuser

Statistics: Posted by ReaLz — Mon Jun 09, 2003 5:27 am

ASCII ban

2003-06-09T05:09:04-04:00

stdragon was correct in regards to the script being called multiple times, however, there is a second reason for the notice and ban in one go, that requires only a single control character to be used in the text.

In your second "if" test, you see if the user ISNT there. If not, then add them and warn them.

Your third i"if" checks to see if they ARE added. If so, then ban them.

The way you use this is very correct, however, but your ordering isn't.

The first "validuser" returns 0, so add them. The second "validuser" returns 1, because you have just added them.

A qucik fix for this, is to switch the order in which these "if" statments are called.

Statistics: Posted by ppslim — Mon Jun 09, 2003 5:09 am

ASCII ban

2003-06-08T16:48:07-04:00

No it won't.

Statistics: Posted by stdragon — Sun Jun 08, 2003 4:48 pm

ASCII ban

2003-06-08T16:24:55-04:00

yeah... good idea thanx
but it will still be a problem if a user uses

Code:

\002

and

Code:

\003

in the same line

Statistics: Posted by ReaLz — Sun Jun 08, 2003 4:24 pm

ASCII ban

2003-06-08T13:47:24-04:00

You realize that ASCII characters include a-z, A-Z, 0-9, and all that right? heh

Aside from that, the reason you're probably having this problem is that the pubm bind is "stackable". Which means, it gets executed multiple times for the same input. So if a user types a line with more than one of your forbidden characters, the procedure will get called more than once, thus warning him and banning him.

Instead, you should have a single bind with *, and check for illegal chars within it.

Statistics: Posted by stdragon — Sun Jun 08, 2003 1:47 pm

ASCII ban

2003-06-08T12:46:21-04:00

I'm trying to make a script that firstly warns the users who use ASCII chars in the channel and if they do it again they get banned... but when someone uses ASCII chars it gets banned and the bot also sends him notices at the same time.

Code:

bind pubm - "* *\002*" ascii:pubmbind pubm - "* *\003*" ascii:pubmbind pubm - "* *\006*" ascii:pubmbind pubm - "* *\007*" ascii:pubmbind pubm - "* *\017*" ascii:pubmbind pubm - "* *\026*" ascii:pubmbind pubm - "* *\037*" ascii:pubmproc ascii:pubm {nick uhost hand chan text} {  if {[matchattr $hand of|fo $chan] || [isop $nick $chan]} {    return  }if {![validuser $nick]} {adduser $nickputserv "NOTICE $nick :Please don't use ASCII chars in $chan"return}if {[validuser $nick]} {deluser $nickset mask "*!*@[lindex [split $uhost @] 1]"newban $mask ASCII "\00210 minutes\002 ban for using \002ASCII characters\002 within \002$chan\002 " 10return 1}}

Statistics: Posted by ReaLz — Sun Jun 08, 2003 12:46 pm