egghelp/eggheads community

script for multivoice

2003-03-09T08:36:50-04:00

it works !! thank you caesar and everybody else for your help and your patience
see you

Statistics: Posted by Guest — Sun Mar 09, 2003 8:36 am

script for multivoice

2003-03-09T02:29:55-04:00

Actualy I've said earlyer that there is no need for the 'botnick' thing. Here is the *bug free* version that should work fine:

Code:

bind pub o|o !v pub:v proc pub:v {nick host handle channel arg} {   if {[llength [split $arg]] == 0} {    putserv "NOTICE $nick :\002Usage:\002 !v  \[nick2\] \[nick3\] .. etc."   return 0 }  if {![botisop $channel]} {     putserv "NOTICE $nick :I'm not oped in $channel."   return 0 }   foreach user [split $arg] {    if {![onchan $user $channel] || [isop $user $channel] || [isvoice $user $channel]} { continue }     pushmode $channel +v $user   } }

I'm a bit rusty.. Got to consult again the manual..

Statistics: Posted by caesar — Sun Mar 09, 2003 2:29 am

script for multivoice

2003-03-08T12:46:02-04:00

i don't have a mistake message anymore but it still doesn't work

Statistics: Posted by Guest — Sat Mar 08, 2003 12:46 pm

script for multivoice

2003-03-08T11:17:02-04:00

Code:

set botnick [string tolower $botnick]

would overwrite the global var $botnick with it's lowercase version..

change it to

Code:

set botnick2 [string tolower $botnick]

and replace every following $botnick with $botnick2

i have no running eggie atm, but i think that will work.

Statistics: Posted by GodOfSuicide — Sat Mar 08, 2003 11:17 am

script for multivoice

2003-03-08T10:17:23-04:00

sorry but it still doesn't work. i have this message in the party-line

Code:

Tcl error [pub:v]: can't set "botnick": read-only variable

Statistics: Posted by Guest — Sat Mar 08, 2003 10:17 am

script for multivoice

2003-03-08T09:49:08-04:00

hehe of course you do

Code:

if {[llength $arg] > 0} {

should be

Code:

if {[llength [split $arg]] == 0} {

Statistics: Posted by Papillon — Sat Mar 08, 2003 9:49 am

script for multivoice

2003-03-08T09:30:49-04:00

thanks for everything but for me doesn't work, i get a notice in which there is " Usage: !v nick1 nick2 nick3" but nothing happens on the chan.
i hope you will go on helping me , thank you again

Statistics: Posted by Guest — Sat Mar 08, 2003 9:30 am

script for multivoice

2003-03-08T08:21:27-04:00

ceasar... read the FAQ.......

You should NOT do list commands on a string. $arg is a string.. llength is a list-command. This means you have to do [llength [split $arg]] to make it correct..

this is basic tcl-coding and you should have understood this by now
.. if not maybe you should take a second look at some of the tcl-tutorials online?

string tolwer is used ... ie when you want to make a match without upper/lowercase difference.
bLa == bla <-- false
[string tolower bLa] == bla <-- true

Statistics: Posted by Papillon — Sat Mar 08, 2003 8:21 am

script for multivoice

2003-03-08T07:44:34-04:00

My appologies.. I've finaly understood what you meant to say about the '$botnick == $user' check. He get checked at the [isop] thing. As for your 'simple' question, I haven't understood what you mean by that. I admit that I don't know even don't have a clue sometimes when I must put that 'tolower' thing.

About the 'flame', this was just a lil joke. I'm sorry if isn't funny.

Statistics: Posted by caesar — Sat Mar 08, 2003 7:44 am

script for multivoice

2003-03-08T06:58:48-04:00

flames]If you don't consider them then do yourself the code.[/flames]

Such flames are very nice, but certainly out of place. And the smiley next to it makes it even more ambiguous. Also, it is a lousy practise to first post code (with errors) and then refuse to listen to comments on it.

With my initial posting I suspected this would (again) end up in a long and dreadfull iterating on your code, as it usually does. But I've of lost my appetite for doing that.

First, my question was plain and simple:

The question for caesar is: when did you use the first list command?

How difficult is that question? You refused to read and properly answer the question.
You are using [llength] on a string. Such error has been told you at least 10 times before on this forum. And it even is treated in the FAQ question.

Second: your check for $botnick == $user is silly. First you check if the bot is op and if the bot is op, you continue the proc. Then you check from the list of users if the user has ops. If it has ops, it is not voiced. At that point the bot will not be voiced, because it has ops. So, there is no need to check for the $botnick == $user. And subsequently there is no need for all the [string tolower], which you always seem to throw in because you fail to understand properly what is going on.

Statistics: Posted by egghead — Sat Mar 08, 2003 6:58 am

script for multivoice

2003-03-08T05:31:45-04:00

Also, if you are talking about the 'if {![onchan $user $channel] || [isop $user $channel] || [isvoice $user $channel] || $botnick == $user} { continue }' line it's correct. he wants a multivoice thing and this calls for this checks. Already oped, voiced or not in channel and the bot must be skiped.. I consider this correctly..
flames]If you don't consider them then do yourself the code.[/flames]

Statistics: Posted by caesar — Sat Mar 08, 2003 5:31 am

script for multivoice

2003-03-08T05:20:04-04:00

I haven't understood what you meant to say. I've tested it and works fine as it is after the changes are made. If you are talking about to remove the "set arg [string tolower $arg]" is correct to remove it.

Statistics: Posted by caesar — Sat Mar 08, 2003 5:20 am

script for multivoice

2003-03-08T03:23:50-04:00

from:

Code:

 foreach user $arg {

to:

Code:

 foreach user [split $arg] {

You did [string tolower $botnick] before comparing it to the $user, which is 1 problem solved.

try splitting $arg before doing list commands on it...

The question for caesar is: when did you use the first list command?

Once you have done the [split $arg] at the correct spot, you can move the [string tolower $arg] above that.

After that, you can clean up the code, and start wondering if all this [string tolower] business is really needed... is it really needed to compare the $user with the $botnick? Or is there already a test that [botisop] and a second test which will not voice a user that if he/she already [isop]?

Statistics: Posted by egghead — Sat Mar 08, 2003 3:23 am

script for multivoice

2003-03-08T02:38:48-04:00

from:

Code:

 foreach user $arg {

to:

Code:

 foreach user [split $arg] {

Statistics: Posted by caesar — Sat Mar 08, 2003 2:38 am

script for multivoice

2003-03-07T19:13:21-04:00

try splitting $arg before doing list commands on it...

Statistics: Posted by Papillon — Fri Mar 07, 2003 7:13 pm