egghelp/eggheads community

what`s wrong in this script ?

2003-02-22T23:46:23-04:00

Not to nitpick but using == still makes it case sensitive.

% expr {"asdf" == "asdf"}
1
% expr {"asdf" == "ASDF"}
0

The best way to check that is as ppslim said,
if {[string equal -nocase $string1 $string2]} {
blah
}

Statistics: Posted by stdragon — Sat Feb 22, 2003 11:46 pm

what`s wrong in this script ?

2003-02-22T19:20:55-04:00

Why use a matching function, when theres no wildcards. "string equal" is more suited gfor this.

if i want to make a equal check i would simply use $who == "$botnick![getchanhost $botnick]" .

but thx stdragon for correcting the expression for string match, i knew only seen it somewhere like this ^.^.

Statistics: Posted by De Kus — Sat Feb 22, 2003 7:20 pm

what`s wrong in this script ?

2003-02-22T17:50:59-04:00

Actually since this is from a +b, $who may have wildcards.

But I should have read more carefully instead of copy and pasting, because the arguments are in the wrong order.

string match -nocase $who "$botnick![getchanhost $botnick]"

(the pattern comes before the string to match against)

Statistics: Posted by stdragon — Sat Feb 22, 2003 5:50 pm

what`s wrong in this script ?

2003-02-22T17:21:57-04:00

It might be easier to say

string match -nocase "$botnick![getchanhost $botnick]" $who

And I thought better of you

Why use a matching function, when theres no wildcards. "string equal" is more suited gfor this.

Statistics: Posted by ppslim — Sat Feb 22, 2003 5:21 pm

what`s wrong in this script ?

2003-02-22T16:50:23-04:00

Humm.. yes, that will be usefull only for the +b bind.

Statistics: Posted by caesar — Sat Feb 22, 2003 4:50 pm

what`s wrong in this script ?

2003-02-22T16:38:45-04:00

It might be easier to say

string match -nocase "$botnick![getchanhost $botnick]" $who

Statistics: Posted by stdragon — Sat Feb 22, 2003 4:38 pm

hmmm

2003-02-22T15:32:32-04:00

means the [string match m*h muh] expression works? great, ill remember that .

Statistics: Posted by De Kus — Sat Feb 22, 2003 3:32 pm

what`s wrong in this script ?

2003-02-22T15:11:17-04:00

thanks alll it works fine

Statistics: Posted by Pitchat — Sat Feb 22, 2003 3:11 pm

what`s wrong in this script ?

2003-02-22T15:07:22-04:00

bad suggestion, i think. because $who will not be a nick, but a hostmark in case of a +b chanmode .
but you are right, i should tolower the string!

lets show it in an example. lets say we are on an irc server having a bot called "StarZ|Clan" on hostmark "ben1@server4.phoenix-shells.de". someone sets the ban "*!*@server4.phoenix-shells.de". i am sure "*!*@server4.phoenix-shells.de" != "StarZ|Clan". but a ban "s*|clan!*@*.*" woudnt match "StarZ|Clan!ben1@server4.phoenix-shells.de", either, but would be a legal ban against the bot. its time we really need tolower again .
so [string match "$botnick![getchanhost $botnick]" $who] must be replaced with

Code:

[string match [string tolower "$botnick![getchanhost $botnick]"] [string tolower $who]]

Statistics: Posted by De Kus — Sat Feb 22, 2003 3:07 pm

what`s wrong in this script ?

2003-02-22T02:37:38-04:00

And a simple sugestion, replace:

Code:

  } elseif { $mode == "+b" && [string match "$botnick![getchanhost $botnick]" $who] } {

with:

Code:

  } elseif { $mode == "+b" && [string match "$who" "$botname"]} {

Statistics: Posted by caesar — Sat Feb 22, 2003 2:37 am

what`s wrong in this script ?

2003-02-22T02:26:55-04:00

'strlwr' is a proc from alltools.tcl and stands for 'string tolower', so it's correct

Statistics: Posted by caesar — Sat Feb 22, 2003 2:26 am

well, well

2003-02-22T15:09:07-04:00

there are really a few misstakes.
fot comparing the banhostmark i would try using string match comparing "$botnick![getchanhost $botnick]" with "$who". i hope string match can compare with wildcards, i think it can, but im not sure. but i am sure there is a way to do that.
then i dunno if you can use ; to end command lines, ussually you start a new line . but if you use elseif instead of if in the second time, you dont need the first return 0 at all.
if you pray, perhaps it works:

Code:

bind mode - * modedeopproc modedeop {nick host hand chan mode who} {  global botnick botname  if { $mode == "-o" && $who == $botnick && [strlwr $botnick] != [strlwr $nick] } {    putbot "Precieuse" "msgbot $nick ($host) m'a déopé sur $chan"   } elseif { $mode == "+b" && [string match [string tolower "$botnick![getchanhost $botnick]"] [string tolower $who]] } {    putbot "Precieuse" "msgbot $nick ($host) m'a banni sur $chan"  }}bind kick - "* $botnick" kickmsgproc kickmsg {nick host hand chan knick reason } {  putbot "Precieuse" "msgbot $nick ($host) m'a kické sur $chan (raison invoquée : $reason)"}

eh btw, does strlwr the same the string tolower?! if not and strlwr is called a not availbe function, replace it ..

Statistics: Posted by De Kus — Sat Feb 22, 2003 12:55 am

what`s wrong in this script ?

2003-02-21T16:30:10-04:00

hi
this is suppose to be a script that warn if the bot is been deop by somebody but it doesnt work at all

bind mode - * modedeop

proc modedeop {nick host hand chan mode who} {
global botnick botname

if { $mode == "-o" && $who == $botnick && [strlwr $botnick] != [strlwr $nick] } { putbot "Precieuse" "msgbot $nick ($host) m'a déopé sur $chan" ; return 0 }

set banhost "*!*[string range $who [string first @ $who] e]"
set bothost "*!*[string range $botname [string first @ $botname] e]"

if { $mode == "+b" && $banhost == $bothost} { putbot "Precieuse" "msgbot $nick ($host) m'a banni sur $chan" }
return 0 ;
}

bind kick - * kickmsg
proc kickmsg {nick host hand chan knick reason } {
global botnick
if {[strlwr $knick] == [strlwr $botnick] } { putbot "Precieuse" "msgbot $nick ($host) m'a kické sur $chan (raison invoquée : $reason)"}
}

putlog "deop check script lancé - Date: 4-02-01"

thanks
Pitchat[/code]

Statistics: Posted by Pitchat — Fri Feb 21, 2003 4:30 pm