egghelp/eggheads community

problem

2003-02-17T15:26:13-04:00

Problem fixed:

Code:

set badfile "badword.txt" bind pubm - * pubm:badword proc pubm:badword {nick uhost hand channel args } {global badfile if {![file exists $badfile]} {   putlog "Error: Le $badfile de dossier n'existent pas."   return } set file [open "$badfile" r] while {![eof $file]} {   set line [gets $file]   foreach word [split $args] {     if {![string equal "$word" $line]} { continue }     set found 1     break   } } catch {close $file} if {![info exists found]} { return 0 } putserv "PRIVMSG $channel :yes" }

Thank you. Now is working, a bit slow but is working..

Statistics: Posted by caesar — Mon Feb 17, 2003 3:26 pm

problem

2003-02-17T15:12:12-04:00

Listen, I tried, but I don't seem to get anywhere.

There was no need to move the "foreach" out of the while loop. It is slower when outside the while loop, as it has to open, close, open, close, open, close (one open and close per word in IRC), rather the open and close once.

Second, I noticed that you are not even closing the file. SO for each word, you open a file, but don't close it (only when the word matches).

Statistics: Posted by ppslim — Mon Feb 17, 2003 3:12 pm

problem

2003-02-17T15:06:51-04:00

Oh. Here is the code that seems to be working fine (no more freeze):

Code:

set badfile "badword.txt" bind pubm - * pubm:badword proc pubm:badword {nick uhost hand channel text} {   global badfile   if {![file exists $badfile]} {     putlog "Error: Le $badfile de dossier n'existent pas."   return }   foreach word $text {     set file [open "$badfile" r]     while {![eof $file]} {       set line [gets $file]       if {![string equal "$word" $line]} { continue }       putserv "PRIVMSG $channel :yes"       catch {close $fid}     return }   break }   putserv "PRIVMSG $channel :nope" }

But now the problems is that he dosen't try to match all words typed in channel. The 'badword.txt' has in it 'foo' and when I type 'foo' I get an yes (as it's working), but when I try a something foo is not working, I get an nope. Also I've tryed with the string match and again same result: nope.

Statistics: Posted by caesar — Mon Feb 17, 2003 3:06 pm

problem

2003-02-17T14:02:27-04:00

Then you still havn't moved the "gets" command to the correct place.

Statistics: Posted by ppslim — Mon Feb 17, 2003 2:02 pm

problem

2003-02-17T13:30:14-04:00

I was looking for a direct match. I've removed all '[split]' and changed that line with 'if {![string equal "$word" $line]} { continue } ' and I still get the same result. It eats about 98% CPU and mem.. and freezes.

Statistics: Posted by caesar — Mon Feb 17, 2003 1:30 pm

problem

2003-02-17T10:57:17-04:00

I have gone over and over the code, and it hit me on the, 1000 ish attempt.

Code:

{![string match "$word" [split $line]]}

Are you trying to do a direct match, or using wildcards?

If wildcards, this this is the right way to do it, however, you will need to remove the "split" command, and possibly use the -nocase option (otherwise the match can be missed with mixed case)

If a direct match, you may want to use the "string equal" command. Again, you will need to remove the "split" command, and possible use the -nocase option.,

Statistics: Posted by ppslim — Mon Feb 17, 2003 10:57 am

problem

2003-02-17T10:33:44-04:00

nvm.

Statistics: Posted by egghead — Mon Feb 17, 2003 10:33 am

problem

2003-02-17T08:32:42-04:00

I've replaced 'args' with 'text' and same thing, no difference at all.

Statistics: Posted by caesar — Mon Feb 17, 2003 8:32 am

problem

2003-02-17T08:28:49-04:00

then do not use $args.

The foreach loop should be a matter of changing the variable name.

Statistics: Posted by ppslim — Mon Feb 17, 2003 8:28 am

problem

2003-02-17T08:24:23-04:00

In 'badword.txt' are some words placed like this:

Code:

first_wordsecond_word.. etc.

and I've wanted it to do the foreach and compare all the words from the line said in channel with all the words in the file.

Oh, and also, tryed the code you have previously posted and same problem as my first code: freeze..

Statistics: Posted by caesar — Mon Feb 17, 2003 8:24 am

problem

2003-02-17T07:54:37-04:00

1: You code is very bunched up.

You do an IF, open a brace and then goto a new line. However, when you close the brace, you place it at the end of a line, rathet than a on a new one.

While this isn't wrong, and is perfectly valid, it makes for hard to read code.

2: Indenting.

Along with doing braces, you should indent your code. It makes for far simpler reading again. You can tell what code, bellongs in which brace.

If you start doing a mass of if, while, foreach and for loops, you can find you get lost on howmany braces you have open. Indenting from the off, will allow you too know how many braces need closing, and making for simple backtracking.

Your code (first post) can be represented as follows.

Code:

set badfile "badword.txt" bind pubm - * pubm:badword proc pubm:badword {nick uhost hand channel args } {   global badfile   if {![file exists $badfile]} {     putlog "Error: Le $badfile de dossier n'existent pas."     return  }   set file [open "$badfile" r]   set line [gets $file]   while {![eof $file]} {     foreach word [split $args] {       if {![string match "$word" [split $line]]} { continue }       set found 1       break    }   }   catch {close $file}   if {![info exists found]} { return 0 }   putlog "found" }

See how you can tell where in the code you are. I do not state you have to take this approach, but it's far simpler to read.

Now back to the issues.

Scrap the code from the second post, it's more flawed than the first.

In the code above (in this post), you need to move the "gets" command. Unless it's in the loop, EOF will never be called.

What exactly are you trying to match in the foreach loop:
The whole line of IRC input?
Each word of IRC input?

If it's the whole line, then you don't even need the foreach loop, or $args.

It's it's each word, then you shouldn't be using $args (it is currently causing you to match against the whole line).

Otherwise, there isn't enything else wrong.

Statistics: Posted by ppslim — Mon Feb 17, 2003 7:54 am

problem

2003-02-17T07:31:05-04:00

First, I haven't understood what you ment to say.. second, I have fixed it a bit and looks like this:

Code:

set badfile "badword.txt"bind pubm - * pubm:badwordproc pubm:badword {nick uhost hand channel text} {global badfileif {![file exists $badfile]} {putlog "Error: Le $badfile de dossier n'existent pas."return }foreach word [split $text] {set file [open "$badfile" r]while {![eof $file]} {set line [gets $file]if {![string match "$word" $line]} { continue }putserv "PRIVMSG $channel :yes"catch {close $fid}return }break }putserv "PRIVMSG $channel :nope"}

And what you wanted to tell me about the $args? But, now the problem is that he dosen't do the foreach thing corectly..

Statistics: Posted by caesar — Mon Feb 17, 2003 7:31 am

problem

2003-02-17T06:11:24-04:00

First off, I sugesta programmers file editor is used. Your code allways seems so hard to read, with close braces placed pretty much where you want.

Second, you may find it handy to post the error message. This usualy tells you the error without too muhc issue.

Third, your use of $args.

Forth, you only ever call the "gets" command once. This is causing it to loop forever, as it checks the one line over and over, never reaching EOF.

Statistics: Posted by ppslim — Mon Feb 17, 2003 6:11 am

problem

2003-02-17T05:31:56-04:00

Using this code:

Code:

set badfile "badword.txt"bind pubm - * pubm:badwordproc pubm:badword {nick uhost hand channel args } {global badfileif {![file exists $badfile]} {putlog "Error: Le $badfile de dossier n'existent pas."return }set file [open "$badfile" r]set line [gets $file]while {![eof $file]} {foreach word [split $args] { if {![string match "$word" [split $line]]} { continue } set found 1break }}catch {close $file}if {![info exists found]} { return 0 }putlog "found"}

my eggdrop dies. Where have I made a mistake? I know I've made one but I can find it.

Statistics: Posted by caesar — Mon Feb 17, 2003 5:31 am