egghelp/eggheads community

Lines in file

2003-02-07T03:10:40-04:00

Probably I havent seen it in the manual. Thanks for pointing it out..

Statistics: Posted by caesar — Fri Feb 07, 2003 3:10 am

Lines in file

2003-02-06T17:41:27-04:00

Very true.

Then the code should now read

Code:

set file "FILE.NAME"set lines [llength [split [read -nonewline [set fp [open $file r]]] "\n"]]close $fp

I forget that splitting at the newline, causes a extra blank element.

Read will leave a newline at the end, because of the nature of files, causing Tcl to think of a new element on split.

Statistics: Posted by ppslim — Thu Feb 06, 2003 5:41 pm

Lines in file

2003-02-06T17:11:00-04:00

So it does.

The w in the open command should be a r.

However, you said errors, and not error. Can you point any more out?

Create a one line file and run the script.

Statistics: Posted by egghead — Thu Feb 06, 2003 5:11 pm

Lines in file

2003-02-06T17:07:22-04:00

My advice, is whenever you see a new command introduced, try looking in the Tcl manual, or doing "man " on the shell.

Usage: wc [OPTION]... [FILE]...
Print line, word, and byte counts for each FILE, and a total line if
more than one FILE is specified. With no FILE, or when FILE is -,
read standard input.

Statistics: Posted by ppslim — Thu Feb 06, 2003 5:07 pm

Lines in file

2003-02-06T16:22:54-04:00

I have said that at that moment I didn't knew another alternative. I havent heard about the "wc" (wordcount) until now. ppslim's advice from changing the w (write) to r (read) seems corectly. There is no need to write, just to read from the file.

Also I don't see where this "wc" (wordcount) can be used on the *lines* count, not words count..

Statistics: Posted by caesar — Thu Feb 06, 2003 4:22 pm

Lines in file

2003-02-06T15:02:10-04:00

So it does.

The w in the open command should be a r.

However, you said errors, and not error. Can you point any more out?

Statistics: Posted by ppslim — Thu Feb 06, 2003 3:02 pm

Lines in file

2003-02-06T11:38:08-04:00

Well, not all the things are simple as they look like.. The usage of the 'foreach' thing is logical to be used. I don't have any ideea (at this moment) of another way to do the same thing. Combining mine and ppslim's reply you should solve this in a sec.. Heh..

Another way is to use OS utilities like "wc" (wordcount). A while loop with an increasing counter usually is not that efficient in terms of CPU usage although memory needs are low.

For smaller files the script given by ppslim (which contains some errors, finding and solving them are left as a trivial exercise) works ok. For larger files [exec] in combination with"wordcount" works good.

Statistics: Posted by egghead — Thu Feb 06, 2003 11:38 am

Lines in file

2003-02-06T10:55:46-04:00

well, i just thought it maybe was a single command for it or something.. like in mIRC it's just $lines(file.txt)

Statistics: Posted by digitaldj — Thu Feb 06, 2003 10:55 am

Lines in file

2003-02-06T10:52:25-04:00

Well, not all the things are simple as they look like.. The usage of the 'foreach' thing is logical to be used. I don't have any ideea (at this moment) of another way to do the same thing. Combining mine and ppslim's reply you should solve this in a sec.. Heh..

Statistics: Posted by caesar — Thu Feb 06, 2003 10:52 am

Lines in file

2003-02-06T10:41:55-04:00

The foreach command, loops through each line in a list.

In other words, you have to create a list with the contents of a file. One element for each line.

For this, you might as well use the "llength" command, which will count for you.

As noted, you need the list in the first place, as they don't create themselves.

Use somthing like

Code:

set lines [llength [split [read [set fp [open "FILE.NAME" w]]] "\n"]]close $fp

The $lines variable should now contain the number of lines.

Statistics: Posted by ppslim — Thu Feb 06, 2003 10:41 am

Lines in file

2003-02-06T10:39:11-04:00

ok.. i knew that, but i thought it might be something more simple..

Statistics: Posted by digitaldj — Thu Feb 06, 2003 10:39 am

Lines in file

2003-02-06T10:33:55-04:00

Open the file, then use a foreach to increment a number.. Then at the end just extract the value.

Example of a foreach and incrementation of a value:

set value 0
foreach line $file {
incr value
}

Also you may want to see this page for the 'foreach' and this one for the 'open' command..

Statistics: Posted by caesar — Thu Feb 06, 2003 10:33 am

Lines in file

2003-02-06T09:57:35-04:00

how can i find out how many lines there is in a file?

Statistics: Posted by digitaldj — Thu Feb 06, 2003 9:57 am