egghelp/eggheads community Discussion of eggdrop bots, shell accounts and tcl scripts. 2002-10-03T15:02:09-04:00 https://forum.eggheads.org/app.php/feed/topic/2725 2002-10-03T15:02:09-04:00 2002-10-03T15:02:09-04:00 https://forum.eggheads.org/viewtopic.php?p=11671#p11671 <![CDATA[Problems with Brackets & Pipes...]]>

Statistics: Posted by Papillon — Thu Oct 03, 2002 3:02 pm

]]> 2002-10-03T14:48:16-04:00 2002-10-03T14:48:16-04:00 https://forum.eggheads.org/viewtopic.php?p=11668#p11668 <![CDATA[Problems with Brackets & Pipes...]]>

Code: 

if {($arg == "") || (![string is digit [lindex [split $arg] 1]]) || ([llength [split $arg]] == "3")} {
!lamer Papillon 10000 BLA BLA BLEH

:D

Statistics: Posted by egghead — Thu Oct 03, 2002 2:48 pm

]]> 2002-10-03T14:46:41-04:00 2002-10-03T14:46:41-04:00 https://forum.eggheads.org/viewtopic.php?p=11666#p11666 <![CDATA[Problems with Brackets & Pipes...]]>
Okay I fixed the bug with the ban, and the script works fine now, but i still have some questions:

Code: 

if {([llength $arg]==0) || (![string is digit [lindex [split $arg] 1]]) || ([llength [lindex [split $arg] 2]])} {
This line should check if: The user entered a parameter , the user entered a number, the user typed a third (wrong) argument.
A right input would be: !lamer NICK 10, but not !lamer NICK 10 BLA.
I hope you understand my thinking. Now, what should be fxied in this short source to make it work better?
Doing [llength [lindex [split $arg] 2]] just to see if there is a third element, is a bit complicated.

Why not do it like:

Code: 

set arglist [split $arg]set listlen [llength $arglist]switch -- $listlen {   0 { # no nick, no bantime }   1 { # no bantime }   2 { # 2 parameters }   default { # more than 2 parameters }}
Of course you can else make an if-elseif-elseif-else construction without "returns"

One interesting question is: if someone types !lamer nick 10 (i.e. !lamer<space><space>nick<space>10).

Statistics: Posted by egghead — Thu Oct 03, 2002 2:46 pm

]]> 2002-10-03T14:43:04-04:00 2002-10-03T14:43:04-04:00 https://forum.eggheads.org/viewtopic.php?p=11665#p11665 <![CDATA[Problems with Brackets & Pipes...]]>

Statistics: Posted by ProXy — Thu Oct 03, 2002 2:43 pm

]]> 2002-10-03T14:34:09-04:00 2002-10-03T14:34:09-04:00 https://forum.eggheads.org/viewtopic.php?p=11664#p11664 <![CDATA[Problems with Brackets & Pipes...]]>

Code: 

if {($arg == "") || (![string is digit [lindex [split $arg] 1]]) || ([llength [split $arg]] == "3")} {

Statistics: Posted by Papillon — Thu Oct 03, 2002 2:34 pm

]]> 2002-10-03T14:27:54-04:00 2002-10-03T14:27:54-04:00 https://forum.eggheads.org/viewtopic.php?p=11662#p11662 <![CDATA[Problems with Brackets & Pipes...]]>

Code: 

if {([llength $arg]==0) || (![string is digit [lindex [split $arg] 1]]) || ([llength [lindex [split $arg] 2]])} {
This line should check if: The user entered a parameter , the user entered a number, the user typed a third (wrong) argument.
A right input would be: !lamer NICK 10, but not !lamer NICK 10 BLA.
I hope you understand my thinking. Now, what should be fxied in this short source to make it work better?

Statistics: Posted by ProXy — Thu Oct 03, 2002 2:27 pm

]]> 2002-10-03T13:08:15-04:00 2002-10-03T13:08:15-04:00 https://forum.eggheads.org/viewtopic.php?p=11658#p11658 <![CDATA[Problems with Brackets & Pipes...]]>
After testing for non-closed brackets, I was unable to locate any (allthough, my test suite is not the best thing int he world).

As such, there is no need to use any return statements.
Of course you are right and subsequently my comments on the return statements can be ignored. I was guided too much by disliking the construction made :wink:

Statistics: Posted by egghead — Thu Oct 03, 2002 1:08 pm

]]> 2002-10-03T12:47:12-04:00 2002-10-03T12:47:12-04:00 https://forum.eggheads.org/viewtopic.php?p=11656#p11656 <![CDATA[Problems with Brackets & Pipes...]]>
As such, there is no need to use any return statements.

Code: 

if {1==1} {  code1} elseif {2==2} {  code2} else {  code3}
Neither the command code2, nor code3 will execute. This is due to the fact, the code is considered exactly like the following.

Code: 

if {1==1} {  code1} else {  if {2==2} {    code2  } else {    code3  }}
If an IF statment, has allready made a match (thus executing the corisponding body), no more processing of the same IF is done.

In plain elglish, if-elseif-else work like this

Code: 

if {A is equal to B} {  then do this} if-nothing-aboved-matched-try-this {C is equal to D} {  then do this} otherwise-the-only-alternative-is-this {  do this}

Statistics: Posted by ppslim — Thu Oct 03, 2002 12:47 pm

]]> 2002-10-03T12:35:19-04:00 2002-10-03T12:35:19-04:00 https://forum.eggheads.org/viewtopic.php?p=11654#p11654 <![CDATA[Problems with Brackets & Pipes...]]>
I just tested the script again: It is possible to use !lamer eS`rien, the bot bans the host (but the wrong host) and kicks the user. But it is NOT possible to kick or bann the user frz`bot...

The value of onchan frz`bot #HTP is 0, even when the user is in the channel!
The fact that it bans the wrong host etc. is likely due to the fact that you don't have return values included. Review the above comments, and test the script again with putlogs added at critical points.

Statistics: Posted by egghead — Thu Oct 03, 2002 12:35 pm

]]> 2002-10-03T12:36:40-04:00 2002-10-03T12:34:28-04:00 https://forum.eggheads.org/viewtopic.php?p=11653#p11653 <![CDATA[Problems with Brackets & Pipes...]]>
You have some un-needed code.

Code: 

if {[llength [lindex [split $arg] 1]]!=0} {
split turns a string into a list.

lindex returns an item from the list, as a string.

llength measures how many items are in a list.

As such, you are using a string with the "llength" list command. When you should be using [string length].

Second, you have allready checked at the top of the script to see if the second argument is a number. thus, the default ban time, nor this code is of much use.

As for your problem, the only other thing this can be, is network related. What IRC network are you on, and what IRCD software does it use?

Statistics: Posted by ppslim — Thu Oct 03, 2002 12:34 pm

]]> 2002-10-03T12:37:54-04:00 2002-10-03T12:31:27-04:00 https://forum.eggheads.org/viewtopic.php?p=11652#p11652 <![CDATA[Problems with Brackets & Pipes...]]>

Just some general suggestions:

1. The if-the-else-elseif constructions are too complicated. A simple approach:

Code: 

if {conditional statement } {   do something   return 1}if {conditional statement } {   do something   return 1}etc. etc.
2. In most of the if-then statements you must include return statements. The return statements will stop further processing of the procedure.

3. A lot of times statements like "[lindex [split $arg] 0]" are used. For easier reading it is better to reuse variables. Example:
set arglist [split $arg]
set listlen [llength $arglist]
set lamer [lindex $arglist 0]
set bantime [lindex $arglist 1]

reuse these variable in the code.
4. What is the idea of ([llength [lindex [split $arg] 2]])?

5. Instead of sending out a +b, a kick and an unban, it can be easier to simply set a "newchanban" (tcl-commands.doc) and with the correct settings let the bot enforce this ban.

6. Why use a timed kick which send a kick only 2 seconds after the command is issued?

7. running a test with a nick with ``` in it, just worked fine.

Statistics: Posted by egghead — Thu Oct 03, 2002 12:31 pm

]]> 2002-10-03T11:39:46-04:00 2002-10-03T11:39:46-04:00 https://forum.eggheads.org/viewtopic.php?p=11650#p11650 <![CDATA[Problems with Brackets & Pipes...]]>

Code: 

#### Flag for global users ####set lamerglobalflag "*"#### Flag for local users #####set lamerlocalflag "*"####### Public command ########set lamercommand "!lamer"## default ban-time in mins ###set lamerdefaulttime "10"#### END OF CONFIGURATION #####set lamerusage "Usage: $lamercommand <nick> \[time\]"bind pub $lamerglobalflag|$lamerlocalflag $lamercommand pub:lamerproc pub:lamer { nick uhost handle channel arg } {global botnick lamerdefaulttime lamerusageif {([llength $arg]==0) || (![string is digit [lindex [split $arg] 1]]) || ([llength [lindex [split $arg] 2]])} {putserv "PRIVMSG $channel :$lamerusage"} elseif {[onchan [lindex [split $arg] 0] $channel]!=1} {putserv "PRIVMSG $channel :Error: \"[lindex [split $arg] 0]\" ist nicht in diesem Channel! $lamerusage"} elseif {![botisop $channel]} {putserv "PRIVMSG $channel :$nick: Ja, du Scherzkeks, dann gib mir OP!"} elseif {[string tolower [lindex [split $arg] 0]]==[string tolower $botnick]} {putserv "PRIVMSG $channel :$nick: So blöd bin ich nun wirklich nicht..."} else {if {[llength [lindex [split $arg] 1]]!=0} {set lamerbantime [lindex [split $arg] 1]} else {set lamerbantime $lamerdefaulttime}set lamerhost [getchanhost [lindex [split $arg] 0] $channel]putserv "MODE $channel +b [lindex [split $arg] 0]!$lamerhost"if {$lamerbantime==1} {set lamermins "minute"} else {set lamermins "minutes"}utimer 2 [list putkick $channel [lindex [split $arg] 0] "banned for $lamerbantime $lamermins"] timer $lamerbantime [list putserv "MODE $channel -b [lindex [split $arg] 0]!$lamerhost"]}}
Perhaps you could also check why he sometimes bans a wrong host :)

I just tested the script again: It is possible to use !lamer eS`rien, the bot bans the host (but the wrong host) and kicks the user. But it is NOT possible to kick or bann the user frz`bot...

The value of onchan frz`bot #HTP is 0, even when the user is in the channel!

Statistics: Posted by ProXy — Thu Oct 03, 2002 11:39 am

]]> 2002-10-03T11:34:23-04:00 2002-10-03T11:34:23-04:00 https://forum.eggheads.org/viewtopic.php?p=11649#p11649 <![CDATA[Problems with Brackets & Pipes...]]>
Oh but it is still not possible to Kick User that have ` in their nick. Any ideas?
Lot of ideas :) But need to see the full script.

Statistics: Posted by egghead — Thu Oct 03, 2002 11:34 am

]]> 2002-10-03T11:35:57-04:00 2002-10-03T11:31:19-04:00 https://forum.eggheads.org/viewtopic.php?p=11648#p11648 <![CDATA[Problems with Brackets & Pipes...]]>
I also found another bug. In some cases the eggdrop cannot ban the user because he bans the wrong hostmask!

Code: 

set lamerhost [getchanhost [lindex [split $arg] 0] $channel]putserv "MODE $channel +b [lindex [split $arg] 0]!$lamerhost"
Isn`t this source right?

Statistics: Posted by ProXy — Thu Oct 03, 2002 11:31 am

]]> 2002-10-03T07:20:51-04:00 2002-10-03T07:20:51-04:00 https://forum.eggheads.org/viewtopic.php?p=11642#p11642 <![CDATA[Problems with Brackets & Pipes...]]>

Statistics: Posted by ProXy — Thu Oct 03, 2002 7:20 am

]]>