egghelp/eggheads community

Ircop eggdrop bot with SACommands

2023-09-19T17:57:02-04:00

Makes sense thanks Crazy Cat and caesar

Statistics: Posted by simo — Tue Sep 19, 2023 5:57 pm

Ircop eggdrop bot with SACommands

2023-09-19T18:38:38-04:00

I think you make that too complex:

Code:

if {![string equal -nocase $chan "$::chanopschan"] || [string first "#" $enforcechan] == -1 || ![botisop $enforcechan] || [isop $nick $enforcechan]}

Why don't simply test:

Code:

if {![validchan $enforcechan] || ![string tolower $enforcechan] eq $::chanopschan || ![botisop $enforcechan]}

You don't really care if user is already op, and validchan is a better way to check if chan exists and bot knows it.

Statistics: Posted by CrazyCat — Mon Sep 18, 2023 6:05 pm

Ircop eggdrop bot with SACommands

2023-09-18T13:56:21-04:00

You might want to check your last if statements cos something doesn't feel right in there.

Statistics: Posted by caesar — Mon Sep 18, 2023 1:56 pm

Ircop eggdrop bot with SACommands

2023-09-18T12:30:41-04:00

thanks caesar

Code:

bind pub -|- !op Pub:OP:monotor-channelproc Pub:OP:monotor-channel {nick host hand chan text} {  set text [regsub -all -- {\s{2,}} [string trim [stripcodes * $text]] { }]  set items [split $text]  if {[llength $items] < 1 } { putnow "notice $nick :Syntax is !op \#chan" ; return }  set enforcechan [lindex [split $text] 0]  if {![string equal -nocase $chan "$::chanopschan"] || [string first "#" $enforcechan] == -1 || ![botisop $enforcechan] || [isop $nick $enforcechan]} { return 0 }  if {[isop $nick $::chanopschan] || [ishalfop $nick $::chanopschan] || [matchattr $hand o|o $::chanopschan]} {  pushmode $enforcechan +o $nick }}

Statistics: Posted by simo — Mon Sep 18, 2023 12:30 pm

Ircop eggdrop bot with SACommands

2023-09-18T11:45:33-04:00

I think it's safe to remove the [onchan $nick $enforcechan] && [onchan $::botnick $enforcechan] part as the previous two checks validate them as well, meaning botisop can't return true unless bot is on the channel and the isop can't return true if nick isn't on the channel.

You set the chan to be lower case via:

Code:

set chan [string tolower $chan]

and then in:

Code:

if {![string equal -nocase $chan "$::chanopschan"] || [string first "#" $enforcechan] == -1} { return 0 }

use the -nocase that ignores the case, so the above is pointless.

I would consider moving the [botisop $enforcechan] higher in the code and return if it's false, else continue with the rest of the code.

Statistics: Posted by caesar — Mon Sep 18, 2023 11:45 am

Ircop eggdrop bot with SACommands

2023-09-17T22:50:06-04:00

ok i changed :

Code:

set chanopschan "#chanops"bind pub -|- !op Pub:OP:monotor-channel

to :

Code:

set chanopschan "#chanops"bind pub o|- !op Pub:OP:monotor-channel

also changed :

Code:

if {[botisop $enforcechan] && ![isop $nick $enforcechan] && [onchan $nick $enforcechan] && [onchan $::botnick $enforcechan]} { pushmode $enforcechan +o $nick }   }  }}

to :

Code:

if {[botisop $enforcechan] && ![isop $nick $enforcechan] && [onchan $nick $enforcechan] && [onchan $::botnick $enforcechan]} { pushmode $enforcechan +o $nick }   }  }

now working fine

Statistics: Posted by Yusif — Sun Sep 17, 2023 10:50 pm

Ircop eggdrop bot with SACommands

2023-09-17T19:01:00-04:00

i tried that , but when do !op #chan-name there is no action = not op chanop

Statistics: Posted by Yusif — Sun Sep 17, 2023 7:01 pm

Ircop eggdrop bot with SACommands

2023-09-17T18:05:27-04:00

thank you so much

Statistics: Posted by Yusif — Sun Sep 17, 2023 6:05 pm

Ircop eggdrop bot with SACommands

2023-09-17T10:55:12-04:00

Why not use chanserv for that?
we use chanserv but opers not around all time to op chanops

you could try this :

Code:

 set chanopschan "#chanops"bind pub -|- !op Pub:OP:monotor-channelproc Pub:OP:monotor-channel {nick host hand chan text} {   set text [regsub -all -- {\s{2,}} [string trim [stripcodes * $text]] { }]   set items [split $text]   set chan [string tolower $chan]   if {[llength $items] < 1 } { putnow "notice $nick :Syntax is !op \#chan" ; return }   set enforcechan [lindex [split $text] 0]   if {![string equal -nocase $chan "$::chanopschan"] || [string first "#" $enforcechan] == -1} { return 0 }   if {[isop $nick $::chanopschan] || [ishalfop $nick $::chanopschan] || [matchattr $hand o|o $::chanopschan]} {     if {[botisop $enforcechan] && ![isop $nick $enforcechan] && [onchan $nick $enforcechan] && [onchan $::botnick $enforcechan]} { pushmode $enforcechan +o $nick }   }  }}   bind pub -|- !deop Pub:DEOP:monotor-channelproc Pub:DEOP:monotor-channel {nick host hand chan text} {   set text [regsub -all -- {\s{2,}} [string trim [stripcodes * $text]] { }]   set items [split $text]   set chan [string tolower $chan]      if {[llength $items] < 1 } { putnow "notice $nick :Syntax is !op \#chan" ; return }   set enforcechan [lindex [split $text] 0]   if {![string equal -nocase $chan "$::chanopschan"] || [string first "#" $enforcechan] == -1} { return 0 }   if {[isop $nick $::chanopschan] || [ishalfop $nick $::chanopschan] || [matchattr $hand o|o $::chanopschan]} {     if {[botisop $enforcechan] && [isop $nick $enforcechan] && [onchan $nick $enforcechan] && [onchan $::botnick $enforcechan]} { pushmode $enforcechan -o $nick }   }  }}   bind pub -|- !hop Pub:HOP:monotor-channelproc Pub:HOP:monotor-channel {nick host hand chan text} {   set text [regsub -all -- {\s{2,}} [string trim [stripcodes * $text]] { }]   set items [split $text]   set chan [string tolower $chan]      if {[llength $items] < 1 } { putnow "notice $nick :Syntax is !op \#chan" ; return }   set enforcechan [lindex [split $text] 0]   if {![string equal -nocase $chan "$::chanopschan"] || [string first "#" $enforcechan] == -1} { return 0 }   if {[isop $nick $::chanopschan] || [ishalfop $nick $::chanopschan] || [matchattr $hand o|o $::chanopschan]} {     if {[botisop $enforcechan] && ![ishalfop $nick $enforcechan] && [onchan $nick $enforcechan] && [onchan $::botnick $enforcechan]} { pushmode $enforcechan +h $nick }   }  }}   bind pub -|- !dehop Pub:DEHOP:monotor-channelproc Pub:DEHOP:monotor-channel {nick host hand chan text} {   set text [regsub -all -- {\s{2,}} [string trim [stripcodes * $text]] { }]   set items [split $text]   set chan [string tolower $chan]      if {[llength $items] < 1 } { putnow "notice $nick :Syntax is !op \#chan" ; return }   set enforcechan [lindex [split $text] 0]   if {![string equal -nocase $chan "$::chanopschan"] || [string first "#" $enforcechan] == -1} { return 0 }   if {[isop $nick $::chanopschan] || [ishalfop $nick $::chanopschan] || [matchattr $hand o|o $::chanopschan]} {     if {[botisop $enforcechan] && [ishalfop $nick $enforcechan] && [onchan $nick $enforcechan] && [onchan $::botnick $enforcechan]} { pushmode $enforcechan -h $nick }   }  }}

Statistics: Posted by simo — Sun Sep 17, 2023 10:55 am

Ircop eggdrop bot with SACommands

2023-09-16T06:12:13-04:00

The design of chanserv auto - admins/ops/hops list is to work without the need of any oper being around.

Statistics: Posted by simo — Sat Sep 16, 2023 6:12 am

Ircop eggdrop bot with SACommands

2023-09-15T21:10:47-04:00

Why not use chanserv for that?

we use chanserv but opers not around all time to op chanops

Statistics: Posted by Yusif — Fri Sep 15, 2023 9:10 pm

Ircop eggdrop bot with SACommands

2023-09-15T20:01:25-04:00

can you please do modify in this script for simple use?
need it work in #Chanops .. when the chanop need to op in any room by bot, he/she have to type:
!op #chan to get op in that room + confirm msg in #chanops he/she opped
!deop #chan to drop op + confirm msg in #chanops he/she deopped
!hop #chan to get halfop + confirm msg in #chanops he/she halfop
!dehop #chan to dehalfop + confirm msg in #chanops he/she dehop

thanks

Why not use chanserv for that?

Statistics: Posted by simo — Fri Sep 15, 2023 8:01 pm

Ircop eggdrop bot with SACommands

2023-09-14T19:39:47-04:00

can you please do modify in this script for simple use?
need it work in #Chanops .. when the chanop need to op in any room by bot, he/she have to type:
!op #chan to get op in that room + confirm msg in #chanops he/she opped
!deop #chan to drop op + confirm msg in #chanops he/she deopped
!hop #chan to get halfop + confirm msg in #chanops he/she halfop
!dehop #chan to dehalfop + confirm msg in #chanops he/she dehop

thanks

Statistics: Posted by Yusif — Thu Sep 14, 2023 7:39 pm

Ircop eggdrop bot with SACommands

2022-09-05T10:48:14-04:00

That looks nice CrazyCat:)

Statistics: Posted by SpiKe^^ — Mon Sep 05, 2022 10:48 am

Ircop eggdrop bot with SACommands

2022-09-05T10:20:39-04:00

Could do a shorter version using a routing proc:

Code:

# set one admin channel here for an added security check.# both the bot and the command user will need to be in this channel.# maybe set this channel password protected or invite only...# ex. set samop(adminchan) "#admins"# or set empty to not require command users to be in an admin channel.# ex: set samop(adminchan) ""set samop(adminchan) "#admins"# set one report channel here for the bot to report mode changes to.# ex. set samop(reportchan) "#admins"# or set empty to not report modes.  ex: set samop(reportchan) ""set samop(reportchan) "#admins"############################################## OWNER ##############################################bind msg n owner msg:qopbind msg n protect msg:sopbind msg n op msg:opbind msg n halfop msg:hopbind msg n voice msg:vopbind msg n deowner msg:deqopbind msg n deprotect msg:desopbind msg n deop msg:deopbind msg n dehalfop msg:dehopbind msg n devoice msg:devopproc msg:qop {nick uhost handle text}  { samode $nick + q OWNER $text }proc msg:sop {nick uhost handle text}  { samode $nick + p PROTECT $text }proc msg:op {nick uhost handle text}  { samode $nick + o OP $text }proc msg:hop {nick uhost handle text}  { samode $nick + h HALFOP $text }proc msg:vop {nick uhost handle text}  { samode $nick + v VOICE $text }proc msg:deqop {nick uhost handle text}  { samode $nick - q DEOWNER $text }proc msg:desop {nick uhost handle text}  { samode $nick - p DEPROTECT $text }proc msg:deop {nick uhost handle text}  { samode $nick - o DEOP $text }proc msg:dehop {nick uhost handle text}  { samode $nick - h DEHALFOP $text }proc msg:devop {nick uhost handle text}  { samode $nick - v DEVOICE $text }proc samode {nick to mode label text} {   set targets [lassign [split [string trim $txt]] chan]   if {![string match "#?*" $chan]} {      putserv "NOTICE $nick :Command syntax: \002$label #somechannel \[nick(s)\]\002"      return 0   }   if {[string match "#?*" $::samop(adminchan)]} {      if {![botonchan $::samop(adminchan)] || ![onchan $nick $::samop(adminchan)]} {         putserv "NOTICE $nick :Both you & the bot must be on $::samop(adminchan)"         return 0      }   }   if {![llength $targets]} {  lappend targets $nick  }   set mode [string repeat $mode [llength $targets]]   putserv "samode $chan $to$mode [join $targets]"   if {[string match "#?*" $::samop(reportchan)]} {      putserv "PRIVMSG $::samop(reportchan) :$nick used $label to make [join $targets] $label in $chan"   }   return 0}############################################## HELP ###############################################bind msg n help msg:helpproc msg:help {nick uhost hand txt} {  if {[llength $txt]<13} {putserv "NOTICE $nick :=============== HELP ================"putserv "NOTICE $nick :/msg AdminServ OWNER #channel nick"putserv "NOTICE $nick :/msg AdminServ DEOWNER #channel nick"putserv "NOTICE $nick :/msg AdminServ PROTECT #channel nick"putserv "NOTICE $nick :/msg AdminServ DEPROTECT #channel nick"putserv "NOTICE $nick :/msg AdminServ OP #channel nick"putserv "NOTICE $nick :/msg AdminServ DEOP #channel nick"putserv "NOTICE $nick :/msg AdminServ HALFOP #channel nick"putserv "NOTICE $nick :/msg AdminServ DEHALFOP #channel nick"putserv "NOTICE $nick :/msg AdminServ VOICE #channel nick"putserv "NOTICE $nick :/msg AdminServ DEVOICE #channel nick"putserv "NOTICE $nick :/msg AdminServ HELP"putserv "NOTICE $nick :================ END ================"  }}putlog "samop.tcl version 0.1 loaded."

Could also be optimised with a variable containing modes and labels which can allow to generate help depending on its content

Statistics: Posted by CrazyCat — Mon Sep 05, 2022 10:20 am