egghelp/eggheads community

strip duplicate characters in nick and match against badnick

2020-11-14T10:07:19-04:00

Short remarks (or personnal preference)

As a general rule of thumb generally it's a good idea to:
1. have variables inside an array, so you won't end up with stuff like this:
Code:
global bnick bchan kickreason temp
instead of having a cleaner:
Code:
global something
where something for example holds the following variables:
Code:
set something(one) "1"set something(two) "2"# and so on.. you get the idea

I agree with caesar because of a pratical reason: if you use several scripts, you'll probably have variables with the same name but with a different usage.
Having myscript(nicklist) and myscipt(delay) is better than having nicklist and delay which could be use somewhere else.

Personnaly, I prefer use variables but call them using their namespace rather than use global. And having namespace for scripts, so when I use a variable, I know exactly where it comes from. $::username is not $::myscript::username.

A long time before, I was used to have global in my scripts, because I didn't know namespaces. But now, I think it's quite evil to use global

Statistics: Posted by CrazyCat — Sat Nov 14, 2020 10:07 am

strip duplicate characters in nick and match against badnick

2020-11-14T09:50:09-04:00

thanks caesar i cant figure it out for the moment but i will have a go at it perhaps another time for the moment ill use old code i do apreciate the efforts tho will use that when i have some more clear mind to look at this

cheers.

Statistics: Posted by simo — Sat Nov 14, 2020 9:50 am

strip duplicate characters in nick and match against badnick

2020-11-14T09:47:05-04:00

this is confusing thats why i dont use it

set something(one) "1"
set something(two) "2"
# and so on.. you get the idea

Statistics: Posted by simo — Sat Nov 14, 2020 9:47 am

strip duplicate characters in nick and match against badnick

2020-11-13T10:33:02-04:00

As a general rule of thumb generally it's a good idea to:
1. have variables inside an array, so you won't end up with stuff like this:

Code:

global bnick bchan kickreason temp

instead of having a cleaner:

Code:

global something

where something for example holds the following variables:

Code:

set something(one) "1"set something(two) "2"# and so on.. you get the idea

2. use of the namespace, that's basically a collection of commands and variables and if given a unique name chances to end up at some point with two functions or variables having the same name are ZERO. will save you of a lot of hassle trying to figure out why your code isnt working properly

Next we got this:

Code:

if {[lsearch -nocase $bchan $chan] || ![llength $bchan]} { # execute stuff}

this is, for me at least, a bad approach on programming as it makes it harder for you to track if all the { have an}, if you got all the stuff you wanted to be executed in the right place and whatnot. At the top of the code before everything else is executed should have the sattements that validate the access to the next lines so it not only easier to follow but also to debug. The TCL interpreter doesn't care how you make the code as long as it's valid. Now let's intepret the statement and see what it dose:

Code:

IF we can find a case in-sensitive match of the channel name in that list OR the list has at least one element THEN { execute this code }

and let's see what happens:

Code:

% set chan "foo"foo% set channels "something else in here"something else in here% lsearch -nocase $channels $chan-1% llength $channels4% if {[lsearch -nocase $channels $chan] || ![llength $channels]} { puts "I'm in" }I'm in

As you can notice the channel isn't in the list, list has 4 elements and the code is executed nevertheless. The logic of the line is a bit flawed. At this point would like to point out that would be a lot easier to use the built-in mechanics we got and not hard-code variables that at some point we would like to change, so instead of this create a special flag like setudef flag myFlag and combined with channel get $chan myFlag for example you know if given channel should be allowed to execute the code.

Code:

foreach i [string tolower $bnick] {

I mentioned the string tolower in one of my previous posts, so no point in talking about it again, just remove it as your 'string match ' is done in a case in-sensitive manner so it's useless.

Code:

if {!$temp} { return } {         putquick "MODE $chan  +b  *$badpart*!*@*"         putquick "KICK $chan $nick :$kickreason" }

This is a gem, cos you are basically scratching your left ear with your right hand OVER your head:

Code:

if $temp equals 0 we return ELSE execute this code

Why bother with an IF-THEN-ELSE (it's IF statement THEN return ELSE { execute this code } basically) when you can just IF statement THEN { execute this code } directly. I see some of the stuff I previously mentioned didn't make the cut as well, so in the spirit of what CrazyCat suggested, don't expect me to spoon feed you the answers on this one. I mean, I could do just that but wouldn't help you in the long run.

As always, don't find my answers as patronizing you or anything like that. If you look at the history of my early posting you will see I got a lot of stupid questions and mistakes, but people like ppslim, user, stdragon, egghead to name a few had the patience and pushed me in the right direction without spoon feeding me every time. Just take this as a loving push in the right direction as well.

Statistics: Posted by caesar — Fri Nov 13, 2020 10:33 am

strip duplicate characters in nick and match against badnick

2020-11-13T07:34:25-04:00

this is what i came up with if its proper

Code:

 #--------------------------------------------------------------------------------------------------------------------##                                               BAD NICK SCRIPT BY RANA USMAN                                        ##--------------------------------------------------------------------------------------------------------------------##Author : RANA USMAN#Email : coolguy_rusman@yahoo.com#URL : www.ranausman.tk#Version : 1.2#Catch me on UNDERNET @ #VASTEYE my nick is ^Rana^Usman#################### Version History #####################The version before was not supporting Wildcards like ** ?? etc etc#So now in this version you can use wild cards too############################- CONFIGURATION SECTION -#####################################################################################################################- Enter the Bad nicks Below on which you want your bot to BAN  (Wild Cards Supported)-#########################################################################################set bnick {    "somenick"    "badnick"}###########################################################################################################                SET The channel on which you want this script to work                                #### Channels Separted by space...and if you want this script to work on all channels leave it as ""     ###########################################################################################################set bchan ""#################- Set Reason -#################set kickreason "4Bad Nick Detected"#--------------------------------------------------------------------------------------------------------------------##   SCRIPT STARTS FROM HERE...MAKE IT BETTER WITH YOUR SKILLS IF YOU CAN.I DONT RESTRICT YOU TO NOT TO TOUCH CODE!   ##--------------------------------------------------------------------------------------------------------------------#bind join - * join:RanaUsmanbind nick - * nick:tvrshproc nick:tvrsh {nick uhost hand chan newnick} {    join:RanaUsman $newnick $uhost $hand $chan}proc join:RanaUsman {nick uhost hand chan} {global bnick bchan kickreason temp regsub -all -- {(.)\1+} $nick {\1} nick2if {[lsearch -nocase $bchan $chan] || ![llength $bchan]} {  set temp 0   foreach i [string tolower $bnick] {    regexp -options { i } text -> match   if {[string match -nocase *$match* $nick2]  && ![string match -nocase *guest* $nick2]} {        set badpart $match   set temp 1    }    }}   if {!$temp} { return } {         putquick "MODE $chan  +b  *$badpart*!*@*"         putquick "KICK $chan $nick :$kickreason" }}putlog "=-\002 LOADED BAD NICK BY RANA USMAN (www.ranausman.tk)\002 -="#Author : RANA USMAN

Statistics: Posted by simo — Fri Nov 13, 2020 7:34 am

strip duplicate characters in nick and match against badnick

2020-11-13T01:55:49-04:00

You mean have the regexp pattern in a separate variable?

Code:

regexp -options { pattern } text -> match

Just remove the pattern you got right now and put a variable instead. Shouldn't be hard to figure out.

Statistics: Posted by caesar — Fri Nov 13, 2020 1:55 am

strip duplicate characters in nick and match against badnick

2020-11-12T14:05:30-04:00

thanks caesar could a combination of the two be used ? like to have the words in a variable to go throu the regexp to have freedom to add words in a more managable way

Statistics: Posted by simo — Thu Nov 12, 2020 2:05 pm

strip duplicate characters in nick and match against badnick

2020-11-12T13:21:32-04:00

If you intend to drop the foreach loop and rely on the regexp line all you have to do is ... literally remove the foreach loop.

Oh, before i forget, rename bad to badpart in the regexp line so you won't need have to change it in the match & punish part of the code.

Edit: If you still use that regsub CrazyCat helped you out wih might be a good idea to adjust the variable in the regexp line so it matches properly.

Statistics: Posted by caesar — Thu Nov 12, 2020 1:21 pm

strip duplicate characters in nick and match against badnick

2020-11-12T10:01:01-04:00

its not about not trying since i always try but when u have no clue where to add things or how to integrate something rather than to have random guess and try things that arent proper i asked for how it would look like so i can use as an example for other codes to give me an idea how it would look like in code

thanks.

Statistics: Posted by simo — Thu Nov 12, 2020 10:01 am

strip duplicate characters in nick and match against badnick

2020-11-12T09:09:25-04:00

how would it look like in the code caesar?

Did you try to implement the part of code ?

I won't speak for caesar or others, but when I help, my intention is to teach something to the asker, not to just do it for him.
You ask a lot of things but seem to not try to understand what is done or how it works.

Statistics: Posted by CrazyCat — Thu Nov 12, 2020 9:09 am

strip duplicate characters in nick and match against badnick

2020-11-12T07:59:18-04:00

how would it look like in the code caesar?

Statistics: Posted by simo — Thu Nov 12, 2020 7:59 am

strip duplicate characters in nick and match against badnick

2020-11-12T02:31:01-04:00

I looked at your example and I don't understand how your match is working. From my limited understanding of regexp it should match se with something in the () but there's no se in the nick to begin with. I opened up a mIRC client and tested:

//echo match for ds3kss: $regex("ds3kss",/(se(x|ks)|(s|f)uck|p(orn|enis)|h[0o]rny)/i)
match for ds3kss: 0

In TCL this would be something like:

Code:

set match [regexp -all {(se(x|ks)|(s|f)uck|p(orn|0rn|enis)|h[0o]rny)} $nick -> bad]

and if $match is 1 then in the $bad variable you got what it matched against.

Statistics: Posted by caesar — Thu Nov 12, 2020 2:31 am

strip duplicate characters in nick and match against badnick

2020-11-11T11:56:50-04:00

tnx caesar i saw an msl code (mirc) using regex and it sets ban on the actual bad part it matches against i was hoping this could be done with tcl as well

if ($regex($nick,/(se(x|ks)|(s|f)uck|p(orn|enis)|h[0o]rny)/i)) { mode $chan +b $+ * $regml(1) $+ *!*@* }

as regex matches a range of word paterns making it easier to manage words instead of using a huge list of word paterns

17:14:20 Join : ds3kss Mibbit@RifSytes-h21.635.668.037.IP
17:14:20 +[simo] Sets Mode on #opers to: +b *s3ks*!*@*
17:16:01 Join : dseksq Mibbit@RifSytes-h21.635.668.037.IP
17:16:01 +[simo] Sets Mode on #opers to: +b *seks*!*@*

Statistics: Posted by simo — Wed Nov 11, 2020 11:56 am

strip duplicate characters in nick and match against badnick

2020-11-11T11:48:59-04:00

That was expected since the badpart is what the nick was matched against. Change it and ban nick instead?

Statistics: Posted by caesar — Wed Nov 11, 2020 11:48 am

strip duplicate characters in nick and match against badnick

2020-11-11T08:14:21-04:00

it sets a weird ban tho:

@TCL-Tester Sets Mode on #opers to: +b *b[3e]dw[o0]rd*!*@*

while nick is badword or bedw0rd and so on making the ban invalid

Statistics: Posted by simo — Wed Nov 11, 2020 8:14 am