egghelp/eggheads community

setting ban on msg followed by quit

2020-09-26T15:29:30-04:00

could this be modified to have it check for host instead of nick so we dont have to worry about changed nicks or adding another proc for nick ?

Statistics: Posted by simo — Sat Sep 26, 2020 3:29 pm

setting ban on msg followed by quit

2020-09-27T16:31:35-04:00

We allow 1 nick per IP on this network caesar

Statistics: Posted by simo — Sat Sep 26, 2020 12:04 pm

setting ban on msg followed by quit

2020-09-26T05:46:50-04:00

What if there are two distinct people with same host?

Statistics: Posted by caesar — Sat Sep 26, 2020 5:46 am

setting ban on msg followed by quit

2020-09-26T03:53:58-04:00

I think having to avoiding checking wether nick has changed perhaps its better to use *! *@host:channel to store and use that way it wont matter if they change nick

Statistics: Posted by simo — Sat Sep 26, 2020 3:53 am

setting ban on msg followed by quit

2020-09-25T02:58:22-04:00

@CrazyCat Ah, I see, in that case just replace it instead of removing and adding it again:

Code:

proc add:spam {nick chan} {global spamlistset match 0set now [clock seconds]if {[info exists spamlist($chan)]} {putserv "PRIVMSG $chan :spamlist exists for $chan"set pos [lsearch -nocase [dict keys [join $spamlist($chan)]] $nick]if {$pos > -1} {scan [lindex $spamlist($chan) $pos] {%s%s} user timeputserv "PRIVMSG $chan :$nick was found in the list, updating the seconds from $time to $now .."set spamlist($chan) [lreplace $spamlist($chan) $pos $pos [list $user $now]]incr match}}if {!$match} {putserv "PRIVMSG $chan :$nick wasn't in, adding.."lappend spamlist($chan) [list $nick $now]}}

You can use the same lreplace line on the nick change function where you will have $newnick (or what variable you want to use) instead of $user

Statistics: Posted by caesar — Fri Sep 25, 2020 2:58 am

setting ban on msg followed by quit

2020-09-24T14:23:39-04:00

seems to work proper now thanx CrazyCat and caesar much apreciated

Statistics: Posted by simo — Thu Sep 24, 2020 2:23 pm

setting ban on msg followed by quit

2020-09-24T13:44:58-04:00

looks like add:spam is never called.

Modify the two first proc:

Code:

proc pub:spam {nick uhost hand chan txt} {   putserv "PRIVMSG $chan :get pub from $nick"   add:spam $nick [string tolower $chan]   putserv "PRIVMSG $chan :stored pub from $nick"}proc ctcp:spam {nick uhost hand chan key txt} {   putserv "PRIVMSG $chan :get act from $nick"   add:spam $nick [string tolower $chan]   putserv "PRIVMSG $chan :stored act from $nick"}

I think you have now enough debug examples to make yours own tests & debug.

Statistics: Posted by CrazyCat — Thu Sep 24, 2020 1:44 pm

setting ban on msg followed by quit

2020-09-24T11:27:51-04:00

thank you tried your last post got the same result:

17:29:54 (Greene) : testing one two three
17:29:54 Quits : Greene uid45646@uid-45646.highgate.irccloud.com (Quits: Left IRC)
17:29:54 (@TCL-Tester) : Can't find spamlist for #opers

17:30:27 (Burk) : testing one two three
17:30:27 Parts : Burk Jordon@BHYX1EUA.WGERDG6U.HVE14TFS.IP (Parts:)
17:30:27 (@TCL-Tester) : Can't find spamlist for #opers

Statistics: Posted by simo — Thu Sep 24, 2020 11:27 am

setting ban on msg followed by quit

2020-09-24T10:16:29-04:00

I complicated the procedure to force the update of the last speaking action time for $nick on $chan and not skipping it.

Little example :

Code:

[16:00:00] --> spammer as joined #test[16:00:01] * spammer says hello to all[16:00:05]  go on http://omg.spamming.net[16:00:07] <-- spammer has quit (http://omg.spamming.net)

If you skip already existing user in spamlist, you'll have the 16:00:01 record, it won't ban when spammer quits at 16:00:07.

Your simplified version works only for spammers which don't speak until they "speak & quit". Mine will ban anyone which exit less than 6 seconds after he had spoke (this is how I understand the mirc script).

BTW, I think this script is a bad idea, polite pple as me will be banned:

Code:

[16:59:57]  Time to go, cya pple ![16:59:59] <-- CrazyCat has quit (Cya)

Statistics: Posted by CrazyCat — Thu Sep 24, 2020 10:16 am

setting ban on msg followed by quit

2020-09-24T09:55:36-04:00

Good catch on that string tolower $chan as this could have caused some issues.

Like I previously mentioned, should consider adding a nick change function and something for a bit of house keeping just in case something doesn't work as should and you end up with a big array stored in memory with a bunch of gunk.

One thing I don't understand why did you complicated the add:spam, meaning if the pos is above -1 (meaning it exists in the list) then unless you need to update the data there's no need to remove and then add it at the end. Here's something simplified:

Code:

proc add:spam {nick chan} {set match 0if {[info exists ::spamlist($chan)]} {putserv "PRIVMSG $chan :spamlist exists for $chan"set pos [lsearch -nocase [dict keys [join $::spamlist($chan)]] $nick]if {$pos > -1} {putserv "PRIVMSG $chan :$nick was found in the list, skipping.."incr match}}if {!$match} {putserv "PRIVMSG $chan :$nick wasn't in, adding.."lappend ::spamlist($chan) [list $nick [clock seconds]]}}

So, swe first check if the spamlist array has records for #channel, then check if nick is found in them. If found we increment match, else will remain at default 0 value. At the end if match is 0 (meaning we don't have any records for nick) we add him in the list.

Statistics: Posted by caesar — Thu Sep 24, 2020 9:55 am

setting ban on msg followed by quit

2020-09-24T05:27:12-04:00

You can try with the following code:

Code:

bind PUB - * pub:spambind CTCP - ACTION ctcp:spambind PART - * part:spambind SIGN - * sign:spamarray set spamlist {}proc pub:spam {nick uhost hand chan txt} {   add:spam $nick [string tolower $chan]}proc ctcp:spam {nick uhost hand chan key txt} {   add:spam $nick [string tolower $chan]}proc add:spam {nick chan} {if {[info exists ::spamlist($chan)]} {putserv "PRIVMSG $chan :spamlist exists for $chan"set pos [lsearch -nocase [dict keys [join $::spamlist($chan)]] $nick]if {$pos >= 0} {putserv "PRIVMSG $chan :$nick was in, removing"set ::spamlist($chan) [lreplace $::spamlist($chan) $pos $pos]}}lappend ::spamlist($chan) [list $nick [clock seconds]]putserv "PRIVMSG $chan :adding/updating $nick in $chan"}proc part:spam {nick uhost hand chan {txt ""}} {   ban:spam $nick $uhost [string tolower $chan]}proc sign:spam {nick uhost hand chan txt} {   ban:spam $nick $uhost [string tolower $chan]}proc ban:spam {nick uhost chan} {   if {![info exists ::spamlist($chan)]} {      putserv "PRIVMSG $chan :Can't find spamlist for $chan"      return   }   set pos [lsearch -nocase [dict keys [join $::spamlist($chan)]] $nick]   if {$pos > -1} {      scan [lindex $::spamlist($chan) $pos] {%s%s} user time      set now [clock seconds]      if {[expr $now - $time] < 6} {         set ::spamlist($chan) [lreplace $::spamlist($chan) $pos $pos]         set mask [maskhost "$nick!$uhost" 3]         pushmode $chan +b $mask      } else {         putserv "PRIVMSG $chan :More than 5s, doing nothing"     }   } else {      putserv "PRIVMSG $chan :Can't find $nick in spamlist of $chan"   }}

I added a add:spam proc which is used to avoid multiple entries for a same nick in the spamlist

Statistics: Posted by CrazyCat — Thu Sep 24, 2020 5:27 am

setting ban on msg followed by quit

2020-09-24T01:06:52-04:00

tnx crazycat gettin this output:

(@TCL-Tester) : Can't find spamlist for #opers

Statistics: Posted by simo — Thu Sep 24, 2020 1:06 am

setting ban on msg followed by quit

2020-09-23T17:55:05-04:00

No, you don't see any reaction because you didn't output any debug information.

Code:

proc ban:spam {nick uhost chan} {   if {![info exists ::spamlist($chan)]} {      putserv "PRIVMSG $chan :Can't find spamlist for $chan"      return   }   set pos [lsearch -nocase [dict keys [join $::spamlist($chan)]] $nick]   if {$pos > -1} {      scan [lindex $::spamlist($chan) $pos] {%s%s} user time      set now [clock seconds]      if {[expr $now - $time] < 6} {         set ::spamlist($chan) [lreplace $::spamlist($chan) $pos $pos]         set mask [maskhost "$nick!$uhost" 3]         pushmode $chan +b $mask      } else {         putserv "PRIVMSG $chan :More than 5s, doing nothing"     }   } else {      putserv "PRIVMSG $chan :Can't find $nick in spamlist of $chan"   }}

All the putserv I added are just for debug, they didn't change the way the proc is working.
You can now make tests and copy us the results you get in your chan.

Statistics: Posted by CrazyCat — Wed Sep 23, 2020 5:55 pm

setting ban on msg followed by quit

2020-09-23T14:32:18-04:00

this is what i have so far tested it but it doesnt react:

Code:

bind PUB - * pub:spambind CTCP - ACTION ctcp:spambind PART - * part:spambind SIGN - * sign:spamarray set spamlist {} proc pub:spam {nick uhost hand chan txt} {   global spamlist   lappend spamlist($chan) [list $nick [clock seconds]]}proc ctcp:spam {nick uhost hand chan key txt} {   global spamlist   lappend spamlist($chan) [list $nick [clock seconds]]}proc part:spam {nick uhost hand chan {txt ""}} {   ban:spam $nick $uhost $chan}proc sign:spam {nick uhost hand chan txt} {   ban:spam $nick $uhost $chan}proc ban:spam {nick uhost chan} {   if {![info exists ::spamlist($chan)]} return   set pos [lsearch -nocase [dict keys [join $::spamlist($chan)]] $nick]   if {$pos > -1} {      scan [lindex $::spamlist($chan) $pos] {%s%s} user time      set now [clock seconds]      if {[expr $now - $time] < 6} {         set ::spamlist($chan) [lreplace $::spamlist($chan) $pos $pos]         set mask [maskhost "$nick!$uhost" 3]            pushmode $chan +b $mask      }   }}

Statistics: Posted by simo — Wed Sep 23, 2020 2:32 pm

setting ban on msg followed by quit

2020-09-23T12:23:43-04:00

what binds do i need to use with that crazycat im a bit confused

Statistics: Posted by simo — Wed Sep 23, 2020 12:23 pm