egghelp/eggheads community

"Visit" URL with command .pizza

2020-08-13T12:11:17-04:00

Thank you! It works

Statistics: Posted by Pauschi — Thu Aug 13, 2020 12:11 pm

"Visit" URL with command .pizza

2020-08-13T05:44:38-04:00

Since he has if-else there no need for die actually.

And more things, as
- $_GET is deprecated, using of filter_input(INPUT_GET, 'user') is better,
- $user is setted, but the if uses $_GET and not $user,
- if bier_$user.txt doesn't exists, error appear,
- ...

Statistics: Posted by CrazyCat — Thu Aug 13, 2020 5:44 am

"Visit" URL with command .pizza

2020-08-13T00:32:08-04:00

Since he has if-else there no need for die actually.

Statistics: Posted by caesar — Thu Aug 13, 2020 12:32 am

"Visit" URL with command .pizza

2020-08-12T17:57:46-04:00

Log is clear: data are sent with POST, not GET.
So, adapt your php if you can (post is more secure than get) or modify the script to force usage of get:

Code:

set tok [::http::geturl $::desturl -method "GET" -query $query]

P.S.: I hope your PHP is just a POC, because you use depreciated things, too much die, ... really bad code

Statistics: Posted by CrazyCat — Wed Aug 12, 2020 5:57 pm

"Visit" URL with command .pizza

2020-08-12T08:27:28-04:00

Thanks Again CrazyCat!

When i check my Apache2 Logs,
only pizza.php gets triggered, without ?user=<$nick>

Code:

"POST /pizza.php HTTP/1.1" 200 220 "-" "Tcl http client package 2.7.13"

pizza.php:

Code:

Statistics: Posted by Pauschi — Wed Aug 12, 2020 8:27 am

"Visit" URL with command .pizza

2020-08-11T10:08:31-04:00

Nice code CrazyCat

I like the way you did this

Code:

if { ![isop $nick $chan] && ![ishalfop $nick $chan] && ![isvoice $nick $chan] } { return 1 }

I will use that for my code from now on

Statistics: Posted by ComputerTech — Tue Aug 11, 2020 10:08 am

"Visit" URL with command .pizza

2020-08-11T09:36:39-04:00

You may try to understand the script and how it works.
desturl is setted at the beginning, before the proc is called, so adding "user=$nick" is an error because there is no $nick variable setted yet.

In the proc, I create the query (things coming after the ? in url), so:

Code:

set query [::http::formatQuery user $nick]set tok [::http::geturl $::desturl -query $query]

will create:
http://google.de/pizza.php?user=<$nick> (<$nick> is the user doing .pizza)

The interest of this is that if you have special characters in $nick, they will be adapted. And if you need to post rather than get, it's managed by the http call.

Statistics: Posted by CrazyCat — Tue Aug 11, 2020 9:36 am

"Visit" URL with command .pizza

2020-08-11T09:22:05-04:00

Thanks ComputerTech.

@Pauschi: if you want to have it working for voice and ops (add halfop to), the final script is:

Code:

bind pub - ".pizza" pizzameset desturl "http://google.de/pizza.php"package require httpproc pizzame {nick host handle chan text} {   if { ![isop $nick $chan] && ![ishalfop $nick $chan] && ![isvoice $nick $chan] } { return 1 }   set query [::http::formatQuery user $nick]   set tok [::http::geturl $::desturl -query $query]   set data [::http::data $tok]   putserv "PRIVMSG $chan :$data"}

Notice that it won't work with https url.

Thanks! Im using this script because i better skip the HTTPS thing, since its not working with the servers configuration (https force is on there).

However, i tried setting this URL =>

set desturl "http://google.de/pizza.php[b]?user=$nick[/b]"

its not using the $nick (IRC Nickname) with this way

Statistics: Posted by Pauschi — Tue Aug 11, 2020 9:22 am

"Visit" URL with command .pizza

2020-08-11T03:44:44-04:00

Sure there is a way

Code:

bind pub - ".pizza" pizzameset desturl "http://google.de/pizza.php"package require httppackage require tlsproc pizzame {nick host handle chan text} {   if { ![isop $nick $chan] && ![ishalfop $nick $chan] && ![isvoice $nick $chan] } { return 1 }   if { [string match "https://*" $::desturl] } {      ::http::register https 443 [list ::tls::socket -autoservername true]      set https 1   } else {      set https 0   }   set query [::http::formatQuery user $nick]   set tok [::http::geturl $::desturl -query $query]   set data [::http::data $tok]   if { $https == 1 } { ::http::unregister https }   putserv "PRIVMSG $chan :$data"}

I made the script adaptative to url scheme, but you can have troubles with tls handshake, depending on the url you want to access.

Statistics: Posted by CrazyCat — Tue Aug 11, 2020 3:44 am

"Visit" URL with command .pizza

2020-08-11T02:35:30-04:00

Thank you guys, appreciate your work and help!

Ive just learned that https links sadly dont work.

Theres no way to avoid this?

Statistics: Posted by Pauschi — Tue Aug 11, 2020 2:35 am

"Visit" URL with command .pizza

2020-08-11T02:32:29-04:00

Thanks ComputerTech.

@Pauschi: if you want to have it working for voice and ops (add halfop to), the final script is:

Code:

bind pub - ".pizza" pizzameset desturl "http://google.de/pizza.php"package require httpproc pizzame {nick host handle chan text} {   if { ![isop $nick $chan] && ![ishalfop $nick $chan] && ![isvoice $nick $chan] } { return 1 }   set query [::http::formatQuery user $nick]   set tok [::http::geturl $::desturl -query $query]   set data [::http::data $tok]   putserv "PRIVMSG $chan :$data"}

Notice that it won't work with https url.

Statistics: Posted by CrazyCat — Tue Aug 11, 2020 2:32 am

"Visit" URL with command .pizza

2020-08-10T22:17:39-04:00

Like this

Code:

bind pub - ".pizza" pizzame   package require http   proc pizzame {nick host handle chan text} {     if {![isop $nick $chan]} { return 1 }set tok [::http::geturl "http://google.de/pizza.php?user=$nick"]    set data [::http::data $tok]     putserv "PRIVMSG $chan :$data"    }

when CrazyCat says procedure, he means basically the proc

Code:

proc pizzame {nick host handle chan text} {    << Proc

All OPS and VOICE users in the channel should be allowed to do it.

if {![isop $nick $chan]} { return 1 }

Where do i need to set this? ;P

the above code will Only allow channel op's to use the command, there is also..

Code:

if {![isvoice $nick $chan]} { return 1 }

if you prefer that

Statistics: Posted by ComputerTech — Mon Aug 10, 2020 10:17 pm

"Visit" URL with command .pizza

2020-08-10T15:19:56-04:00

All OPS and VOICE users in the channel should be allowed to do it.

if {![isop $nick $chan]} { return 1 }

Where do i need to set this? ;P

Statistics: Posted by Pauschi — Mon Aug 10, 2020 3:19 pm

"Visit" URL with command .pizza

2020-08-10T15:03:05-04:00

It depends on what you mean when you say it must be triggered by operator.

If it's channel operator in the eggdrop' userlist, my bind was right.
If it's being opped in the channel, your bind is right but you have to add a check at the begin of the procedure:

Code:

if {![isop $nick $chan]} { return 1 }

Statistics: Posted by CrazyCat — Mon Aug 10, 2020 3:03 pm

"Visit" URL with command .pizza

2020-08-10T12:15:40-04:00

Thank you very much for answering.

I'll check it out and let you know if its working

yeah it was a example URL

EDIT: Somehow the bot is not responding :/

It worked with:

bind pub - ".pizza" pizzame

but not with

bind pub -|o ".pizza" pizzame

Statistics: Posted by Pauschi — Mon Aug 10, 2020 12:15 pm