egghelp/eggheads community

Not Working 100%

2019-03-02T10:27:42-04:00

hm still gettin same error

Tcl error [::newsFetch::fetch]: wrong # args: should be "tls::socket ?options? host port"

Statistics: Posted by simo — Sat Mar 02, 2019 10:27 am

Not Working 100%

2019-03-02T04:10:57-04:00

Right, replace the news in the namespace line with something else, let's say newsFetch and restart the bot. Issue the !new cnbc (or whatever) and see what happens.

Statistics: Posted by caesar — Sat Mar 02, 2019 4:10 am

Not Working 100%

2019-03-01T15:17:07-04:00

this is what i got so far and i didnt get the log in PL

Code:

namespace eval news {    set news(key) "my key"    set news(url) "https://newsapi.org/v2/top-headlines?sources=%source&sortBy=latest&apiKey=%key"    set news(sources) "https://newsapi.org/v2/sources?apiKey=%key"    set news(timeout) 5000    package require http    package require json    package require tls    proc tls:socket args {       set opts [lrange $args 0 end-2]       set host [lindex $args end-1]       set port [lindex $args end]       ::tls::socket -servername $host {*}$opts $host $port        putlog "tls:correct socket was called!"    }    bind pub * !news [namespace current]::fetch    proc fetch {nick uhost hand chan text} {       variable news       if {[scan $text {%s} source] != 1} {          puthelp "PRIVMSG $chan :Usage: !news  | Pick one from https://newsapi.org/sources"          return       }       ::http::register https 443 [namespace current]::tls:socket       set url [string map [list "%source" "$source" "%key" "$news(key)"] $news(url)]       set token [::http::geturl $url -timeout $news(timeout)]       set data [::http::data $token]       set json [::json::json2dict $data]       ::http::cleanup $token       ::http::unregister https       if {[dict get $json status] eq "ok"} {          set i 0          foreach item [dict get $json articles] {             if {[incr i] > 3} break             dict with item {                puthelp "PRIVMSG $chan :Title: [encoding convertfrom $title] | desc: [encoding convertfrom $description] | url: $url"             }          }       } else {          puthelp "PRIVMSG $chan :The specified source is invalid, pick one from https://newsapi.org/sources"          # To see exact error message uncomment next line          #puthelp "PRIVMSG $chan :Error: [dict get $json message]"       }    } }

still gettin : Tcl error [::news::fetch]: wrong # args: should be "tls::socket ?options? host port"

and i got like max 5 tcls loaded wich none use tls and in conf neither

Statistics: Posted by simo — Fri Mar 01, 2019 3:17 pm

Not Working 100%

2019-03-01T15:12:27-04:00

Yeah, I messed with that. I added a command then changed my mind and forgot to fix it. Removing the extra ] behind -1 should do the trick. Edited and fixed the code above.

The tls:socket that I got in this code accepts any or no arguments. ANd since you get that error means you got the same code in some other place. To see if it's really the case then add a:

Code:

putlog "correct tls::socket was called!"

at the end of the tls:socket function and see if you see that message in the party-line.

Statistics: Posted by caesar — Fri Mar 01, 2019 3:12 pm

Not Working 100%

2019-03-01T10:04:03-04:00

tested it and got this error :

14:58:12 [14:56:42] Tcl error [::news::fetch]: invalid character "]"
14:58:12 in expression "...text {%s} source] != 1]"

after i changed it to

if {[scan $text {%s} source] != 1} {

it still returned me the old error of

[14:59:00] Tcl error [::news::fetch]: wrong # args: should be "tls::socket ?options? host port"

Statistics: Posted by simo — Fri Mar 01, 2019 10:04 am

Not Working 100%

2019-03-01T15:08:20-04:00

I haven't tested this on a bot cos at the time cos didn't have time for it, and since I had some spare time decided to have a look on this as well.

The problem is in this line:

Code:

puthelp "PRIVMSG $chan: Ttitle: [encoding convertfrom $title] | desc: [encoding convertfrom $description] | url: $url"

More specific with $chan: where there should have been a space between the two. As it is right now, if your channel name is #test for example it will try to send the messages to the #test: channel. Notice the : behind the name.

Transform the line into:

Code:

puthelp "PRIVMSG $chan :Ttitle: [encoding convertfrom $title] | desc: [encoding convertfrom $description] | url: $url"

and will work as expected.

If the bot doesn't have some special privileges on your network it will flood itself off very easy since the code I mentioned above will just dump all the 10 articles from the page it grabs.

To display let's say fist 3 articles make the loop from:

Code:

foreach item [dict get $json articles] {dict with item {puthelp "PRIVMSG $chan :Ttitle: [encoding convertfrom $title] | desc: [encoding convertfrom $description] | url: $url"}}

to:

Code:

set i 0foreach item [dict get $json articles] {if {[incr i] > 3} breakdict with item {puthelp "PRIVMSG $chan :Title: [encoding convertfrom $title] | desc: [encoding convertfrom $description] | url: $url"}}

for example.

Edit: Here's the updated code.

Code:

namespace eval news {   set news(key) "your-key"   set news(url) "https://newsapi.org/v2/top-headlines?sources=%source&sortBy=latest&apiKey=%key"   set news(sources) "https://newsapi.org/v2/sources?apiKey=%key"   set news(timeout) 5000   package require http   package require json   package require tls   proc tls:socket args {      set opts [lrange $args 0 end-2]      set host [lindex $args end-1]      set port [lindex $args end]      ::tls::socket -servername $host {*}$opts $host $port   }   bind pub * !news [namespace current]::fetchproc fetch {nick uhost hand chan text} {variable newsif {[scan $text {%s} source] != 1} {puthelp "PRIVMSG $chan :Usage: !news  | Pick one from https://newsapi.org/sources"return}::http::register https 443 [namespace current]::tls:socketset url [string map [list "%source" "$source" "%key" "$news(key)"] $news(url)]set token [::http::geturl $url -timeout $news(timeout)]set data [::http::data $token]set json [::json::json2dict $data]::http::cleanup $token::http::unregister httpsif {[dict get $json status] eq "ok"} {set i 0foreach item [dict get $json articles] {if {[incr i] > 3} breakdict with item {puthelp "PRIVMSG $chan :Title: [encoding convertfrom $title] | desc: [encoding convertfrom $description] | url: $url"}}} else {puthelp "PRIVMSG $chan :The specified source is invalid, pick one from https://newsapi.org/sources"# To see exact error message uncomment next line#puthelp "PRIVMSG $chan :Error: [dict get $json message]"}}}

Statistics: Posted by caesar — Thu Feb 28, 2019 11:51 am

Not Working 100%

2019-02-23T15:56:23-04:00

When i try !news it prompts for the

Usage: !news | Pick one from https://newsapi.org/sources

When i try !news cnbc (Or any other) it does nothing. No errors. Just nothing.

Statistics: Posted by Dominatez — Sat Feb 23, 2019 3:56 pm

Not Working 100%

2019-02-23T11:47:16-04:00

sorry for the unclearity it is still giving same error

this is what i have in use

Code:

namespace eval news {    set news(key) "MY-KEY"    set news(url) "https://newsapi.org/v2/top-headlines?sources=%source&sortBy=latest&apiKey=%key"    set news(timeout) 5000    package require http    package require json    package require tls    proc tls:socket args {       set opts [lrange $args 0 end-2]       set host [lindex $args end-1]       set port [lindex $args end]       ::tls::socket -servername $host {*}$opts $host $port    }    bind pub * !news [namespace current]::fetch    proc fetch {nick uhost hand chan text} {       variable news       if {[scan $text {%s} source] != 1} {          puthelp "PRIVMSG $chan :Usage: !news  | Pick one from https://newsapi.org/sources"          return       }       ::http::register https 443 [namespace current]::tls:socket       set url [string map [list "%source" "$source" "%key" "$news(key)"] $news(url)]       set token [::http::geturl $url -timeout $news(timeout)]       set data [::http::data $token]       set json [::json::json2dict $data]       ::http::cleanup $token       ::http::unregister https       if {[lsearch [dict get $json] "articles"] > -1} {          foreach item [dict get $json articles] {             dict with item {                puthelp "PRIVMSG $chan: Ttitle: [encoding convertfrom $title] | desc: [encoding convertfrom $description] | url: $url"             }          }       } else {          puthelp "PRIVMSG $chan :The specified source is invalid, pick one from https://newsapi.org/sources"          # To see exact error message uncomment next line          #puthelp "PRIVMSG $chan: Error: [dict get $json message]"       }    } }

Statistics: Posted by simo — Sat Feb 23, 2019 11:47 am

Not Working 100%

2019-02-23T08:55:40-04:00

Should I take it that was right and now it's working?

Statistics: Posted by caesar — Sat Feb 23, 2019 8:55 am

Not Working 100%

2019-02-23T07:58:29-04:00

hm ok yes i restarted not sure where i went wrong as i used it as is

Statistics: Posted by simo — Sat Feb 23, 2019 7:58 am

Not Working 100%

2019-02-23T04:12:21-04:00

Code:

% package require http2.8.12% package require tls1.6.7% proc tls:socket args {        set opts [lrange $args 0 end-2]        set host [lindex $args end-1]        set port [lindex $args end]        ::tls::socket -servername $host {*}$opts $host $port}% ::http::register https 443 tls:socket443 tls:socket%

It's still something on your side. Did you restart the bot after unloading scripts?

Statistics: Posted by caesar — Sat Feb 23, 2019 4:12 am

Not Working 100%

2019-02-22T17:59:18-04:00

i checked and unloaded all scripts and checked entire conf and made sure
yet still same error

Statistics: Posted by simo — Fri Feb 22, 2019 5:59 pm

Not Working 100%

2019-02-22T14:55:32-04:00

By any chance you have the tls:socket defined in some other place? I'm asking cos the version in my code takes any or no arguments, yet the error "tls::socket ?options? host port" tells me that you do, so be sure you don't.

Statistics: Posted by caesar — Fri Feb 22, 2019 2:55 pm

Not Working 100%

2019-02-22T12:36:19-04:00

hey there caesar i tried your version of the tcl and it returns this on !news abc-news

Tcl error [::news::fetch]: wrong # args: should be "tls::socket ?options? host port"

Code:

namespace eval news {    set news(key) "MY-KEY"    set news(url) "https://newsapi.org/v2/top-headlines?sources=%source&sortBy=latest&apiKey=%key"    set news(timeout) 5000    package require http    package require json    package require tls    proc tls:socket args {       set opts [lrange $args 0 end-2]       set host [lindex $args end-1]       set port [lindex $args end]       ::tls::socket -servername $host {*}$opts $host $port    }    bind pub * !news [namespace current]::fetch    proc fetch {nick uhost hand chan text} {       variable news       if {[scan $text {%s} source] != 1} {          puthelp "PRIVMSG $chan :Usage: !news  | Pick one from https://newsapi.org/sources"          return       }       ::http::register https 443 [namespace current]::tls:socket       set url [string map [list "%source" "$source" "%key" "$news(key)"] $news(url)]       set token [::http::geturl $url -timeout $news(timeout)]       set data [::http::data $token]       set json [::json::json2dict $data]       ::http::cleanup $token       ::http::unregister https       if {[lsearch [dict get $json] "articles"] > -1} {          foreach item [dict get $json articles] {             dict with item {                puthelp "PRIVMSG $chan: Ttitle: [encoding convertfrom $title] | desc: [encoding convertfrom $description] | url: $url"             }          }       } else {          puthelp "PRIVMSG $chan :The specified source is invalid, pick one from https://newsapi.org/sources"          # To see exact error message uncomment next line          #puthelp "PRIVMSG $chan: Error: [dict get $json message]"       }    } }

Statistics: Posted by simo — Fri Feb 22, 2019 12:36 pm

Not Working 100%

2019-02-22T04:13:17-04:00

Missed an $ there. Find news(timeout) and make it $news(timeout) and should work.

Statistics: Posted by caesar — Fri Feb 22, 2019 4:13 am