egghelp/eggheads community

help in clone scan tcl

2018-11-20T05:32:25-04:00

Change:

Code:

puthelp "PRIVMSG $chan :\($host\) Nick list: $nickList - Clones: $len"

to:

Code:

puthelp "PRIVMSG $chan :\($host\) Nick list: $nickList - Clones: [expr $len - 1]"

and the result will be:

[02:01] <@xsedition> Starting clonescan for #lapaz...
[02:01] <@xsedition> (localhost) Nick list: sicario, supr | Clones: 1
[02:01] <@xsedition> Clones: 1 (33.3%) | Real users: 2 (66.7%) | Took: 0.0ms.

Statistics: Posted by caesar — Tue Nov 20, 2018 5:32 am

help in clone scan tcl

2018-11-20T02:10:16-04:00

replace what you asked me but the report is not correct
Replace:

Code:

incr count $len

with:

Code:

incr count [expr $len - 1]

that is, if there is a real user and the other is a clone, then it would be like that:
suppose that 4 are the nicknames of which 3 are real and one is clone
This is in the channel where I am using the tcl
the report that gives the old tcl is the correct
old tcl

Code:

[01:59] <@Arnold_X-P> .clones[01:59] <@xsedition> Starting clonescan for #lapaz ...[01:59] <@xsedition> (localhost) NickClones: sicario, supr - Clones: 1[01:59] <@xsedition> Clones: 1 (25.0%) Real users: 3 (75.0%) - Took: 0.0ms.

new tcl

Code:

[02:01] <@xsedition> Starting clonescan for #lapaz...[02:01] <@xsedition> (localhost) Nick list: sicario, supr | Clones: 2[02:01] <@xsedition> Clones: 1 (33.3%) | Real users: 2 (66.7%) | Took: 0.0ms.

only this part is the correct thing that the report gives the old tcl and that is what the new tcl needs to perfect
[01:59] <@xsedition> Clones: 1 (25.0%) Real users: 3 (75.0%) - Took: 0.0ms.

Statistics: Posted by Arnold_X-P — Tue Nov 20, 2018 2:10 am

help in clone scan tcl

2018-11-20T01:45:34-04:00

Nick list: Guest37056, supr | Clones: 2

So, you want to count only one of those as clone and the other as a real user?

Replace:

Code:

incr count $len

with:

Code:

incr count [expr $len - 1]

then and the result should be: Clones: 1 (33.3%) | Real users: 2 (66.7%)

Statistics: Posted by caesar — Tue Nov 20, 2018 1:45 am

help in clone scan tcl

2018-11-20T01:24:05-04:00

almost perfect but it lacks something else to work right
old tcl

Code:

[15:58] <@rashino> .clones[15:58]  Starting clonescan for #lapaz ...[15:58]  (localhost) NickClones: Guest37056, supr - Clones: 1[15:58]  Clones: 1 (25.0%) Real users: 3 (75.0%) - Took: 0.0ms.

new tcl

Code:

[16:04] <@rashino> .clone[16:04]  Starting clonescan for #lapaz...[16:04]  (localhost) Nick list: Guest37056, supr | Clones: 2[16:04]  Clones: 2 (66.7%) | Real users: 1 (33.3%) | Took: 0.0ms.

the total of users online are 3 where and 1 is clone....
the correct is clones: 1 (25.0%) real user 3 (75.0%)

Statistics: Posted by Arnold_X-P — Mon Nov 19, 2018 4:20 pm

help in clone scan tcl

2018-11-19T15:55:24-04:00

/facepalm

Forgot to replace this line:

Code:

set p(c) [expr {$len > 0 ? [format %.1f [expr ($count.0 * 100.0) / $len.0]] : "0.0"}]

with:

Code:

set p(c) [expr {$total > 0 ? [format %.1f [expr ($count.0 * 100.0) / $total.0]] : "0.0"}]

Statistics: Posted by caesar — Mon Nov 19, 2018 3:55 pm

help in clone scan tcl

2018-11-19T14:38:36-04:00

the error in the data keeps coming
old tcl

Code:

[14:31] <@rashino> .clones[14:31] <@xsedition> Starting clonescan for #lapaz ...[14:31] <@xsedition> (127.0.0.1) Nick list: Lara22, ddrt - Clones: 1[14:31] <@xsedition> Clones: 1 (25.0%) | Real users: 3 (75.0%) - Took: 0.977ms.

new tcl

Code:

 [14:32] <@rashino> .clone[14:32] <@xsedition> Starting clonescan for #lapaz...[14:32] <@xsedition> (127.0.0.1) Nick list: ddrt, Lara22 | Clones: 2[14:32] <@xsedition> Clones: 2 (200.0%) | Real users: 1 (-100.0%) | Took: 0.0ms.

the detail is here [14:32] <@xsedition> Clones: 2 (200.0%) | Real users: 1 (-100.0%) | Took: 0.0ms.

Statistics: Posted by Arnold_X-P — Mon Nov 19, 2018 2:38 pm

help in clone scan tcl

2018-11-19T15:56:56-04:00

Ah, i see where i did wrong. Give this a try:

Code:

namespace eval clonescan {variable trigger "."   bind pub m|o "${trigger}clone" [namespace current]::clonescanbind pub m|o "${trigger}clones" [namespace current]::clonescan   proc checknick {nick} {set skip [list "S" "Q"]set test [expr {[lsearch -nocase $skip $nick] > -1 ? "1" : "0"}]}proc clonescan {nick uhost hand chan text} {puthelp "PRIVMSG $chan :Starting clonescan for $chan..."set start [clock clicks]foreach user [chanlist $chan] {if {[checknick $user] || [isbotnick $user]} continueset host [lindex [split [getchanhost $user $chan] @] 1]lappend clones($host) $user}set total 0set count 0foreach host [array names clones] {set len [llength $clones($host)]if {$len > 1} {set nickList [join [join $clones($host)] ", "]puthelp "PRIVMSG $chan :\($host\) Nick list: $nickList | Clones: $len"incr count $len}incr total $len}set p(c) [expr {$total > 0 ? [format %.1f [expr ($count.0 * 100.0) / $total.0]] : "0.0"}]set p(u) [expr (100.0 - $p(c))]set end [clock clicks]puthelp "PRIVMSG $chan :Clones: $count ($p(c)%) | Real users: [expr ($total - $count)] ($p(u)%) | Took: [expr ($end-$start)/1000.0]ms."}}

Edit: Fixed. I hope.

Statistics: Posted by caesar — Mon Nov 19, 2018 12:28 pm

help in clone scan tcl

2018-11-19T11:31:42-04:00

but note that the data you give is not correct
I will give an example of a report that gives the old tcl
here (old tcl)

Code:

[22:59] <@Arnold_X-P> .clones[22:59]  Starting clon escan for  #lapaz ...[22:59]  (127.0.0.1) Nick list: Guest37056, ddrt - Clones: 1[22:59]  Clones: 1 (25.0%) Real users: 3 (75.0%) -Took: 0.977ms.

I put here a report that generates the current tcl (new tcl)

Code:

[22:47] <@Arnold_X-P> .clone[22:47]  Starting clonescan for #lapaz ...[22:47]  (127.0.0.1) Nick list: Guest37056, ddrt | Clones: 2[22:47]  Clones: 2 (200.0%) | Real users: -1 (-100.0%) | Took: 0.0ms.

the detail is that the current tcl does not generate a correct report compared to the old tcl I mean Clones: 2 (200.0%) | Real users: -1 (-100.0%)

Code:

namespace eval clonescan {variable trigger "."bind pub m|o "${trigger}clone" [namespace current]::clonescanbind pub m|o "${trigger}clones" [namespace current]::clonescanproc checknick {nick} {set skip [list "S" "Q"]set test [expr {[lsearch -nocase $skip $nick] > -1 ? "1" : "0"}]}proc clonescan {nick uhost hand chan text} {putquick "PRIVMSG $chan :Starting clonescan for $chan..."set start [clock clicks]foreach user [chanlist $chan] {if {[checknick $user] || [isbotnick $user]} continueset host [lindex [split [getchanhost $user $chan] @] 1]lappend clones($host) $user}set count 0foreach host [array names clones] {set len [llength $clones($host)]if {$len > 1} {set nickList [join [join $clones($host)] ", "]puthelp "PRIVMSG $chan :\($host\) Nick list: $nickList | Clones: $len"incr count $len}}set p(c) [expr {$len > 0 ? [format %.1f [expr ($count.0 * 100.0) / $len.0]] : "0.0"}] set p(u) [expr (100.0 - $p(c))]set end [clock clicks]puthelp "PRIVMSG $chan :Clones: $count ($p(c)%) | Real users: [expr ($len - $count)] ($p(u)%) | Took: [expr ($end-$start)/1000.0]ms."}}

if you notice the examples they are different and they should be the same and if you notice the second tcl the reports are very exaggerated

Statistics: Posted by Arnold_X-P — Mon Nov 19, 2018 11:31 am

help in clone scan tcl

2018-11-16T02:54:58-04:00

Don't know why I complicated things so much when things can be a lot simpler.

Code:

namespace eval clonescan {variable trigger "."bind pub m|o "${trigger}clone" [namespace current]::clonescanbind pub m|o "${trigger}clones" [namespace current]::clonescanproc checknick {nick} {set skip [list "S" "Q"]set test [expr {[lsearch -nocase $skip $nick] > -1 ? "1" : "0"}]}proc clonescan {nick uhost hand chan text} {putquick "PRIVMSG $chan :Starting clonescan for $chan..."set start [clock clicks]foreach user [chanlist $chan] {if {[checknick $user] || [isbotnick $user]} continueset host [lindex [split [getchanhost $user $chan] @] 1]lappend clones($host) $user}set count 0foreach host [array names clones] {set len [llength $clones($host)]if {$len > 1} {set nickList [join [join $clones($host)] ", "]puthelp "PRIVMSG $chan :\($host\) Nick list: $nickList | Clones: $len"incr count $len}}set p(c) [expr {$len > 0 ? [format %.1f [expr ($count.0 * 100.0) / $len.0]] : "0.0"}] set p(u) [expr (100.0 - $p(c))]set end [clock clicks]puthelp "PRIVMSG $chan :Clones: $count ($p(c)%) | Real users: [expr ($len - $count)] ($p(u)%) | Took: [expr ($end-$start)/1000.0]ms."}}

Statistics: Posted by caesar — Fri Nov 16, 2018 2:54 am

help in clone scan tcl

2018-11-15T21:47:27-04:00

it does not work it still has failures..

Statistics: Posted by Arnold_X-P — Thu Nov 15, 2018 9:47 pm

help in clone scan tcl

2018-02-06T11:12:22-04:00

now it works without giving failures.

Code:

namespace eval clonescan {   variable trigger "."      bind pub m|o "${trigger}clone" [namespace current]::commands   bind pub m|o "${trigger}clones" [namespace current]::commands   proc checknick {nick} {   set skip [list "S" "Q"]   set test [expr {[lsearch -nocase $skip $nick] > -1 ? "1" : "0"}]}   proc commands {nick uhost hand chan text} {  putquick "PRIVMSG $chan :Starting clonescan for $chan..."  set start [clock clicks]     set chanlist [chanlist $chan]  foreach user $chanlist {    if {[checknick $user]} continue lappend userList $user    }  set len [llength $userList]  set bh [lindex [split $::botname @] 1]    while {$len > 0} {     set u1 [lindex [split $userList] 0]     set h1 [lindex [split [getchanhost $u1 $chan] @] 1]     set userList [lreplace $userList 0 0] foreach u2 $userList {     set h2 [lindex [split [getchanhost $u2 $chan] @] 1] if {[string equal -nocase $bh $h2]} continue  if {[string equal -nocase $h1 $h2]} {    if {[expr [lsearch -nocase [array names clones] $h1]] > -1} {     lappend clones($h1) $u2} else {     lappend clones($h1) [list $u1 $u2]        }      }    }  incr len -1 }  set end [clock clicks]  set count 0 foreach host [array names clones] {  set nickList [join [join $clones($host)] ", "]  set len [llength $nickList]    puthelp "PRIVMSG $chan :\($host\) Nick list: $nickList - Clones: $len"     incr $count $len } set p(c) [expr {$len > 0 ? [format %.1f [expr ($count.0 * 100.0) / $len.0]] : "0.0"}]   set p(u) [expr (100.0 - $p(c))]   puthelp "PRIVMSG $chan :Clones: $count ($p(c)%) Real users: [expr ($len - $count)] ($p(u)%) - Took: [expr ($end-$start)/1000.0]ms."   }}

caesar the corrected tcl only shows all zero until the second calculation puts it to zero and I do not think it's real..
something is wrong because it should not give zero if there are real users connected.

Code:

[11:09] <@sedition> .clone[11:09] <@JulieTh> Starting clonescan for #tcls...[11:09] <@JulieTh> Clones: 0 (0.0%) Real users: 0 (100.0%) - Took: 0.0ms.

the right thing would be like that:

Code:

[11:10] <@sedition> .clone[11:10] <@JulieTh> Starting clonescan for #tcls...[11:10] <@JulieTh> Clones: 0 (0.0%) Real users: 3 (100.0%) - Took: 3.0ms.

Statistics: Posted by Arnold_X-P — Tue Feb 06, 2018 11:12 am

help in clone scan tcl

2018-02-06T02:10:22-04:00

Ah. A little fix for that:

Code:

   proc checknick {nick} {      set skip [list "S" "Q"]      if {[isbotnick $nick] || [expr [lsearch -nocase $skip $nick]] > -1} return 0      return 1   }

with:

Code:

proc checknick {nick} {set skip [list "S" "Q"]set test [expr {[lsearch -nocase $skip $nick] > -1 ? "1" : "0"}]}

If the amount of clones is 0 then:

Code:

set p(c) [format %.1f [expr ($count.0 * 100.0) / $len.0]]

will give an error so to fix that as well replace this line with:

Code:

set p(c) [expr {$len > 0 ? [format %.1f [expr ($count.0 * 100.0) / $len.0]] : "0.0"}]

If there's another user on the same host as the bot then the user and that user will show up as clones.

.clones
<@bot> Starting clonescan for #channel...
<@bot> (x.x.x.x) Nick list: bot, cez - Clones: 2
<@bot> Clones: 0 (0.0%) Real users: 2 (100.0%) - Took: 0.088ms.

If you want to "fix" this as well then under:

Code:

set len [llength $userList]

we add:

Code:

set bh [lindex [split $::botname @] 1]

and under:

Code:

set h2 [lindex [split [getchanhost $u2 $chan] @] 1]

we add:

Code:

if {[string equal -nocase $bh $h2]} continue

and then the result will be:

.clones
<@bot> Starting clonescan for #channel...
<@bot> Clones: 0 (0.0%) Realusers: 0 (100.0%) - Took: 0.086ms.

Statistics: Posted by caesar — Tue Feb 06, 2018 2:10 am

help in clone scan tcl

2018-02-05T21:43:11-04:00

try to use other variants but for the time being the error persists.

Statistics: Posted by Arnold_X-P — Mon Feb 05, 2018 9:43 pm

help in clone scan tcl

2018-01-30T20:05:57-04:00

new error

Code:

 [20:05:26] Tcl error [::clonescan::commands]: expected boolean value but got ""

Statistics: Posted by Arnold_X-P — Tue Jan 30, 2018 8:05 pm

help in clone scan tcl

2018-01-30T19:58:50-04:00

Try replace

Code:

if {[checknick $u1]} continue

With

Code:

if {[checknick $user]} continue

Statistics: Posted by SpiKe^^ — Tue Jan 30, 2018 7:58 pm