egghelp/eggheads community

duplicate bans remover

2018-02-17T14:02:08-04:00

hm ok

Statistics: Posted by simo — Sat Feb 17, 2018 2:02 pm

duplicate bans remover

2018-02-16T03:03:34-04:00

Here's your answer:

Code:

.tcl matchaddr *\{*!*@* *\[*!*@*Tcl: 1.tcl matchaddr *\]*!*@* *\}*!*@*Tcl: 1

The matchaddr isn't as infallible after all.

Statistics: Posted by caesar — Fri Feb 16, 2018 3:03 am

duplicate bans remover

2018-02-15T20:01:27-04:00

ive come across something weird when setting these bans somehow it removes 3 while they arent duplicates

* Cappuccino sets mode: +bbbbbbbbbbbbbbb *`*!*@* *|*!*@* *-*!*@* *_*!*@* *0*!*@* *1*!*@* *2*!*@* *3*!*@* *4*!*@* *5*!*@* *6*!*@* *7*!*@* *8*!*@* *9*!*@* *[*!*@*
* Cappuccino sets mode: +bbbbb *]*!*@* *{*!*@* *}*!*@* *\*!*@* *^*!*@*
* Cappuccino sets mode: -bbb *[*!*@* *]*!*@* *|*!*@*

Statistics: Posted by simo — Thu Feb 15, 2018 8:01 pm

duplicate bans remover

2018-01-30T17:25:20-04:00

did some more testing seems all fine now

i would like to thank pixelz , spike and ceaser for all input and work

much apreciated as always as this is all volunteer work

im sure this code will benefit many

tnx again.

Statistics: Posted by simo — Tue Jan 30, 2018 5:25 pm

duplicate bans remover

2018-01-30T15:12:20-04:00

i tested with 14 bans it seemed to have lifted them all

first i added *!*@*.ip

than added

+bbbbbbbbbbbbbb *!*@RifSytes-o11.387.29.04.IP *!*@RifSytes-nvb.556.35.86.IP *!*@RifSytes-82g.190.68.53.IP *!*@RifSytes-a55.957.51.59.IP *!*@RifSytes-48k.337.61.92.IP *!*@RifSytes-f35.133.11.50.IP *!*@RifSytes-q27.186.99.12.IP *!*@RifSytes-619.596.86.72.IP *!*@RifSytes-mb0.415.32.86.IP *!*@RifSytes-x1l.677.14.90.IP *!*@RifSytes-fkw.580.12.02.IP *!*@RifSytes-ef3.338.14.84.IP *!*@RifSytes-pc2.135.01.63.IP *!*@RifSytes-ohd.781.33.90.IP

it removed them all

Statistics: Posted by simo — Tue Jan 30, 2018 3:12 pm

duplicate bans remover

2018-01-30T14:13:47-04:00

Please try it with the setting of 14 bans at one time, both times it seems to ignore the 15th.

Please test my theory by starting with an empty channel ban list and adding no more than 14 bans at a time.

There is no other good reason it would always remove the 14 and not a 15th, if it existed in the channel ban list.

It would help if you would let me or caesar see this script work, share your channel and network (feel free to private message that info to me).

Statistics: Posted by SpiKe^^ — Tue Jan 30, 2018 2:13 pm

duplicate bans remover

2018-01-30T11:48:38-04:00

the server accepts 15 mode settings per line actually

i was just wondering why doesnt it remove all matching duplicates regardless

perhaps maybe using stacked per 15

i also tried caesars it only seems to remove 2 or 3 from 30 and also if using 15

Statistics: Posted by simo — Tue Jan 30, 2018 11:48 am

duplicate bans remover

2018-01-30T09:40:22-04:00

It is worth noting, the ban that does not seem to be removed, is the 15th and last ban set in the list.

My bet is that the server is only really accepting 14 mode changes at a time, and the last ban is Not actually set.

Then the script removes the 14 matching bans:)

Statistics: Posted by SpiKe^^ — Tue Jan 30, 2018 9:40 am

duplicate bans remover

2018-01-30T09:28:49-04:00

So, in the post the bans you mentioned above are in Spike's version? Mind doing the same with the one I suggested with the latest changes?

I don't have much time right now to test stuff out right now.

Statistics: Posted by caesar — Tue Jan 30, 2018 9:28 am

duplicate bans remover

2018-01-30T06:00:54-04:00

Its an extreme example Indeed with 30 duplicates, i also tested with like 15 duplicates with same result

also i thought of the example of *!*@* set by accident will result in entire ban list removal and should prob be exempted from triggering

I used your version in this test spike

Statistics: Posted by simo — Tue Jan 30, 2018 6:00 am

duplicate bans remover

2018-01-30T09:32:44-04:00

In that test above, the script appears to have left 2 bans that should have been removed.

This seems like an extreme example, no one would have 30 similar bans set on a channel.

Which of these 2 scripts are you running??

Statistics: Posted by SpiKe^^ — Mon Jan 29, 2018 6:32 pm

duplicate bans remover

2018-01-29T15:25:00-04:00

it doesnt remove all matching duplicates

sets mode: +b *!*@*.IP
sets mode: +bbbbbbbbbbbbbbb *!*@RifSytes-zcd.299.27.20.IP *!*@RifSytes-599.460.33.69.IP *!*@RifSytes-3g5.144.20.79.IP *!*@RifSytes-066.185.88.80.IP *!*@RifSytes-ll9.546.74.68.IP *!*@RifSytes-6u3.339.13.92.IP *!*@RifSytes-kqs.407.57.83.IP *!*@RifSytes-b7v.883.54.19.IP *!*@RifSytes-56d.862.69.27.IP *!*@RifSytes-ox5.511.75.48.IP *!*@RifSytes-6sw.885.18.89.IP *!*@RifSytes-5i6.288.53.70.IP *!*@RifSytes-v32.936.41.94.IP *!*@RifSytes-54f.459.78.41.IP *!*@RifSytes-bwp.836.85.33.IP
sets mode: +bbbbbbbbbbbbbbb *!*@RifSytes-m36.196.43.47.IP *!*@RifSytes-915.770.49.94.IP *!*@RifSytes-5qy.659.08.92.IP *!*@RifSytes-3ut.148.34.53.IP *!*@RifSytes-3o9.200.73.87.IP *!*@RifSytes-pm7.923.75.08.IP *!*@RifSytes-996.695.55.62.IP *!*@RifSytes-gk0.421.24.66.IP *!*@RifSytes-071.544.81.59.IP *!*@RifSytes-sv8.105.76.27.IP *!*@RifSytes-5ob.997.12.63.IP *!*@RifSytes-nh3.819.91.12.IP *!*@RifSytes-50n.997.16.02.IP *!*@RifSytes-4q7.694.07.31.IP *!*@RifSytes-o8a.187.92.31.IP
sets mode: -bbbbbb *!*@RifSytes-zcd.299.27.20.IP *!*@RifSytes-599.460.33.69.IP *!*@RifSytes-3g5.144.20.79.IP *!*@RifSytes-066.185.88.80.IP *!*@RifSytes-ll9.546.74.68.IP *!*@RifSytes-6u3.339.13.92.IP
sets mode: -bbbbbb *!*@RifSytes-kqs.407.57.83.IP *!*@RifSytes-b7v.883.54.19.IP *!*@RifSytes-56d.862.69.27.IP *!*@RifSytes-ox5.511.75.48.IP *!*@RifSytes-6sw.885.18.89.IP *!*@RifSytes-5i6.288.53.70.IP
sets mode: -bb *!*@RifSytes-v32.936.41.94.IP *!*@RifSytes-54f.459.78.41.IP
sets mode: -bbbbbb *!*@RifSytes-m36.196.43.47.IP *!*@RifSytes-915.770.49.94.IP *!*@RifSytes-5qy.659.08.92.IP *!*@RifSytes-3ut.148.34.53.IP *!*@RifSytes-3o9.200.73.87.IP *!*@RifSytes-pm7.923.75.08.IP
sets mode: -bbbbbb *!*@RifSytes-996.695.55.62.IP *!*@RifSytes-gk0.421.24.66.IP *!*@RifSytes-071.544.81.59.IP *!*@RifSytes-sv8.105.76.27.IP *!*@RifSytes-5ob.997.12.63.IP *!*@RifSytes-nh3.819.91.12.IP
sets mode: -bb *!*@RifSytes-50n.997.16.02.IP *!*@RifSytes-4q7.694.07.31.IP

Statistics: Posted by simo — Mon Jan 29, 2018 3:25 pm

duplicate bans remover

2018-01-29T13:48:18-04:00

Something is not working or what are you saying? Mind posting an example so I can come on Dalnet and test stuff on my own?

Statistics: Posted by caesar — Mon Jan 29, 2018 1:48 pm

duplicate bans remover

2018-01-29T11:29:03-04:00

hm ok yes i think u already mentioned it since what i also discovered after testing is the more bans match then it removes most but leaves like 2 or 3

Statistics: Posted by simo — Mon Jan 29, 2018 11:29 am

duplicate bans remover

2018-01-29T10:29:25-04:00

Replace

Code:

puthelp "MODE $ch -$mode $bans"

with:

Code:

pushmode $ch -$mode $bans

but I can't test if multiple bans will removed at the same time OR will get some weird behavior, at least I got some on Undernet.

Anyway, there's a key difference in the way I loop vs. the way Spike's code loops. And no, is not about me using while and a foreach and him using two foreach loops cos it's basically the same thing.

The difference lays in:

Code:

set b1 [lindex [split $banlist] 0]set banlist [lreplace $banlist 0 0]

Let me explain. Let's say the channel banlist is a list of numbers: 1, 2, 3, 4, 5, 6, 7, 8, 9 and 10 (in my example will use from 1 to 5). Now, if we look at the code:

Code:

foreach ban1 [chanbans $ch] {set ban1 [lindex $ban1 0] foreach ban2 [chanbans $ch] {set ban2 [lindex $ban2 0]if {$ban1 eq $ban2} {  continue  }if {[matchaddr $ban1 $ban2]} {lappend redundant $ban2}} }

And simplify it to see what's going on:

Code:

foreach a [split $bans] {foreach b [split $bans] {puts "$a vs $b"}}

the result will be:

Code:

% foreach a [split $bans] { foreach b [split $bans] { puts "$a vs $b" } }1 vs 11 vs 21 vs 31 vs 41 vs 52 vs 12 vs 22 vs 32 vs 42 vs 53 vs 13 vs 23 vs 33 vs 43 vs 54 vs 14 vs 24 vs 34 vs 44 vs 55 vs 15 vs 25 vs 35 vs 45 vs 5

meaning 25 attempts to match one ban mask with another. With just a single lines inside the first loop that will basically remove the first element from the list every time the loop executes:

Code:

foreach a [split $bans] {set bans [lreplace $bans 0 0]foreach b [split $bans] {puts "$a vs $b"}}

the result will be:

Code:

% foreach a [split $bans] { set bans [lreplace $bans 0 0]; foreach b [split $bans] { puts "$a vs $b" } }1 vs 21 vs 31 vs 41 vs 52 vs 32 vs 42 vs 53 vs 43 vs 54 vs 5

meaning 10 attempts to match one ban mask with another. That's 15 matches that have been already done, meaning a 60% decrease in time used for matching bans.

If where to compare 30 bans then this means 900 attempts vs. 435 attempts ONLY by adding that lreplace line.

Code:

% set bans [list 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30]1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30% set c 00% foreach a [split $bans] { foreach b [split $bans] { incr c } }; puts $c900

vs.

Code:

% set bans [list 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30]1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30% set c 00% foreach a [split $bans] { set bans [lreplace $bans 0 0]; foreach b [split $bans] { incr c } }; puts $c435

This means an 51.66% less matching. If where to compare 50 vs. same 50 then there would be 2500 matches vs. 1225 with just a single lreplace line. That's INSANE!

I just noticed that I forgot to take that if {$ban1 eq $ban2} { continue } line into account, but this doesn't make much of a difference, basically with 10 bans instead of 100 will do only 90 matches, still double of the other method that has the lreplace trick in.

I think we can push this a notch further by adding another lreplace, but need to do some testing first.

Statistics: Posted by caesar — Mon Jan 29, 2018 10:29 am