egghelp/eggheads community

Sort file data

2017-04-18T06:14:45-04:00

You're right, I've changed it back to -integer and it works fine.
I had changed it to -real because earlier it gave me an error of the type:
Tcl error: expected floating-point number but got "5.00 15.00 11.00 14.00 2.00".

I understood that a floating number was expected and got a list of floating numbers.

Now I changed it again as you advise me and it works ..

It's just that I made so many changes and tests that I forgot about the mistakes it gave me.

Thank you so much caesar

Statistics: Posted by juanamores — Tue Apr 18, 2017 6:14 am

Sort file data

2017-04-18T00:49:13-04:00

Since the rank you read from the file is an integer you don't really need to format it to real cos when doing the average it won't matter if it was real or not.

Anyway, glad you sorted it out. De nada.

Statistics: Posted by caesar — Tue Apr 18, 2017 12:49 am

[Solved!]

2017-04-17T16:17:19-04:00

Fixed! This is what I wanted.
Thank you so much to caesar and willyw.

Code:

proc averages {nick uhost hand chan text} {set fp [open "ranking" "r"]set data [read -nonewline $fp]close $fpforeach line [split $data "\n"] {if {[scan $line {%s%d} name rank] != 2} continuelappend ranking($name) [format "%.2f" $rank]}foreach {name values} [array get ranking] {set average [expr ([join $values +]) / [llength $values]]lappend result [list $name [expr round ([format "%.2f" $average])]]#putlog "debugging decimal: $average"}set results [lsort -index 1 -real -decreasing [lsort -index 0 $result]]foreach pair $results {scan $pair {%s%d} name rankputlog "$name $rank"}}

Statistics: Posted by juanamores — Mon Apr 17, 2017 4:17 pm

Sort file data

2017-04-17T14:20:09-04:00

caesar is almost perfect.
There is only one small detail that I can not solve.
It is about applying the rounding rule with the "round" function.
If you look at the values of Pedro
9 + 10 + 4 = 23
23/3 = 7.66
The final result of Pedro should be 8, not 7.
It can be fixed?

Statistics: Posted by juanamores — Mon Apr 17, 2017 2:20 pm

Sort file data

2017-04-17T13:56:26-04:00

Yeah, had a feeling that will fail miserably.

Here is a TCL 8.4/8.5 version that should be compatible with newer versions of TCL, if you decide to install a new one (a good idea security wise by the way).

Code:

bind pub - !avgs averagesproc averages {nick uhost hand chan text} {set fp [open "ranking" "r"]set data [read -nonewline $fp]close $fpforeach line [split $data "\n"] {if {[scan $line {%s%d} name rank] != 2} continuelappend ranking($name) $rank}foreach {name values} [array get ranking] {set average [expr ([join $values +]) / [llength $values]]lappend result [list $name $average]}set results [lsort -index 1 -integer -decreasing [lsort -index 0 $result]]foreach pair $results {scan $pair {%s%d} name rankputs "$name $rank"}}

Result:

Maria 12
Jose 10
Ana 9
Pedro 7
Ben 3
Luis 3

Statistics: Posted by caesar — Mon Apr 17, 2017 1:56 pm

Sort file data

2017-04-17T13:42:58-04:00

Error: Tcl error [averages]: element 1 missing from sublist "10"

Statistics: Posted by juanamores — Mon Apr 17, 2017 1:42 pm

Sort file data

2017-04-17T13:41:41-04:00

As expected. The -stride option has been added in 8.6, hence the error.

Try with the change i said above.

Statistics: Posted by caesar — Mon Apr 17, 2017 1:41 pm

Sort file data

2017-04-17T13:39:52-04:00

running eggdrop v1.6.21
Tcl version: 8.5.13 (header version 8.5.13)

Statistics: Posted by juanamores — Mon Apr 17, 2017 1:39 pm

Sort file data

2017-04-17T13:35:48-04:00

caesar your code gives an error:
Tcl error [averages]: bad option "-stride": must be -ascii, -command, -decreasing, -dictionary, -increasing, -index, -indices, -integer, -nocase, -real, or -unique

do:
.status
in the partyline, and note the version of TCL your bot is using, and post it here for caesar .

edit:
We posted at the exact same time!

Statistics: Posted by willyw — Mon Apr 17, 2017 1:35 pm

Sort file data

2017-04-17T13:35:40-04:00

You seem to have an old TCL library, cos stride is in version 8.6 and upwards. Since I got 8.6 I can't test if replacing:

Code:

set results [lsort -stride 2 -index 1 -integer -decreasing [lsort -stride 2 -index 0 [array get result]]]

with:

Code:

set results [lsort -index 1 -integer -decreasing [lsort -index 0 [array get result]]]

will work so let me know to find another solution.

Statistics: Posted by caesar — Mon Apr 17, 2017 1:35 pm

Sort file data

2017-04-17T13:31:12-04:00

caesar your code gives an error:

Tcl error [averages]: bad option "-stride": must be -ascii, -command, -decreasing, -dictionary, -increasing, -index, -indices, -integer, -nocase, -real, or -unique

Statistics: Posted by juanamores — Mon Apr 17, 2017 1:31 pm

Sort file data

2017-04-17T13:33:15-04:00

Here's a clean and a lot shorter code:

Code:

bind pub - !avgs averagesproc averages {nick uhost hand chan text} {set fp [open "ranking" "r"]set data [read -nonewline $fp]close $fpforeach line [split $data "\n"] {if {[scan $line {%s%d} name rank] != 2} continuelappend ranking($name) $rank}foreach {name values} [array get ranking] {set average [expr ([join $values +]) / [llength $values]]lappend result($name) $average}set results [lsort -stride 2 -index 1 -integer -decreasing [lsort -stride 2 -index 0 [array get result]]]foreach {name score} $results {putlog "$name $score"}}

The result is the same:

Maria 12
Jose 10
Ana 9
Pedro 7
Luis 3

The data I used is from what you posted at your second comment. Isn't the result what you are looking for?

Edit: Shorted the code removing unnecessarily loops. Don't know why I didn't think about this in the first place.

Second edit: Since your initial list doesn't have two names with an identical result I didn't see:

Maria 12
Jose 10
Ana 9
Pedro 7
Luis 3
Ben 3

Notice that the list is sorted only by average (descending) and member names aren't sorted so to get them sorted as well changed the code to first sort by name as a secondary key and then sort by average (descending) as a primary key.
So we:

Code:

# build a flat listset results [array get result]# sort by name as a secondary keyset results [lsort -stride 2 -index 0 $result]# then sort by average (descending) as a primary key.set results [lsort -stride 2 -index 1 -integer -decreasing $results]

and all 3 lines combined:

Code:

set results [lsort -stride 2 -index 1 -integer -decreasing [lsort -stride 2 -index 0 [array get result]]]

Result:

Maria 12
Jose 10
Ana 9
Pedro 7
Ben 3
Luis 3

Is this final result what you where looking for?

Statistics: Posted by caesar — Mon Apr 17, 2017 12:42 pm

Sort file data

2017-04-17T12:33:04-04:00

I showed you one way to sort it, above. You can adapt from that.

In your solution, you get the result by sorting a list, but with the caesar code I have to sort an array.
I haven't idea how to integrate both ideas...

Statistics: Posted by juanamores — Mon Apr 17, 2017 12:33 pm

Sort file data

2017-04-17T12:15:41-04:00

Code:

bind pub - !avgs averagesproc averages {nick uhost hand chan text} {set fp [open "ranking" "r"]set data [read -nonewline $fp]close $fpforeach line [split $data "\n"] {if {[scan $line {%s%d} name rank] != 2} continuelappend ranking($name) $rank}foreach name [array names ranking] {set total 0set count [llength $ranking($name)] foreach no $ranking($name) {incr total $no}set average [expr round ([expr $total / $count])]lappend result($name) $average}set data [lsort -stride 2 -index 1 -integer -decreasing [array get result]]foreach {name score} $data {putlog "$name $score"}}

Should do what you wanted.

Maria 12
Jose 10
Ana 9
Pedro 8
Luis 3

If you want to get an rounded result like:

Maria 12.20
Jose 10.00
Ana 9.40
Pedro 7.67
Luis 3.00

then replace:

Code:

set average [expr round ([expr $total / $count])]and set data [lsort -stride 2 -index 1 -integer -decreasing $data]

with:

Code:

set average [format "%.2f" [expr $total / $count]]andset data [lsort -stride 2 -index 1 -real -decreasing $data]

Statistics: Posted by caesar — Mon Apr 17, 2017 12:15 pm

Sort file data

2017-04-17T11:49:34-04:00

Now I need to sort the results, from highest to lowest.

willyw, I appreciate your contributions, it is not a game, I did not copy more code because I only need to sort the values of a file.
caesar understood my idea, now I just need to modify the caesar's code to get the ranking ordered from highest to lowest.

Ok.
I showed you one way to sort it, above. You can adapt from that.

Good luck with it.

Statistics: Posted by willyw — Mon Apr 17, 2017 11:49 am