egghelp/eggheads community

enforce bans / kicks on all common channels

2021-05-26T11:41:02-04:00

excellent that seems to work in all conditions thanks caesar

i also tested the one for removal and that seems to work as well

much apreciated caesar

Statistics: Posted by simo — Wed May 26, 2021 11:41 am

enforce bans / kicks on all common channels

2021-05-26T10:26:56-04:00

Right, let's give matchaddr a try then by replacing:

Code:

if {![string match -nocase $ban $n![getchanhost $n $c]]} continue

with:

Code:

if {![matchaddr $ban $n![getchanhost $n $c]]} continue

See if this works and reply back.

Statistics: Posted by caesar — Wed May 26, 2021 10:26 am

enforce bans / kicks on all common channels

2021-05-26T09:58:12-04:00

thanks for the reply caesar i changed what u suggested but now when trying to
ban like:

15:56:09 &ChanServ Sets Mode on #shqiperia to: +b *[*!*@*
15:56:09 (1 User) is Banned [dsqw]ccno

wich should have kicked out [dsqw]ccno
but it didnt trigger and no errors

Statistics: Posted by simo — Wed May 26, 2021 9:58 am

enforce bans / kicks on all common channels

2021-05-26T02:18:24-04:00

Ah, there's a space between - and $enforce(max), just remove it in:

Code:

incr len - $enforce(max)

like:

Code:

incr len -$enforce(max)

As for this:

looks to be working good caesar
is it possible to have it also remove ban on all channels if a ban is removed

Add this in the namespace of the other code:

Code:

bind mode - "% -b" [namespace current]::banRemovalproc banRemoval {nick uhost hand chan mc ban} {foreach ch [channels] {if {![botisop $ch]} continueif {[ischanban $ban $ch]} {pushmode $ch -b $ban}}}

Haven't tested so let me know if works (or doesn't) as intended.

Statistics: Posted by caesar — Wed May 26, 2021 2:18 am

enforce bans / kicks on all common channels

2021-05-25T12:47:05-04:00

i tested your script again ceasar when setting bans on weird chars of nicks and that gave me an error:

&ChanServ Sets Mode on #shqiperia to: +b *[*!*@*
18:44:37 (1 User) is Banned [hjsdd]

wich should have kicked [hjsdd]

but instead returned error: Tcl error [::enforceBans::enforce]: wrong # args: should be "incr varName ?increment?"

Statistics: Posted by simo — Tue May 25, 2021 12:47 pm

enforce bans / kicks on all common channels

2016-06-18T16:45:32-04:00

i dont know how too i tried few things but didnt work

Statistics: Posted by simo — Sat Jun 18, 2016 4:45 pm

enforce bans / kicks on all common channels

2016-06-17T22:37:19-04:00

looks to be working good caesar
is it possible to have it also remove ban on all channels if a ban is removed

You'd have to

Code:

bind mode - "% -b" [namespace current]::banRemoval

and track either only the bans the bot placed, or all of the bans on each channel. It would require building another proc (named banRemoval) to do the opposite of what the enforce procedure does.

Statistics: Posted by Get_A_Fix — Fri Jun 17, 2016 10:37 pm

enforce bans / kicks on all common channels

2016-06-17T11:10:51-04:00

looks to be working good caesar
is it possible to have it also remove ban on all channels if a ban is removed

Statistics: Posted by simo — Fri Jun 17, 2016 11:10 am

enforce bans / kicks on all common channels

2021-05-26T02:23:09-04:00

So now you want the bot to "copy" all bans on all the channels the bot is a channel operator, and top of that enforce the kicking of any members that would match the new banned mask?

If yes then try this and let me know how things work, cos I haven't tested anything this time.

Code:

namespace eval enforceBans {# How many members can be kicked in the same lineset enforce(max) "6"# Define the reason. Notice the %ban that will be replaced with the actual mask.# You can use %who as well and will also be replaced with the actual nick of the user who set the ban.set enforce(reason) "Ban %ban set in %from matches your host. You are banned!"bind mode - "% +b" [namespace current]::enforceproc enforce {nick uhost hand chan mc ban} {variable enforceset reason [string map [list "%from" $chan "%ban" $ban "%who" $nick] $enforce(reason)]foreach c [channels] {if {![botisop $c]} continueif {![string equal -nocase $c $chan]} {set match 0foreach b [chanbans $c] {if {![string match -nocase $b $ban]} continueincr matchbreak}if {!$match} {pushmode $c +b $ban}}foreach n [lreplace [chanlist $c] 0 0] {if {![string match -nocase $ban $n![getchanhost $n $c]]} continueif {[isop $n $c] || [ishalfop $n $c] || [matchattr [nick2hand $n] "fnmo|fnmo" $c]} continuelappend kickList($c) $n}if {[info exists kickList($c)]} {set len [llength $kickList($c)]while {$len > 0} {if {$len > $enforce(max)} {set users [join [lrange $kickList($c) 0 [expr {$enforce(max) - 1}]] ,]set kickList($c) [lrange $kickList($c) $enforce(max) end]incr len -$enforce(max)} else {set users [join $kickList($c) ,]set len 0}putkick $c $users $reason}}}}}

Just remember you had a little issue with banlist (discussion in here) and will adopt a similar solution to SpiKe's if will be the case.

While given the requested change we could use a faster queue than pushmode, I would honestly stick with it cos this function will be called for instance 6 times if 6 bans have been set in one line. This way the chances are it will also push all the 6 modes in a single line in other channels. Worth a test anyway.

Edit: 1st bug fix (link).

Statistics: Posted by caesar — Fri Jun 17, 2016 10:08 am

enforce bans / kicks on all common channels

2016-06-17T09:15:37-04:00

I tried your version caesar it works fine if user is in common channels as eggbot. Is it possible to set ban anyway on all channels bot sits in even if banned nick isnt there to prevent him from joining and continuing the abuse

Statistics: Posted by simo — Fri Jun 17, 2016 9:15 am

enforce bans / kicks on all common channels

2016-06-17T01:32:50-04:00

Code:

% set elements [list 1 2 3 4 5]1 2 3 4 5% foreach ele $elements { if {$ele == 3} { return } else { puts $ele } }12% foreach ele $elements { if {$ele == 3} { continue } else { puts $ele } }1245

Notice the difference in using return and continue?

You are aware that the && in:

Code:

if {![botisop $c] && [isbotnick $n] && [isop $n $c] && [ishalfop $n $c] && [matchattr [nick2hand $n] $accessFlags $c]} {return}

means if bot is channel operator in channel AND bot is the nick AND nick is channel operator AND nick is halfop AND nick's user matches the global|channel flags you said THEN return. You should use || that means OR not && that means AND. For example:

Code:

% foreach ele $elements { if {$ele == 3 && $ele == 5} { continue } else { puts $ele } }12345% foreach ele $elements { if {$ele == 3 || $ele == 5} { continue } else { puts $ele } }124

Notice the difference? he wants to exclude ANY of the matching cases, not the case that would match ALL of the tests.

Here's my take on this. Did some limited testing and works fine. I used putkick as it puts multiple names in the same line thus doesn't flood the server with multiple requests to kick a single member per line.

Code:

namespace eval enforceBans {# How many members can be kicked in the same lineset enforce(max) "6"# Define the reason. Notice the %ban that will be replaced with the actual mask.# You can use %nick as well and will also be replaced with the actual name of the user who set the ban.set enforce(reason) "Ban %ban set in %chan matches your host. You are banned!"bind mode - "% +b" [namespace current]::enforceproc enforce {nick uhost hand chan mc ban} {variable enforceforeach c [channels] {if {![botisop $c]} continueforeach n [lreplace [chanlist $c] 0 0] {if {![string match -nocase $ban $n![getchanhost $n $c]]} continueif {[isop $n $c] || [ishalfop $n $c] || [matchattr [nick2hand $n] "fnmo|fnmo" $c]} continuelappend kickList($c) $n}}foreach c [array names kickList] {set len [llength $kickList($c)]if {![string equal -nocase $c $chan]} {pushmode $c +b $ban}while {$len > 0} {if {$len > $enforce(max)} {set users [join [lrange $kickList($c) 0 [expr {$enforce(max) - 1}]] ,]set kickList($c) [lrange $kickList($c) $enforce(max) end]incr len - $enforce(max)} else {set users [join $kickList($c) ,]set len 0}set reason [string map [list "%chan" $chan "%ban" $ban "%nick" $nick] $enforce(reason)]putkick $c $users $reason}}}}

When setting X bans on the same line the bot will trigger a bind mode - "% +b" proc X times for each ban mask, but will trigger a mode - "% -b" proc only once per 6 bans (or whatever is the max amount of bans per line the server you are connected allows) when removing bans. Honestly I fail to understand the logic behind this difference.

Statistics: Posted by caesar — Fri Jun 17, 2016 1:32 am

enforce bans / kicks on all common channels

2016-06-16T21:40:59-04:00

Instead of {return} should be continue

What's the point to iterate all channels and kick the user matching the ban mask, when the ban was placed just on a single channel? You know the user can return on the channel he/she was kicked but not banned, right?

Also, you know about the enforcebans channel setting that is doing exactly what you wanted (kick people who match channel bans)?

I always use return, just out of habit and the way I code.

As for enforcebans, which a lot of the core is ok, some is not, so for things like this I try to override the core calls. For example, using bind flud to process flood-chan and other specific events (like this script here). Easier to manage and modify as wanted.

Statistics: Posted by Get_A_Fix — Thu Jun 16, 2016 9:40 pm

enforce bans / kicks on all common channels

2016-06-20T07:24:57-04:00

Sure. I didn't know that's what you wanted. There are two ways to approach this, adding a server ban (so your @ and non-bot Ops can remove the ban), or an internal ban (which has to be manually removed from the bot).
For the internal ban, read the ~/eggdrop/doc/tcl-commands.doc form on newchanban or newban. For this example, I'll be using the server side ban.

Code:

# In your code you can: set banmask [make:banmask $uhost $nick]# and then use the ...: putquick "MODE $chan +b $banmask"# BAN Types are given below;# 1 - *!*@some.domain.com # 2 - *!*@*.domain.com# 3 - *!*ident@some.domain.com# 4 - *!*ident@*.domain.com# 5 - *!*ident*@some.domain.com# 6 - *nick*!*@*.domain.com# 7 - *nick*!*@some.domain.com# 8 - nick!ident@some.domain.com# 9 - nick!ident@*.host.comset bantype 1# Set the access flags needed to be exemptset accessFlags fnmo|fnmo## Code Base ##bind mode - "* +b" enforcebansproc enforcebans {nick uhost hand chan mc ban} { global accessFlags foreach n [chanlist $chan] {  foreach c [channels] {   if {[string match -nocase $ban $n![getchanhost $n $c]]} {    if {![botisop $c] || [isbotnick $n] || [isop $n $c] || [ishalfop $n $c] || [matchattr [nick2hand $n] $accessFlags $c]} {return}    set banmask [make:banmask $uhost $nick]    putquick "MODE $c +b $banmask"    putquick "KICK $c $n :Ban $ban matches: $n (You Are Banned)"   }  } }}proc make:banmask {uhost nick} { global bantype  switch -- $bantype {   1 { set banmask "*!*@[lindex [split $uhost @] 1]" }   2 { set banmask "*!*@[lindex [split [maskhost $uhost] "@"] 1]" }   3 { set banmask "*!*$uhost" }   4 { set banmask "*!*[lindex [split [maskhost $uhost] "!"] 1]" }   5 { set banmask "*!*[lindex [split $uhost "@"] 0]*@[lindex [split $uhost "@"] 1]" }   6 { set banmask "*$nick*!*@[lindex [split [maskhost $uhost] "@"] 1]" }   7 { set banmask "*$nick*!*@[lindex [split $uhost "@"] 1]" }   8 { set banmask "$nick![lindex [split $uhost "@"] 0]@[lindex [split $uhost @] 1]" }   9 { set banmask "$nick![lindex [split $uhost "@"] 0]@[lindex [split [maskhost $uhost] "@"] 1]" }   default { set banmask "*!*@[lindex [split $uhost @] 1]" }   return $banmask  }}

Note: Code edited to reflect what caesar explained.

Statistics: Posted by Get_A_Fix — Thu Jun 16, 2016 9:38 pm

enforce bans / kicks on all common channels

2016-06-16T10:45:11-04:00

would it possible to also have it set ban on all channels bot is sitting in as well Get_A_Fix ?

Code:

bind mode - "* +b" enforcebansset accessFlags fnmo|fnmoproc enforcebans {nick uhost hand chan mc ban} { global accessFlags foreach n [chanlist $chan] {  foreach c [channels] {   if {[string match -nocase $ban $n![getchanhost $n $c]]} {    if {![botisop $c] && [isbotnick $n] && [isop $n $c] && [ishalfop $n $c] && [matchattr [nick2hand $n] $accessFlags $c]} {return}    putquick "KICK $c $n :Ban $ban matches: $n (You Are Banned)"   }  } }}

Statistics: Posted by simo — Thu Jun 16, 2016 10:45 am

enforce bans / kicks on all common channels

2016-06-16T00:52:50-04:00

Instead of {return} should be continue

What's the point to iterate all channels and kick the user matching the ban mask, when the ban was placed just on a single channel? You know the user can return on the channel he/she was kicked but not banned, right?

Also, you know about the enforcebans channel setting that is doing exactly what you wanted (kick people who match channel bans)?

Statistics: Posted by caesar — Thu Jun 16, 2016 12:52 am