egghelp/eggheads community

Lindex help

2015-08-06T11:31:18-04:00

Hi using similar code to the previous post in trying to capture this line via the regex method and wondered if you guys could assist me plz i think its the regex line thts wrong anyhow heres my first draught

Code:

proc rls:spec {nick host hand chan arg} {   global chann_ sitebot_ ftp_     if { $chan == $chann_(spam) && $nick == $sitebot_(nick) } {         set pattern {([^>]+)? > Codec: ([^>]+)? FPS: ([^fps][0-9]+)? Res:([0-9]+)? AR: ([0-9]+)? > Audio: ([^>]+)? BitRate: ([^kbps][0-9]+)? Freq: ([^KHz][0-9]+)? Channels: ([^ch][0-9]+)?}         if { [regexp $pattern $arg match rlsname videocodec fps ar audiocodec audiobitrate audiofreq channels] } {      if {[string trim $videocodec] == ""} { set videocodec "-" }         if {[string trim $fps] == ""} { set fps "-" }         if {[string trim $ar] == ""} { set ar "-" }         if {[string trim $audiocodec] == ""} { set audiocodec "-" }         if {[string trim $audiobitrate] == ""} { set audiobitrate "-" }         if {[string trim $audiofreq] == ""} { set audiofreq "-" }         if {[string trim $channels] == ""} { set channels "-" }         if { $rlsname == "" } {               putquick "PRIVMSG $chann_(add) :\0034 Error!! Release Name Empty\003"               return 0            }         } else {            putserv "PRIVMSG $chann_(add) :$arg didn't match"            return 0         }            putquick "PRIVMSG $chann_(add) :!addvideoinfo $rlsname $videocodec $fps $ar $audiocodec $audiobitrate $audiofreq $channels"            putquick "PRIVMSG $chann_(add) :\[\0035SAMPLE-SPEC\003\] $rlsname"   }}

and this is the line im trying to capture

Code:

SPEC > At.Midnight.2015.08.05.HDTV.x264-TASTETV > Codec: AVC FPS: 29.970fps Res: 720x404 AR: 16:9 > Audio: AAC BitRate: 124Kbps Freq: 48.0KHz Channels: 2ch

Statistics: Posted by COBRa — Thu Aug 06, 2015 11:31 am

Lindex help

2014-07-08T13:23:53-04:00

Many thanks to all that helped me sort the code out it now works fine

Statistics: Posted by COBRa — Tue Jul 08, 2014 1:23 pm

Lindex help

2014-07-03T13:06:27-04:00

Sorry for the late answer.

Since you are using the "pub" binding, "id3" is considered the command, and thus removed from the text-argument ($arg). Thus, the regular expression needs to be adjusted accordingly:

Code:

set pattern {([^>]+)? > ([^>]+)? from ([0-9]+)? at ([0-9]+)? Hz}

Statistics: Posted by nml375 — Thu Jul 03, 2014 1:06 pm

Lindex help

2014-07-03T12:15:13-04:00

The !addid3c is announced in a specific channel and another bot which is linked adds the info into a database so yes its part of this code

so when the line !addid3c some_release some_genre etc hits the channel another bot picks up the !addid3c line and enter it into the database

the error im getting is this

Deine_Freunde-Heile_Welt-DE-2014-CARDiNALS > Pop from 2014 at 44100 Hz didn't match

Statistics: Posted by COBRa — Thu Jul 03, 2014 12:15 pm

Lindex help

2014-07-02T06:42:07-04:00

Ok, so the "!addid3c" command has no relation with this part of the script.

Can you give me an example of non-matching command ? (paste the complete irc log without any modification).

Statistics: Posted by CrazyCat — Wed Jul 02, 2014 6:42 am

Lindex help

2014-07-01T12:44:49-04:00

the bind is this

Code:

bind pub - iD3 rls:id3

Statistics: Posted by COBRa — Tue Jul 01, 2014 12:44 pm

Lindex help

2014-06-30T06:01:43-04:00

Here's a small correction : added a debug advert when regexp didn't matches.

Code:

proc rls:id3 {nick host hand chan arg} {   global chann_ sitebot_ ftp_    if { $chan == $chann_(spam) && $nick == $sitebot_(nick) } {         set pattern {iD3 > ([^>]+)? > ([^>]+)? from ([0-9]+)? at ([0-9]+)? Hz}         if { [regexp $pattern $arg match rlsname genre year sampling] } {            if {[string trim $genre] == ""} { set genre "-" }            if {[string trim $year] == ""} { set year "-" }            if {[string trim $sampling] == ""} { set sampling "-" }            if { $rlsname == "" } {               putquick "PRIVMSG $chann_(echo) :\0034 Error!! Release Name Empty\003"               return 0            }         } else {            putserv "PRIVMSG $chann_(echo) :$arg didn't match"            return 0         }         putquick  "PRIVMSG $chann_(echo) :!addid3c $rlsname $genre $year $sampling"    }}

I noticed something strange in your code:

Code:

putquick  "PRIVMSG $chann_(echo) :!addid3c $rlsname $genre $year $sampling"

Is !addid3c the bind for the rls:id3 proc ? If it is, the "command line" is not what is expected in the regexp.

If you really want help, I think you have to give us your complete code and not just bits of it.

Statistics: Posted by CrazyCat — Mon Jun 30, 2014 6:01 am

Lindex help

2014-06-27T12:41:16-04:00

I've checked the pattern and it seems ok i dont understand where the error is coming from is it the code ive posted plz ?

Statistics: Posted by COBRa — Fri Jun 27, 2014 12:41 pm

Lindex help

2014-06-27T11:47:42-04:00

Hello,
Worth keeping in mind, when it comes to regexp and regular expressions:
The variables listed in the command line, will only be set if there is a match for the pattern within the text string. The regexp command will return 1 if a match was found, otherwise 0.

Statistics: Posted by nml375 — Fri Jun 27, 2014 11:47 am

Lindex help

2014-06-27T10:21:22-04:00

thx bud added the code but im getting an error

[16:14:13] Tcl error [cmdencryptedincominghandler]: can't read "genre": no such variable

this is my code

Code:

proc rls:id3 {nick host hand chan arg} {global chann_ sitebot_ ftp_    if { $chan == $chann_(spam) && $nick == $sitebot_(nick) } {                 set pattern {iD3 > ([^>]+)? > ([^>]+)? from ([0-9]+)? at ([0-9]+)? Hz}                  regexp $pattern $arg match rlsname genre year sampling                  if {[string trim $genre] == ""} { set genre "-" } if {[string trim $year] == ""} { set year "-" } if {[string trim $sampling] == ""} { set sampling "-" }                       if { $rlsname == "" } {  putquick "PRIVMSG $chann_(echo) :\0034 Error!! Release Name Empty\003"  return    } putquick  "PRIVMSG $chann_(echo) :!addid3c $rlsname $genre $year $sampling"          }    }

Statistics: Posted by COBRa — Fri Jun 27, 2014 10:21 am

Lindex help

2014-06-27T08:46:09-04:00

Just a small question before answering you: even if a field is blank, is it mentionned, like:

Code:

iD3 > Express_Viviana_Ft._Natt_-_Feel_The_Soul-(HC0045)-WEB-2014-SRG > from 2014 at 44100 Hz

I hope it is, and you have to change the pattern into:

Code:

set pattern {iD3 > ([^>]+)? > ([^>]+)? from ([0-9]+)? at ([0-9]+)? Hz}

And to set an empty field to "-", just do:

Code:

if {[string trim $genre]==""]} { set genre "-" }

Statistics: Posted by CrazyCat — Fri Jun 27, 2014 8:46 am

Lindex help

2014-06-27T03:48:56-04:00

Ok many thx I understand just one last question if one of the fields is blank ie genre for example how could I show it as a - for example

Statistics: Posted by COBRa — Fri Jun 27, 2014 3:48 am

Lindex help

2014-06-27T03:39:48-04:00

...

the regexp line assigns the values to rlsname, genre, year and sampling.
It's an alternative to the affectations using the lindex. It replaces your 4-lines code and do exactly the same.

Statistics: Posted by CrazyCat — Fri Jun 27, 2014 3:39 am

Lindex help

2014-06-27T00:00:49-04:00

So I could use something like

Code:

$rlsname=""             $genre=""

As I'm not sure

Statistics: Posted by COBRa — Fri Jun 27, 2014 12:00 am

Lindex help

2014-06-26T15:02:15-04:00

If you use the code posted by nml375, all variables are setted.
You just have to use $rlsname, $genre, ..., without any set.

Have a look on http://wiki.tcl.tk/986

Statistics: Posted by CrazyCat — Thu Jun 26, 2014 3:02 pm