egghelp/eggheads community

check from .txt file?

2013-01-30T07:19:19-04:00

Never trust user input, especially when it's not user restricted. How about this?

Code:

bind pub - !check checkproc check {nick uhost hand chan text} {set what [join [lrange $text 0 end]]set fo [open "scripts/filename.txt" r]set data [split [read $fo] "\n"]close $foif {[lsearch -glob $data $what]} {puthelp "PRIVMSG $chan :'$what' is in the file!"} else {puthelp "PRIVMSG $chan :Text is not found.."   }}

PS: supports wildcards.

Statistics: Posted by caesar — Wed Jan 30, 2013 7:19 am

check from .txt file?

2013-01-29T16:59:49-04:00

Well i make the code as i know if i encouter problems in the future with codes i write then i modify the code.. but any modifications/improvment of my code is welcomed im always learning.. i also never used 'break'

Statistics: Posted by Madalin — Tue Jan 29, 2013 4:59 pm

check from .txt file?

2013-01-29T16:55:20-04:00

There's no good reason to make the local process variable 'found' into a global variable.
It's never reused and forces us to unbind it to run the proc again.

Also 'arg' is not a list and shouldn't be handled like this... [join [lrange $arg 0 end]]

I might suggest something more like...

Code:

bind pub - !check check proc check {nick uhost hand chan arg} {    set fd [open scripts/filename.txt r]    set cont [read $fd]    close $fd    foreach line [split $cont "\n"] {       if {[string match -nocase "*$arg*" $line]} {          putserv "PRIVMSG $chan :'$arg' is in the file!"          set found 1  ;  break      }    }    if {![info exists found]} {       putserv "PRIVMSG $chan :Text is not found.."    } }

Statistics: Posted by SpiKe^^ — Tue Jan 29, 2013 4:55 pm

check from .txt file?

2013-01-29T15:04:32-04:00

Try this

Code:

bind pub - !check checkproc check {nick uhost hand chan arg} {global foundunset -nocomplain found 0set what [join [lrange $arg 0 end]]set fd [open filename r]set cont [read $fd]close $fdforeach line [split $cont "\n"] {if {[string match -nocase "*$what*" $line]} {putserv "PRIVMSG $chan :'$what' is in the file!"set found 1}}if {![info exists found]} {putserv "PRIVMSG $chan :Text is not found.."}}

Statistics: Posted by Madalin — Tue Jan 29, 2013 3:04 pm

check from .txt file?

2012-04-23T09:25:08-04:00

Code:

bind pub - !check checkproc check {nick uhost hand chan text} {  set t [open scripts/filename.txt r]  set line [gets $t]  if {[string match -nocase "*$text*" $line]} {    putquick "privmsg $chan $text is in the file!"    close $t    } else {    putquick "privmsg $chan $text isn't in the file!"    close $t  }}

Isn't workin', how can we check a text if it is in the file? Like that,

!check Is it a problem?
Is it a problem? < is in the file !
!check Is THAT a problem?
Is THAT a problem? < is not in the file !

Thx.

Statistics: Posted by Regex — Mon Apr 23, 2012 9:25 am