egghelp/eggheads community

Bogustrivia issues with Eggdrop 1.6.21

2013-11-15T00:39:24-04:00

Yes I did it on two eggdrops following step by step working right for some minutes and then the bot continue with that problem, both eggdrops

Statistics: Posted by h0zk4r — Fri Nov 15, 2013 12:39 am

Bogustrivia issues with Eggdrop 1.6.21

2013-11-14T23:08:31-04:00

That's still the eggdrop 1.6.21 timers bug showing itself.

I have to think you did not apply the patch correctly, or did not recompile the eggdrop after patching the source.

Statistics: Posted by SpiKe^^ — Thu Nov 14, 2013 11:08 pm

problems with bogus trivia

2013-11-14T22:00:08-04:00

hello anyone have the solution to this:

[01:03:28] Tcl error in script for 'timer966':
[01:03:28] can't use empty string as operand of "/"
[01:04:07] Tcl error in script for 'timer978':
[01:04:07] can't use empty string as operand of "/"
[01:04:38] Tcl error in script for 'timer988':

I tryed the patch and everything but it continue the same error, can you help me please???? and sorry about my english jeje I am from Perú

Statistics: Posted by h0zk4r — Thu Nov 14, 2013 10:00 pm

Bogustrivia issues with Eggdrop 1.6.21

2013-07-07T16:45:03-04:00

Thanks willyw

Statistics: Posted by SpiKe^^ — Sun Jul 07, 2013 4:45 pm

Bogustrivia issues with Eggdrop 1.6.21

2013-07-07T16:23:16-04:00

Another place to get instructions on how to apply the patch:

http://eggwiki.org/Bugs/Timers

Statistics: Posted by willyw — Sun Jul 07, 2013 4:23 pm

Bogustrivia issues with Eggdrop 1.6.21

2012-07-06T00:11:17-04:00

There is now an official Eggdrop patch to allow BogusTrivia to run correctly on Eggdrop version 1.6.21 !

If you want to run BogusTrivia on the 1.6.21 Eggdrop, Please download and apply the "timerworkaround.patch.gz by thommey" from here: http://www.egghelp.org/files.htm#patches

Statistics: Posted by SpiKe^^ — Fri Jul 06, 2012 12:11 am

Bogustrivia issues with Eggdrop 1.6.21

2012-05-08T09:55:10-04:00

Everything has worked smoothly for several days. The posted fix works perfect. I will be posting this fix on mytclscripts.com for any others who may want to use the 1.6.21 eggdrop.

Hopefully the eggdrop team will address the issue in the form of a patch or re-release.

Thanks for all the help you provided to track down this bug and apply a workaround.

Statistics: Posted by starr — Tue May 08, 2012 9:55 am

Bogustrivia issues with Eggdrop 1.6.21

2012-05-06T11:40:43-04:00

I have edited the correct file and compiled the 1.6.21 bot. Loaded Bogustrivia and so far seems to be the fix. I'll continue to test for the next few days and will keep you updated.

Thank you both for your input. Maybe this can be resolved with eggdrop.

Statistics: Posted by starr — Sun May 06, 2012 11:40 am

Bogustrivia issues with Eggdrop 1.6.21

2012-05-06T10:19:13-04:00

Starr,
To apply the fix suggested by thommey, you'd have to edit the file tcl.c in the eggdrop source and recompile. If you are not familiar with patch-files or how to apply them,this fix is easy enough to apply manually. At line 614 (give or take a few lines), you'll find a line saying

Code:

do_tcl_async(context, script, bgtclcallback);

Change that into this

Code:

do_tcl_sync(context, script, bgtclcallback, 0);

Then recompile your eggdrop in the usual manner

Statistics: Posted by nml375 — Sun May 06, 2012 10:19 am

Bogustrivia issues with Eggdrop 1.6.21

2012-05-06T09:58:07-04:00

I'd really like to try this fix, however I do not write code I'm more of the tester in this team.

I have no idea where to enter this fix in the main.c file. If you could give me a better idea of where to put it and what if any lines will be replaced I'd be glad to test this workaround.

Statistics: Posted by starr — Sun May 06, 2012 9:58 am

Bogustrivia issues with Eggdrop 1.6.21

2012-05-06T07:52:07-04:00

Great job at tracking down the bug. What nml375 said is exactly what's happening.

I'd propose this workaround (which basically reverts the change introducing the bug):

Code:

diff -urN eggdrop1.6.21/src/tcl.c eggdrop1.6.21.timerworkaround/src/tcl.c--- eggdrop1.6.21/src/tcl.c 2012-05-06 13:19:13.209758240 +0200+++ eggdrop1.6.21.timerworkaround/src/tcl.c 2012-05-06 13:23:36.985752474 +0200@@ -611,7 +611,7 @@  * where it's safe to recurse eventually (vwait/update).  */ void do_tcl(char *context, char *script) {-  do_tcl_async(context, script, bgtclcallback);+  do_tcl_sync(context, script, bgtclcallback, 0); }  /* Evaluates Tcl code.

You can change that one line manually or use it as a patch file before compiling.

(The changes introducing the bug were made to fix another bug that was fixed by other means later, so there should be no downside to using this)

Statistics: Posted by thommey — Sun May 06, 2012 7:52 am

Bogustrivia issues with Eggdrop 1.6.21

2012-05-05T16:54:32-04:00

Was a little bit bored, and dug further..
The issue lies with how timers use the new event notifier. Much simplified, timers (and utimers) are removed as their payload (the tcl code) is added to the event-list, not when the payload is finally executed. Between these two points in code execution, all checks for incoming network traffic is done (which in the end results in pubm bindings among others being checked and triggered).

A quick-fix could be to simply move the call_hook(SECONDLY) call to the end of mainloop, though I havn't investigated this solution that througout yet (might just cause other, more sever problems), so be cautious if you attempt this bugfix! Also, this fix will not allow multiple timers triggering at the same time to see other timers expiring at the same time, regardless of order.

Around main.c:743 you'll find these five lines of code:

Code:

  /* Once a second */  if (now != then) {    call_hook(HOOK_SECONDLY);    then = now;  }

They should be moved to the end of the same function, just before we parse the event-list at arund main.c:908

Code:

  /* Once a second */  if (now != then) {    call_hook(HOOK_SECONDLY);    then = now;  }#ifdef USE_TCL_EVENTS  if (!eggbusy) {/* Process all pending tcl events */#  ifdef REPLACE_NOTIFIER    tclevent_t *e;    if (Tcl_ServiceAll())      tclbusy = 1;    while (tclevents) {      e = tclevents;      tclevents = tclevents->next;      tclbusy = 1;      do_tcl_sync(e->context, e->script, e->callback, 1);      nfree(e);    }#  else    while (Tcl_DoOneEvent(TCL_DONT_WAIT | TCL_ALL_EVENTS))      tclbusy = 1;#  endif /* REPLACE_NOTIFIER */#endif   /* USE_TCL_EVENTS   */  }  return (eggbusy || tclbusy);}

Statistics: Posted by nml375 — Sat May 05, 2012 4:54 pm

Bogustrivia issues with Eggdrop 1.6.21

2012-05-05T04:18:03-04:00

Apart from the TChkDed bug, I'm not dismissing changes in 1.6.21 as the source. I'm sorry if I made you believe otherwise.
That said, I must admit I've read these posts as an issue with the utimer command, not utimers, My bad.

Statistics: Posted by nml375 — Sat May 05, 2012 4:18 am

Bogustrivia issues with Eggdrop 1.6.21

2012-05-04T20:20:02-04:00

Dismissing the bug as not an Eggdrop bug, does not fix the Eggdrop bug. All this same code is very stable on all versions of Eggdrop 1.6.15 - 1.6.20 , nothing at all has changed with the BogusTrivia code.

The issue comes down the the [utimers] command, and the fact you can no longer rely on its return being a complete list of running timers.

So, when someone gets an answer, Bogus needs to kill the running game timer, in order to start the timer to the next question. Bogus asks for a utimers list to see if the timer is still running, but occasionally the utimers list is empty and Bogus doesn't kill the timer because Eggdrop says it's not still running. BogusTrivia then sets the new timer to call the next question. Then the original game timer that Eggdrop assured me was not running, lands shortly after that, and we have a double game timer loop.

No script with timers can stand for that. After the double timer loop starts, the list of possible errors is huge. It's not a Bogus issue, Eggdrop did not return the timer in the utimers list, and Bogus won't kill a timer that's not running, that would return an error. But the timer clearly is running because just after i'm told it doesn't exist, the darn thing lands, and the whole thing falls apart.

We can all deny that it's an Eggdrop bug, but that wont fix the current Eggdrop issue with the utimers command.

SpiKe^^
mytclscripts.com

Statistics: Posted by SpiKe^^ — Fri May 04, 2012 8:20 pm

Bogustrivia issues with Eggdrop 1.6.21

2012-05-01T15:48:03-04:00

I did some digging and testing of the code, since the actual timer-code hasn't been touched much since 1.6.20...

What I've noticed, is that on some occasions timers for TShoTrv2 and TShoTriv are started multiple times, breaking the scripts state-machine. All the different errors seen on the console are results of the environment no longer being what the script expected.

In defense of speechles, the TChkDed-patch is a perfectly valid bugfix. Also, that is not a "timer-bug", it's merely faulty code called by a timer...
As for the other fix, can't tell there as I really can't follow your code in it's current layout.

Statistics: Posted by nml375 — Tue May 01, 2012 3:48 pm