egghelp/eggheads community

How can i remove an empty line within a foreach

2010-09-17T02:41:50-04:00

Thanks @all for the great help

Statistics: Posted by Elfriede — Fri Sep 17, 2010 2:41 am

How can i remove an empty line within a foreach

2010-09-15T15:41:10-04:00

A few comments on the posted codes:
Regular expressions are flexible, but far slower than other kinds of matching.
Using llength on a string is a bad idea. In worst case, llength might throw an error due to "improper list", which will immediately terminate the proc.
Same goes with using lindex on strings...

Both $text and $line are strings, not lists. Use the split-command to get a valid list, if you intend to use list operations.

Statistics: Posted by nml375 — Wed Sep 15, 2010 3:41 pm

How can i remove an empty line within a foreach

2010-09-15T16:20:09-04:00

Code:

proc some:proc {nick host handle channel text} {   set stext [split $text]   set url [lindex $stext 0]   set result [lindex $stext 1]   set token [::http::geturl $url]   set content [::http::data $token]   ::http::cleanup $token   foreach line [split $content \n] {      set output [string trim [lindex [split $line] 0]]      if {[string length $output]} {         sendmsg $channel "$result $output"      }   }}

Statistics: Posted by speechles — Tue Sep 14, 2010 12:09 pm

How can i remove an empty line within a foreach

2010-09-14T11:33:41-04:00

I'd want to test this myself to verify, but that method should be fine, as its checking to see if each line has something. Here's a few more ways I think would work, starting at that foreach loop:

With a regex:

Code:

   foreach line [split $content \n] {      if {![regexp {\s+} $line]} {                   sendmsg $channel "$result $output"      }   }}

With llength:

Code:

   foreach line [split $content \n] {      if {[llength $line] != 0} {                   sendmsg $channel "$result $output"      }   }}

Would you mind posting the output of your original as well as how to use it? Also, let us know how those work for you.

Statistics: Posted by Luminous — Tue Sep 14, 2010 11:33 am

Re: How can i remove an empty line within a foreach

2010-09-14T10:57:21-04:00

Code:

proc some:proc {nick host handle channel text} {set url [lindex [split $text] 0]set result [lindex $text 1]set token [::http::geturl $url]set content [::http::data $token]::http::cleanup $tokenforeach line [split $content \n] {set output [lindex $line 0]               if {"$output"!=""} {             sendmsg $channel "$result $output"                  }}}

What happens when you try this?
I can't test it, so I'm curious if this simple change is all that is needed.

Even if this does work ok for you, there very well may be better ways to accomplish it. It will be interesting to see what else is posted here.

Statistics: Posted by willyw — Tue Sep 14, 2010 10:57 am

How can i remove an empty line within a foreach

2010-09-14T08:31:43-04:00

Hi everboy

Im having a small issue and appreciate any help

Code:

proc some:proc {nick host handle channel text} {set url [lindex [split $text] 0]set result [lindex $text 1]set token [::http::geturl $url]set content [::http::data $token]::http::cleanup $tokenforeach line [split $content \n] {set output [lindex $line 0]sendmsg $channel "$result $output"}}

If the lastline is an emptyline (its not always like this) i get $result without $output, as theres nothing to output. How can i drop that last/empty line ?
Thanks!

Statistics: Posted by Elfriede — Tue Sep 14, 2010 8:31 am