egghelp/eggheads community

Trying to get need-op to send message

2002-05-18T15:17:00-04:00

The code is there to prevent the commands from crashing if the channel is removed ..

i.e..

bind join - * blah
proc blah {nick uhost hand chan} {
channel remove $chan
}

use to make the bot crash ..

I'll look at fixing need-* (need-op seems to work) sometime soon.

Statistics: Posted by guppy — Sat May 18, 2002 3:17 pm

Trying to get need-op to send message

2002-05-17T23:00:00-04:00

You're right, I didn't investigate the differences between findchan and findchan_by_dname precisely. I made up my mind based on the comment in the proc from which I got that snip of code:

/* We use dname because name is first set on JOIN and we might not
* have joined the channel yet.
*/

So, if findchan_by_dname was used for a reason up above, stands to reason it should be used again since the bot is still in the same state. And again, this code is completely unnecessary since chan is already set and verified:

chan = findchan_by_dname(chname);
if (chan) {

} else
putlog(LOG_JOIN, chname, IRC_BADCHANKEY, chname);
return 0;
}

If the code mentioned in my first post is removed need-key et al work again. Whether or not findchan would work as well as findchan_by_dname I didn't test, but at the very least, findchan is used improperly since the variable chname is set with "!channel" for use by findchan_by_dname only.

It's all moot really, the code shouldn't even exist there.

-stu.

Statistics: Posted by Guest — Fri May 17, 2002 11:00 pm

Trying to get need-op to send message

2002-05-17T21:38:00-04:00

Do you even know what findchan and findchan_by_dname do? Sure doesn't sound like you do -- findchan doesn't care if the bot is on or off the channel, it does care though if the bot knows about the channel. That type of code was added to prevent the bot from crashing when people remove a channel via a bind.

Statistics: Posted by guppy — Fri May 17, 2002 9:38 pm

Trying to get need-op to send message

2002-05-17T18:54:00-04:00

Hi,

Most of the need-* functions (key, unban, limit, invite) are broken in 1.6.10, there's some new code inserted in them:

from src/mod/irc.mod/chan.c:

chan = findchan(chname);
if (!chan)
return 0;

This code has been added right before the tcl in the need-* settings is executed. First of all, chan is already correctly set, so this code is totally unnecessary. Secondly, it's also wrong, since the bot is not in the channel when it's requesting the key or limit. Thus findchan won't see it, findchan_by_dname would have to be used.

Also, need-op seems to function normally.

-stu.

Statistics: Posted by Guest — Fri May 17, 2002 6:54 pm

Trying to get need-op to send message

2002-05-16T04:13:00-04:00

Could be, only thing I changed was that I used puthelp instead of putserv.
But putserv works just fine too.

_________________
MaSsKilla

#eggdrop
Undernet

[ This Message was edited by: masskilla on 2002-05-16 02:19 ]

Statistics: Posted by masskilla — Thu May 16, 2002 4:13 am

Trying to get need-op to send message

2002-05-15T19:47:00-04:00

hmm, didnt when i last tested. maybe its an os/tcl library specfic problem

Statistics: Posted by Petersen — Wed May 15, 2002 7:47 pm

Trying to get need-op to send message

2002-05-15T18:40:00-04:00

I just tested it in 1.6.10, works fine.

Statistics: Posted by masskilla — Wed May 15, 2002 6:40 pm

Trying to get need-op to send message

2002-05-15T07:00:00-04:00

he's using 1.6.9 or 1.6.10 where someone broke need-op

Statistics: Posted by Petersen — Wed May 15, 2002 7:00 am

Trying to get need-op to send message

2002-05-15T04:02:00-04:00

Hi

Is the bot on that other channel? If not, does the channel have +n mode? If it's so, you can't message it from outside.

Statistics: Posted by masskilla — Wed May 15, 2002 4:02 am

Trying to get need-op to send message

2002-05-15T01:57:00-04:00

I must be lame, I'm trying to get my bot to send a message to another channel when it needs op and it isn't working. I did the following:

.chanset #channel need-op putserv "PRIVMSG #channel2 :!opnow"

I don't get any errors but I never see the !opnow message in #channel2. What the hell am I doing wrong.

Statistics: Posted by Guest — Wed May 15, 2002 1:57 am