egghelp/eggheads community

Help with tcl script

2009-08-10T12:52:44-04:00

well, i didnt say to upload your complete bot of course, i say if u can give me link, or upload the version of that bot u are using

Statistics: Posted by [3-33] — Mon Aug 10, 2009 12:52 pm

Help with tcl script

2009-08-10T12:35:04-04:00

One thing that I thought of, thanks to arfer's mentioning of spaces...
It's not uncommon for clients/extensions to add control characters (such as bold, color, underline, etc) when using nick completion.. In this case, the pub binding will undoubtedly fail, as eggdrop does not strip these prior mask/command matching. If this is the case, your best option would be to use a pubm binding and create a suitable pattern/regular expression, possibly along with the use of the stripcodes command.

Statistics: Posted by nml375 — Mon Aug 10, 2009 12:35 pm

Help with tcl script

2009-08-10T07:53:49-04:00

Sorry but I'm not prepared to upload my complete bot, not that it would necessarily do you any good anyway. I very much doubt if this issue has anything to do with your bot version. If you still believe this to be the case simply compile/install the current version.

I just thought of a possibility. Are you using an IRC client that throws in a spurious space character after typing in part of an onchan nick and using a predefined key (usually tab) for autocompletion? This used to occur with XChat, though I don't know if current versions still do that.

However, it is possible that the script author has included the following otherwise seemingly improper code segment to get rid of any such character :-

Code:

proc pub_dotalkz {nick uhost hand chan rest} {set str [lrange $rest 0 end]

The variable 'rest' is not a list and shouldn't normally be treated as one. Even if it was a list, [lrange $rest 0 end] would return all of it, which sort makes it strange that there would be a need to additionally define 'str'.

There are other parts of the script that I think look rather ugly. For example :-

Code:

if {$nick == $botnick} {    return 0}if {$str == ""} {    putchan $chan "$nick: What? ×åãî íàäî ?"    return 0}

Would look rather better as :-

Code:

if {[isbotnick $nick]} {    return 0}if {[string length $str] == 0} {    putchan $chan "$nick: What? ×åãî íàäî ?"    return 0}

Not that this would excuse the cross-over of string and list manipulation functions, which I have maintained by using 'string length' on the list variable 'str' as returned from the 'lrange' statement.

I'm not saying these corrections and several others in the script would resolve your problem but I am saying that I wouldn't use this script.

Statistics: Posted by arfer — Mon Aug 10, 2009 7:53 am

Help with tcl script

2009-08-10T03:05:20-04:00

Well, if your eggdrop works, and my no, maybe its about what version of eggdrop i have, so would you upload or give me bot like that?
I think the problem can be in the eggdrop, also my bot is not uploaded to a shell, i start it from my machine,from a .bat file..so..

Statistics: Posted by [3-33] — Mon Aug 10, 2009 3:05 am

Help with tcl script

2009-08-09T13:19:55-04:00

It is from the Tcl archive here at www.egghelp.org/tcl.htm

No clue what you mean by my bot but that also is the latest version 1.6.19+ctcpfix

Statistics: Posted by arfer — Sun Aug 09, 2009 1:19 pm

Help with tcl script

2009-08-09T11:35:35-04:00

I downloaded bottalk.tcl from this site. After loading the script and restarting I was able to get my bot to respond to $nick, $nick; $nick: AND $nick alone.

[22:41] <@arfer> Osmosis
[22:41] <@osmosis> arfer: What? ×åãî íàäî ?
[22:41] <@arfer> osmosis
[22:41] <@osmosis> arfer: What? ×åãî íàäî ?
[22:42] <@arfer> osmosis, hello
[22:42] <@osmosis> arfer: Ïèâî åñòü ?
[22:42] <@arfer> Osmosis: hello
[22:42] <@osmosis> arfer: Ñêîê ãîäèêîâ òåáå ?
[22:42] <@arfer> Osmosis; what are you doing?
[22:42] <@osmosis> arfer: hello

I don't have a clue what the original poster did to break it.

Well, can you upload your bot so, i`ll use this new one and that?:D

Statistics: Posted by [3-33] — Sun Aug 09, 2009 11:35 am

Help with tcl script

2009-08-08T17:44:32-04:00

I downloaded bottalk.tcl from this site. After loading the script and restarting I was able to get my bot to respond to $nick, $nick; $nick: AND $nick alone.

[22:41] <@arfer> Osmosis
[22:41] <@osmosis> arfer: What? ×åãî íàäî ?
[22:41] <@arfer> osmosis
[22:41] <@osmosis> arfer: What? ×åãî íàäî ?
[22:42] <@arfer> osmosis, hello
[22:42] <@osmosis> arfer: Ïèâî åñòü ?
[22:42] <@arfer> Osmosis: hello
[22:42] <@osmosis> arfer: Ñêîê ãîäèêîâ òåáå ?
[22:42] <@arfer> Osmosis; what are you doing?
[22:42] <@osmosis> arfer: hello

I don't have a clue what the original poster did to break it.

Statistics: Posted by arfer — Sat Aug 08, 2009 5:44 pm

Help with tcl script

2009-08-08T17:06:07-04:00

However, it would be fair to say that none of us have managed to address your problem. We cannot see from what you have posted why $nick, $nick; and $nick: should work but not $nick alone. I doubt that it is your eggdrop, though it could be something in the script that we are unaware of.

Code:

proc pub_dotalkz {nick uhost hand chan rest} {  global botnick  global TalkzStrArray  global TalkzChanArray  global ignore_words  global bad_nicks  set str [lrange $rest 0 end]  if {[lsearch [join $TalkzChanArray] $chan] == -1} { return 0 }    if {$nick == $botnick} {    return 0  }  if {$str == ""} {    putchan $chan "$nick: euh ... quoi ?"    return 0  }  foreach i $bad_nicks {   if {[string match [string tolower $nick] [string tolower $i]]} {     return 0   }  }  foreach i $ignore_words {    foreach j [join $rest] {      if {[string match [string tolower $j] [string tolower $i]]} {        return 0      }    }  }   set nrword [rand [llength $str]]  set nword [lrange $str $nrword $nrword]  set ntalk [lsearch -regexp $TalkzStrArray ".*[FixStrReg $nword].*"]  set n [rand 100]  set m [rand 400]    # si le nom du bot est dans la phrase, on rï¿½pond en indiquant le nom de la personne  # qui nous parle  set tt [lsearch -regexp $str ".*$botnick.*"]  if {$tt != -1} {   if { ($ntalk > 0) && ([rand 10] > 5) } {    set dit [lindex $TalkzStrArray $ntalk]    while {[lsearch -regexp $dit ".*$botnick.*"] != -1} {      regsub -all "$botnick" $dit "[lindex [chanlist $chan] [rand [llength [chanlist $chan]]]]" dit    }    putchan $chan "$nick: $dit"   } else {    set dit [lindex $TalkzStrArray [expr [rand [llength $TalkzStrArray]]]]    while {[lsearch -regexp $dit ".*$botnick.*"] != -1} {      regsub -all "$botnick" $dit "[lindex [chanlist $chan] [rand [llength [chanlist $chan]]]]" dit    }    putchan $chan "$nick: $dit"   }  # sinon on dit une phrase quelque fois, juste comme ï¿½a  } else {   if {$n > $m} {    set dit [lindex $TalkzStrArray [expr [rand [llength $TalkzStrArray]]]]    while {[lsearch -regexp $dit ".*$botnick.*"] != -1} {      regsub -all "$botnick" $dit "[lindex [chanlist $chan] [rand [llength [chanlist $chan]]]]" dit    }    putchan $chan "$dit"   }  }  set qui [string trimright [lindex $str 0] :]  if {($qui != $botnick) && ([onchan $qui $chan])} {    set str [lrange $str 1 end]    if {[lindex $str 0] == ":"} { set str [lrange 1 end] }    lappend TalkzStrArray [FixStr $str]  } else {    lappend TalkzStrArray [FixStr $str]  }}

This should now shed some light on what is going on.

Statistics: Posted by speechles — Sat Aug 08, 2009 5:06 pm

Help with tcl script

2009-08-08T15:56:58-04:00

I'm sorry [3-33] but if you have been reading this thread, then you would know that using $botnick in a bind (which executes before the bot comes online) will probably not work. I was wrong.

My little test script was manually loaded via a partyline tcl command AFTER the bot was online.

However, it would be fair to say that none of us have managed to address your problem. We cannot see from what you have posted why $nick, $nick; and $nick: should work but not $nick alone. I doubt that it is your eggdrop, though it could be something in the script that we are unaware of.

Statistics: Posted by arfer — Sat Aug 08, 2009 3:56 pm

Help with tcl script

2009-08-08T15:52:37-04:00

The problem must be elsewhere in the script you have downloaded. In order to test, I made the following very simple script.
Code:
bind PUB - $botnick pub_dotalkzproc pub_dotalkz {nick uhost hand chan text} {    putserv "PRIVMSG $chan :$nick, what do you want"    return 0}
This is the channel output :-

[15:11] <@arfer> osmosis hello
[15:11] <@osmosis> arfer, what do you want
[15:11] <@arfer> Osmosis hello
[15:11] <@osmosis> arfer, what do you want

I`v test this and it wasnt work:)

Maybe its something with my eggdrop ...

anyway this script i am using:

Code:

http://www.egghelp.org/cgi-bin/tcl_archive.tcl?mode=download&id=853

Statistics: Posted by [3-33] — Sat Aug 08, 2009 3:52 pm

Help with tcl script

2009-08-08T15:25:36-04:00

This should work. A little simpler.

Code:

bind PUBM - * pubm_checktalkzproc pubm_checktalkz {nick uhost hand chan text} {    global botnick    if {[regexp -nocase -- [subst -nocommands {^$botnick[,;:]?}] $text]} {        set output [join [lrange [split $text] 1 end]]        pub_dotalkz $nick $uhost $hand $chan $output    }    return 0}

Statistics: Posted by arfer — Sat Aug 08, 2009 3:25 pm

Help with tcl script

2009-08-08T13:31:27-04:00

There's no risk of double evaluation with regsub, the exp argument will never be passed to a second interpreter. A common practise with any regular expression (in tcl), is to encapsulate them with {} rather than "", since they specifically make use of [] as an integral part (same would apply to some glob-style pattern/matching as well, although it's not as common).

However, doing something like this:

Code:

set tmp [list content]utimer 1 [lindex $tmp 0]

does not protect against double evaluation, as this would be identical to this:

Code:

set tmp contentutimer 1 $tmp##or simply:utimer 1 content

Statistics: Posted by nml375 — Sat Aug 08, 2009 1:31 pm

Help with tcl script

2009-08-08T13:23:04-04:00

speechles,
wouldn't it be better to use ${::botnick} than ${::nick}?

Also, mind if I ask why you create $test as a single-item list, as you only access it using "lindex $test 0" all throughout the script anyway?

Yep, your 100% correct. $::botnick will cover both $::nick/$::altnick. Meaning using just $::nick will NOT cover when the bot is using it's alternate nickname, but $::botnick will.

And about the

/[lindex] it's because of the [regsub] used to remove the botnick and char used to seperate it from the text. This could cause double evaluation and if the bot's nickname has special characters like [die] the bot may just decide to die. List is a cheap way to escape any potential issues. This is just a precaution I'm not even sure is needed.

Statistics: Posted by speechles — Sat Aug 08, 2009 1:23 pm

Help with tcl script

2009-08-08T13:15:18-04:00

speechles,
wouldn't it be better to use ${::botnick} than ${::nick}?

Also, mind if I ask why you create $test as a single-item list, as you only access it using "lindex $test 0" all throughout the script anyway?

Statistics: Posted by nml375 — Sat Aug 08, 2009 1:15 pm

Help with tcl script

2009-08-08T13:21:09-04:00

Code:

variable nickchars " :,;"bind pubm - * pub_shouldwetalkproc pub_shouldwetalk {nick uhost hand chan text} {   foreach entry $::nickchars {      set test [list "${::botnick}${entry}"]      if {[string match "[lindex $test 0]*" $text]} {         regsub "[lindex $test 0]" $text "" output         pub_dotalkz $nick $uhost $hand $chan $output      }   }}

Something like this should work, and would just act as a "stub" to detect should the bot talk and if so passes execution along to the normal procedure pub_dotalkz. This is the easiest way to accomplish it.

and [lindex] is used to avoid possible conflicts with special tcl characters during the regsub with evaluated variable contents.

Statistics: Posted by speechles — Sat Aug 08, 2009 1:09 pm