egghelp/eggheads community

auto voice between 11pm and 8am

2009-07-04T15:04:13-04:00

For additional flexibility, I was trying to allow use of a secondary GMT offset in case a time zone was required within an IRC community that was not the same as the bot's GMT offset time.

Using nml375's hour checking statement, I think the following is now the correct logic.

Code:

set vStartHour 23set vEndHour 8set vGmtOffset +1set vVoiceDelay 10bind JOIN - * pTimedVoiceJoinproc pTimedVoiceJoin {nick uhost hand chan} {    global vGmtOffset vStartHour vEndHour vVoiceDelay    set hour [clock format [expr {[clock seconds] + ($vGmtOffset * 3600)}] -format %k -gmt 1]    if {$hour >= $vStartHour && $hour < $vEndHour || ($hour >= $vStartHour || $hour < $vEndHour) && $vStartHour > $vEndHour} {        utimer $vVoiceDelay [list pTimedVoiceDelay $nick $chan]    }    return 0}proc pTimedVoiceDelay {nick chan} {    if {[botisop $chan]} {        if {[onchan $nick $chan]} {            if {(![isop $nick $chan]) && (![isvoice $nick $chan])} {                pushmode $chan +v $nick                flushmode $chan            }        }    }    return 0}# eof

Statistics: Posted by arfer — Sat Jul 04, 2009 3:04 pm

auto voice between 11pm and 8am

2009-07-04T13:56:01-04:00

speechles,
lappend will work just fine, if you know how to use it.. Such as below:
Code:
lappend ::voicelist $nick $uhost $handle $channel
This is the recommended way of doing it, as it yields significant performance boost with large lists (see the lappend manpage for further details).

Corrected the prior script to properly use lappend. For some reason every time I've tried to use it this way it has failed me but might be because I've always tried it using [list $elements $go $here] rather than just list the elements singularly after the lappend.

Also, corrected the code advice you gave and incorporated it into the script along with mention to you. If this is done poorly shout it out. If you'd rather not participate then I'll change the "maybe this is" back into a "this is not".. haw

Statistics: Posted by speechles — Sat Jul 04, 2009 1:56 pm

auto voice between 11pm and 8am

2009-07-04T13:55:52-04:00

speechles,
The code I proposed is this:

Code:

if {$hour >= $start && $hour < $end || ($hour >= $start || $hour < $end) && $start > $end} {

That's not even remotely close to the code you pinned my signature.. "minor tweak" does not cut it. What you wrote in your script is not my code, as such - do not attribute it to me, correct or faulty.

Your code does not work, as it makes the assumption $vStartHour is always less than $vEndHour. This is not the case in the original request.

Statistics: Posted by nml375 — Sat Jul 04, 2009 1:55 pm

auto voice between 11pm and 8am

2009-07-04T13:47:43-04:00

speechles,
lappend will work just fine, if you know how to use it.. Such as below:

Code:

lappend ::voicelist $nick $uhost $handle $channel

This is the recommended way of doing it, as it yields significant performance boost with large lists (see the lappend manpage for further details).

Statistics: Posted by nml375 — Sat Jul 04, 2009 1:47 pm

auto voice between 11pm and 8am

2009-07-04T13:42:17-04:00

speechles,
I did not make any comments as to your flood protection, neither anyone else's. You might also like to keep in mind that the original request did not come with flood protection, neither did the initial code example by the requester have one.

That, however, does not change the case that you've attached my signature to code I've not written, and which is non-functional. At best, I consider that slander.

Which part isn't functional, and notice after your nick says minor tweaks.. why are you so offended that your participation in a script has been noted in some regard, do you wish that removed, just say so? maybe you already have in this case just say so without being sarcastic about it or just "mod edit" it out. You do have this power. I remember the incident when you attained it precisely.

On a side note, you could improve performance in your script by using the lappend command rather than resetting the variable with a concat'd value...

Lappand won't behave the same when using the foreach constructed below. I wanted a single inline list. Not a series of lists within lists. With those I would need to run a series of sets with lindexes on them to get the contents of each element. With an inline list, which concat gives back, is the only way the foreach constructed on the timer:onjoin can work. This is done to keep the code short and remove all those sets and lindexes otherwise required.

Statistics: Posted by speechles — Sat Jul 04, 2009 1:42 pm

auto voice between 11pm and 8am

2009-07-04T13:37:51-04:00

speechles,
I did not make any comments as to your flood protection, neither anyone else's. You might also like to keep in mind that the original request did not come with flood protection, neither did the initial code example by the requester have one.

That, however, does not change the case that you've attached my signature to code I've not written, and which is non-functional. At best, I consider that slander.

On a side note, you could improve performance in your script by using the lappend command rather than resetting the variable with a concat'd value...

Statistics: Posted by nml375 — Sat Jul 04, 2009 1:37 pm

auto voice between 11pm and 8am

2009-07-04T13:22:39-04:00

Speechles,
Not to be rude, but the expression you've entered is not even remotely close to what I've suggested! Also, it is severely flawed.
Please do not attach my signature with some random piece of code.

Not to be rude sir, but your code will flood a channel in the event of a flood of joins. Be this a netsplit, rogue users, etc. I would rather think you at your caliber of this field you would be more caring. But i digress....

Also corrected that silly concat I did above to keep all elements available to allow the timer to keep the contents intact. The foreach seemed simplest and the only way to do it without using a series of sets with lindexes on them. concat is the answer. This is not to criticize your help to the user as all he asked was for a direction to go in accomplishing it. He probably could have figured out the rest. This was just for the sake of debate which clearly we are having. Bravo.

Statistics: Posted by speechles — Sat Jul 04, 2009 1:22 pm

auto voice between 11pm and 8am

2009-07-04T13:20:18-04:00

Speechles,
Not to be rude, but the expression you've entered is not even remotely close to what I've suggested! Also, it is severely flawed.
Please do not attach my signature with some random piece of code.

Statistics: Posted by nml375 — Sat Jul 04, 2009 1:20 pm

auto voice between 11pm and 8am

2009-07-04T14:24:52-04:00

Code:

# set some global vars up with contents# voice delay (in minutes) this is to prevent a# flood of voices during a netsplit rejoin, or# rogue users flooding your channel.variable vVoiceDelay 10# hour to start voice (24 hour) variable vStartHour 23# hour to stop voicing (24 hour)variable vEndHour 8# init voicelistvariable voicelist [list]# init timer to check list, so if a flood of joins occurs# in that period, we can stuff as many modes on one line# as possible in as many channels as possible.timer $vVoiceDelay timer:onjoinproc pub:onjoin {nick uhost handle channel} {  # maybe this is nml375's code :)  set hour [clock format [clock seconds] -format "%k"]  if {$hour >= $::vStartHour && $hour < $::vEndHour || ($hour >= $::vStartHour || $hour < $::vEndHour) && $::vStartHour > $::vEndHour} {    # create a single in-line voicelist, checking that    # a rotating nickname gets added only once.    if {[lsearch -exact $::voicelist [string tolower $nick]] == -1} {      lappend ::voicelist [string tolower $nick] $uhost $handle $channel     }  }}proc timer:onjoin { } {  set channellist [list]  # iterate through the in-line voicelist  foreach {nick uhost handle channel} $::voicelist {    # conditionals    if {[botisop $channel] && [onchan $nick $channel] && ![isvoice $nick $channel]} {      pushmode $channel +v $nick      # for the flushmode below to work we need to track every chan      # we've done any mode changes through. to keep this list short      # and no channels repeated, i propose an lsearch. i know this      # would be executed at the end of the proc anyways. this is      # for style points.. :P      if {[lsearch -exact $channellist $channel] == -1} {        lappend $channellist $channel      }    }  }  # STYLE POINTS! this is totally unnecessary, but it looks cool.  foreach $chan $channelist {    flushmode $chan  }  # clear voicelist for next flush  set ::voicelist [list]  # recall timer to check next joiners  timer $::vVoiceDelay timer:onjoin }

If I may throw my 2cents worth into this debate. This is probably where arfer was going with his script. The idea is to keep mode changes to a minimum in case a flood of joins occurs and this keeps it global for every channel the bot resides in just like the rest of your scripts did..

Edit: Corrected many stupid mistakes and obvious over sights mentioned further down in this thread. This should now be something useful to the poster rather than something to be looked down upon as a poor example of poster's request.

Statistics: Posted by speechles — Sat Jul 04, 2009 1:16 pm

auto voice between 11pm and 8am

2009-07-04T12:25:25-04:00

arfer,
Just use the modulus operator, and you won't have to bother with testing..
Or, as I suggested, simply make use of the already existing time zone settings.. Seems rather overkill to add a second time zone setting that only affects one function...

Next, you have three cases with start- and end-hour:

start is less than end
We should only voice if $hour is greater than or equal to start and less than end.
start is greater than end
We should only voice if $hour is greater than or equal to start or less than end.
start is equal to end
This is really not a valid range. We should not voice at all.

If we choose to ignore the last case, as it is not valid, we can compile the following expression (in it's most simplified form, be aware that this expression is designed with operator priority in mind).:

Code:

if {$hour >= $start && $hour < $end || ($hour >= $start || $hour < $end) && $start > $end} {

Statistics: Posted by nml375 — Sat Jul 04, 2009 12:25 pm

auto voice between 11pm and 8am

2009-07-04T12:15:12-04:00

Hmm, I also see what you mean regarding the gmt code. This could erroneously generate hour 24

This is not easy to accomplish

Statistics: Posted by arfer — Sat Jul 04, 2009 12:15 pm

auto voice between 11pm and 8am

2009-07-04T12:12:53-04:00

sorry nml375, I realised was taking nonsense before you replied and deleted my post

However, I was interested to develop a more flexible script and cant seem to find the math to calculate whether a particular hour is between two others, as follows :-

I think your mod maths is needed to check if a number is in bounds.

Could you take a look and advise please

Code:

set vStartHour 23set vEndHour 8set vGmtOffset +1set vVoiceDelay 10bind JOIN - * pTimedVoiceJoinproc pTimedVoiceJoin {nick uhost hand chan} {    global vGmtOffset vStartHour vEndHour vVoiceDelay    set hour [expr {[clock format [clock seconds] -format %k -gmt 1] + $vGmtOffset}]    # {if statement needed here for checking if within bound} {        utimer $vVoiceDelay [list pTimedVoiceDelay $nick $chan]    # }    return 0}proc pTimedVoiceDelay {nick chan} {    if {[botisop $chan]} {        if {[onchan $nick $chan]} {            if {(![isop $nick $chan]) && (![isvoice $nick $chan])} {                pushmode $chan +v $nick                flushmode $chan            }        }    }    return 0}# eof

Statistics: Posted by arfer — Sat Jul 04, 2009 12:12 pm

auto voice between 11pm and 8am

2009-07-04T12:05:32-04:00

arfer,
24 would actually be 0, not 24, and would thus be covered by the "less than 8" part. The logic is not flawed...

Of course, if we'd rather have a different limit than 11pm such as 10pm, you'd simply change "$hour == 23" into "$hour >= 22". As for your logics in your script, I'm quite confident to say that it is flawed:

Code:

.. ($h >= $vStartHour) && ($h >= $vEndHour) ..

Tests whether we've passed both the start and end hour. If we've passed both, we really should'nt voice.

Code:

.. ($h <= $vStartHour) && ($h <= $vEndHour) ..

Tests whether we've yet to reach both the start and end hour. Hence, we've yet to reach the time when we should start voicing.

So you are actually voicing when you should not voice...

The gmt-offset is also flawed, as this code could generate hours out of bounds. You'd atleast need to use the modulus operator to make certain the result is in bounds. In my honest opinion, this is overworked though, as the clock command honours time zone settings, and will always use the same time as your eggdrop.

Statistics: Posted by nml375 — Sat Jul 04, 2009 12:05 pm

auto voice between 11pm and 8am

2009-07-04T11:30:15-04:00

thanks for helping nml375 you are great

Statistics: Posted by jeroen_005 — Sat Jul 04, 2009 11:30 am

auto voice between 11pm and 8am

2009-07-04T11:16:01-04:00

username,
%k does not prefix single-digit values with 0, %H does..
For further explanations, see the man-pages.

Statistics: Posted by nml375 — Sat Jul 04, 2009 11:16 am