egghelp/eggheads community

Help with one of my script..

2008-08-31T08:56:54-04:00

IT WORKS MANY THNX!!!!!!!!!!!!!!!

Statistics: Posted by ultralord — Sun Aug 31, 2008 8:56 am

Help with one of my script..

2008-08-31T08:05:50-04:00

no errors nothing.. wtf... can someone try it to see if he had that problem?

Statistics: Posted by ultralord — Sun Aug 31, 2008 8:05 am

Help with one of my script..

2008-08-31T05:00:38-04:00

put in partyline.

Code:

.console +o

and look if it show some error message.

Statistics: Posted by Nor7on — Sun Aug 31, 2008 5:00 am

Help with one of my script..

2008-08-31T04:32:15-04:00

someone knows why the bot not response to script?? :/

Statistics: Posted by ultralord — Sun Aug 31, 2008 4:32 am

Help with one of my script..

2008-08-30T12:42:55-04:00

i edit :

Code:

set channels "#mychannel"bind join - * machingproc maching {nick host hand chan} {      global g_losestats g_pickupchan g_winstats way1 way2 channels  if { $channels != $g_pickupchan } {return 0}   set findwin 0   set findlose 0   set searchwin [split [read [open $way1 r]] "\n"]   foreach newwin [lindex $searchwin 0] {        if {$newwin == $nick} {incr findwin 1}                      }    set searchlose [split [read [open $way2 r]] "\n"]    foreach newlose [lindex $searchlose 0] {        if {$newlose == $nick} {incr findlose 1}                     }    if {$findwin == 0} {           set findwin 1         }    if {$findlose == 0} {           set findlose 1         }          if {[expr $findwin / $findlose] >= "5" } {             putquick "PRIVMSG $g_pickupchan : \002\00304 $nick\003 You have coefficient\00303 [expr $findwin / $findlose] \003 I give you\00304 +"          putquick "MODE $g_pickupchan +v $nick"    }}

but no response my nick is "Ultralord" on irc and on txt files.. :/

Statistics: Posted by ultralord — Sat Aug 30, 2008 12:42 pm

Help with one of my script..

2008-08-30T12:30:35-04:00

The way this script is written, all string comparisons are case sensitive, including nicknames and channel names. So, should g_pickupchan be set to "#mychan", and you decide to join "#MyChan", this script will not react. Same if you use ultralord as you nick instead of UltraLord.

Of course, I assume you've double checked the actual scores, as this script will not perform any actions unless the win/loose ratio is above 5 (as requested)..

Statistics: Posted by nml375 — Sat Aug 30, 2008 12:30 pm

Help with one of my script..

2008-08-30T12:22:57-04:00

i try like.. :

Code:

set way1 "/home/ultralord/www/dota/g_winstats.txt"set way2 "/home/ultralord/www/dota/g_losestats.txt"bind join - * machingproc maching {nick host hand chan} {      global g_losestats g_pickupchan g_winstats way1 way2   if {$g_pickupchan != $chan} {return 0}   set findwin 0   set findlose 0   set searchwin [split [read [open $way1 r]] "\n"]   foreach newwin [lindex $searchwin 0] {        if {$newwin == $nick} {incr findwin 1}                      }    set searchlose [split [read [open $way2 r]] "\n"]    foreach newlose [lindex $searchlose 0] {        if {$newlose == $nick} {incr findlose 1}                     }    if {$findwin == 0} {           set findwin 1         }    if {$findlose == 0} {           set findlose 1         }          if {[expr $findwin / $findlose] >= "5" } {             putquick "PRIVMSG $g_pickupchan : \002\00304 $nick\003 You have coefficient\00303 [expr $findwin / $findlose] \003 I give you\00304 +"          putquick "MODE $g_pickupchan +v $nick"    }}

but nothing happened no tcl errors but nothing.. like it doesnt work..

Statistics: Posted by ultralord — Sat Aug 30, 2008 12:22 pm

Help with one of my script..

2008-08-30T09:17:02-04:00

Replace the $g_winstats and $g_losestats with the actual path and filenames of the stats-files, and you should be able to open the files properly.

Statistics: Posted by nml375 — Sat Aug 30, 2008 9:17 am

Help with one of my script..

2008-08-30T08:01:31-04:00

many many thanks for that!!!!!! but when i run it.. i goes to test it.. i make /hop and i saw tcl error on dcc chat

[14:42:43] [13:43] Tcl error [maching]: couldn't open "uL uL uL Ultralord Ultralord uL uL Ultralord Ultralord uL vlakas eleos mp00 mosxasisisi uL vlakas eleos mp00 mosxasisisi.txt": no such file or directory

the txt's file is on directory

/home/ultralord/www/dota/g_winstats.txt
/home/ultralord/www/dota/g_losestats.txt

Statistics: Posted by ultralord — Sat Aug 30, 2008 8:01 am

Help with one of my script..

2008-08-29T15:07:53-04:00

Nope, the file handle is still left open. Some systems do allow the same file to be opened by multiple handles given certain conditions. Tcl, however, will not reuse the same file handle, but instead horde system resources... In the long run, you'll use up your process' quota of file handlers, and your eggdrop will be completely unable to open any further files...

read will read all the data from the current filepointer up until the end, assuming the file has been accessed in a blocking mode and no numChars argument has been supplied. In other cases, the amount of data read may vary depending on current conditions. However, in none of those cases will read try to close the file descriptor.

In the end, Always close your file handles when you've stopped using them.

Statistics: Posted by nml375 — Fri Aug 29, 2008 3:07 pm

Help with one of my script..

2008-08-29T14:49:40-04:00

That looks alot better

Personally, I'd find an equation such as win/(win+loss) more intuitive, but since ultralord requested win/loss, your approach to avoid division by zero is reasonable. Could probably skip setting win to 1, as win is the nominator, not the denominator. Though in either case, the end result would be the same.

One final advice though, once you've read the files, do take the time to close them in order to save system resources, and avoid locking the files for future score-updates.

for me only when open .... "w" (write) is necessity to close files. When you use open whit "r" (read only) a think command open file read content and close file immediately. For test if we use file with read $file w and don't close and flush it we never open the file whit new stuff if we use open r we don't have to . On my bot read is in one proc and others call him .

Statistics: Posted by game_over — Fri Aug 29, 2008 2:49 pm

Help with one of my script..

2008-08-29T12:45:48-04:00

That looks alot better

Personally, I'd find an equation such as win/(win+loss) more intuitive, but since ultralord requested win/loss, your approach to avoid division by zero is reasonable. Could probably skip setting win to 1, as win is the nominator, not the denominator. Though in either case, the end result would be the same.

One final advice though, once you've read the files, do take the time to close them in order to save system resources, and avoid locking the files for future score-updates.

Statistics: Posted by nml375 — Fri Aug 29, 2008 12:45 pm

Help with one of my script..

2008-08-29T12:31:05-04:00

I forgot read command but i tell you this i same example. I see you want all. Only insert this

Code:

bind join - * machingproc maching {nick host hand chan} {      global g_losestats g_pickupchan g_winstats   if {$g_pickupchan != $chan} {return 0}   set findwin 0   set findlose 0   set searchwin [split [read [open $g_winstats r]] "\n"]   foreach newwin [lindex $searchwin 0] {        if {$newwin == $nick} {incr findwin 1}                      }    set searchlose [split [read [open $g_losestats r]] "\n"]    foreach newlose [lindex $searchlose 0] {        if {$newlose == $nick} {incr findlose 1}                     }    if {$findwin == 0} {           set findwin 1         }    if {$findlose == 0} {           set findlose 1         }     if {[expr $findwin / $findlose] >= "5" } {             putquick "PRIVMSG $g_pickupchan : \002\00304 $nick\003 You have coefficient\00303 [expr $findwin / $findlose] \003 I give you\00304 +" putquick "MODE $g_pickupchan +v $nick"    }}

this do that

http://img5.pictiger.com/4e6/16597121.jpg?u=1220027072

now i say expr 5 / 0 wins and loses is 0 i script if you don't have loses set loses to 1. now 5 / 1 = 5 and voise is up and 0 / 5 to 1 / 5 . If want to see nums like this 0.0005 just

[expr $findwin / $findlose]

[expr $findwin. / $findlose.]

Statistics: Posted by game_over — Fri Aug 29, 2008 12:31 pm

Help with one of my script..

2008-08-29T08:41:40-04:00

@game_over:
foreach does'nt understand file-descriptors... foreach only understands lists.

A file descriptor is simply a short string containing one word that identifies the opened file. But to foreach, it just looks like a list with one single entity, looking something like "file12". Doing a foreach on that will just run the code once, with newwin containing "file12", nothing else...

As for the file structure, it is a single line with the nicks of the winners in a list. Thus, even if you did fix your code to actually read from the file, your if-conditional makes no sense...
First off, newwin would not be a list, but a string - don't use lindex here, that'll break things.
Secondly, should the lindex not choke on the data, it would most likely just return a possibly mangled newwin, which most certainly is not a boolean data (required by if). Hence you'd only end up with an error message such as: expected boolean value but got "nickname".

Statistics: Posted by nml375 — Fri Aug 29, 2008 8:41 am

Help with one of my script..

2008-08-29T06:38:13-04:00

Game_over:
First off, your file handling is incorrect... Doing a foreach-loop on a filehandle will not yield the result you expect.
Next, I can't even imagine the purpose of the lindex commands, or how you expect that code to produce a tally of wins/losses...

Finally, properly indenting the code would reveal that there is one { missing from one of the if-constructs...

Because i think the file structure is that:

nick1 wins
nick2 wins

and wins and loses are writed whit nums this is more effective way
now i am on work when i gather at home i look this files an run on my bot and you have no problems

Statistics: Posted by game_over — Fri Aug 29, 2008 6:38 am