egghelp/eggheads community

Exec issue...

2007-10-26T19:18:46-04:00

Scripts that run exec, especially with unchecked input, are dangerous. Something to keep in mind when writing this script.
Script security

Statistics: Posted by rosc2112 — Fri Oct 26, 2007 7:18 pm

Exec issue...

2007-10-26T17:31:31-04:00

Try something like this then:

Code:

if {[catch {exec who} status]} {#error condition, error-message stored in $status} {#Successful, any output stored in $status}

Statistics: Posted by nml375 — Fri Oct 26, 2007 5:31 pm

Exec issue...

2007-10-26T15:11:24-04:00

Thanks. I've made that change.

One other question... If I were to run a command such as 'who' by !exec who (which is not allowed on the shell), it outputs the "Permission denied" as a TCL error in the PL... Is there a way to detect if it's an error of some sort and have it output it to the channel anyway?

Thanks!

Statistics: Posted by BeBoo — Fri Oct 26, 2007 3:11 pm

Exec issue...

2007-10-26T14:46:14-04:00

So?
Still only gets passed to the proc as a single parameter... Hence you get the whole commandline when doing [lindex $args 0].

in fact, you'd get the same result if you'd replace "args" with "text", and "[lindex $args 0]" with "$text" in your script

Statistics: Posted by nml375 — Fri Oct 26, 2007 2:46 pm

Exec issue...

2007-10-26T14:37:58-04:00

Because I call the commands I want to be exec'd... for instance:

!exec ps -u
or
!exec uptime

Statistics: Posted by BeBoo — Fri Oct 26, 2007 2:37 pm

Exec issue...

2007-10-26T14:27:22-04:00

Then, pardon me for asking, what use would you have of using "args"?

Statistics: Posted by nml375 — Fri Oct 26, 2007 2:27 pm

Exec issue...

2007-10-26T14:26:01-04:00

Just one binding: !exec

I will post my script so it can be critiqued when I'm done cleaning it up.

heh

Statistics: Posted by BeBoo — Fri Oct 26, 2007 2:26 pm

Exec issue...

2007-10-26T14:19:11-04:00

So you use several different types of bindings to trigger that proc?

Ah well, newlines would generally be \n yes, possibly except on "odd" (windows) platforms...

Statistics: Posted by nml375 — Fri Oct 26, 2007 2:19 pm

Exec issue...

2007-10-26T14:16:56-04:00

I am using it's feature... It's in my proc... proc runit {nick uhost handle chan args} {

That works great! Now, because the commands that I will run, most of them are multi-lined and would like all the lines to appear in the output. How would I determine the end of the line? Would it be \n?

Thanks!!!

Statistics: Posted by BeBoo — Fri Oct 26, 2007 2:16 pm

Exec issue...

2007-10-26T14:05:41-04:00

First off, try to avoid using the name "args" for any variable, unless explicitly intended to use it's special feature.
Secondly, you'll have to separate the arguments from the command in the cmd-line string, and pass them as a separate argument to exec.

A simple example:

Code:

proc docommand {cmdline} { set _t [split $cmdline " "] return [exec -- [lindex $_t 0] [join [lrange $_t 1 end] " "]]}

Statistics: Posted by nml375 — Fri Oct 26, 2007 2:05 pm

Exec issue...

2007-10-26T13:51:13-04:00

Without what quotes? I typed: !exec ps -u (with no quotes)

I get the following with the .tcl command in PL:

Code:

1:48pm (BeBoo) .tcl exec ps -ux1:48pm (optix) What? You need '.help'

The thing is, I'd like the output to go to the chan... Logging into my eggie just to run a command is just as bad as logging into the shell... I'd rather just be able to type "!exec ps -ux"

Statistics: Posted by BeBoo — Fri Oct 26, 2007 1:51 pm

Exec issue...

2007-10-26T13:47:32-04:00

without the quotes?
I've tried in PL: .tcl exec ps -ux

It works, making a lot off errors because it tries to execute the output.

Statistics: Posted by CrazyCat — Fri Oct 26, 2007 1:47 pm

Exec issue...

2007-10-26T13:40:44-04:00

Hey everyone. I am making a simple exec tcl script that only I can run with my eggie that will do little commands on my shell for me instead of logging into it to do a simple task. Anyway, my problem is, I can get it to run single word commands such as "uptime" and "pwd" but i can't get it to do anything that has a switch needed such as "ps -x". I get the following error:

Code:

Tcl error [techjoose::runit]: couldn't execute "ps -x": no such file or directory

Any ideas on how this could work? My script is quite simple and basic:

Code:

putserv "PRIVMSG $chan :\002\00305\[\003 \00312EXECUTOR\003 \00305\]\002\003 [exec [lindex $args 0]]"

Thanks for any help anyone can offer!

Statistics: Posted by BeBoo — Fri Oct 26, 2007 1:40 pm