egghelp/eggheads community

My request script. [wont validate.]

2007-09-05T12:33:16-04:00

A few comments on the last few posts:

Returning 1 when triggered by a raw binding will prevent any further processing. In this case, depending on order, this would completely disable eggdrop's ability of maintaining the internal channel-memers list.
Using raw-bindings with the output of NAMES has the disadvantage that you would have to manually process any and all RPL_NAMREPLY replies along with the RPL_ENDOFNAMES, as this will not update the internal channel-members list, whereas, using the output of WHO allows you to use chanlist without any manual processing. Care should however be taken to make sure this is done after eggdrop has processed this message itself.
The is still an issue with unescaped [ in tosser's last post, see user's post erlier in the thread... as stated by awyeah, there should not be an additional ] within request:endofwho.
pub:request is flawed as it uses list commands (lindex) on a string. It also splits $nick for some unknown reason. Lastly, the check against the blocked channels list does not properly care for case.
The list of blocked channels could easily be broken, if not careful with characters affecting list structures.

Statistics: Posted by nml375 — Wed Sep 05, 2007 12:33 pm

My request script. [wont validate.]

2007-09-05T11:08:11-04:00

This would be the correct code I beleive:

Code:

proc request:endofwho {from raw arg} { global requestchannel requestnick if {[string equal -nocase [lindex [split $arg] 1] $requestchannel]} {  request:join_chan $requestchannel $requestnick  return 1  }}

Tosser's code was correct. You added an extra bracket which would generate an error in the proc and will not make it execute.

Technique: In a statement, all opening brackets "[" should be equal to all "]" closing brackets. Only then the statement would be balanced. This goes for all type of brackets. (round brackets and also curly braces)

If there was an error because of a missing-bracket, it must be in some other proc, this one is correct. Besides I see in one of your procs (in a putserv statement) you have not escaped the [, ] brackets and left them as they are.
Hint: Read user's post.

Remember to escape all tcl special characters ([, ], {, }, \, $, & etc) with a "\" infront of them. Your script is choking on brackets from what I see, so fix it.

Statistics: Posted by awyeah — Wed Sep 05, 2007 11:08 am

My request script. [wont validate.]

2007-09-05T07:23:46-04:00

you missed a ] at

Code:

proc request:endofwho {from raw arg} {   global requestchannel requestnick   if {[string equal -nocase [lindex [split $arg] 1]] $requestchannel]} {      request:join_chan $requestchannel $requestnick      return 1   }}

Statistics: Posted by Youri — Wed Sep 05, 2007 7:23 am

My request script. [wont validate.]

2007-09-05T04:51:11-04:00

chanlist will output the content of eggdrop's internal list of channel-members, it will not trigger a fetch from the server. Thus, if you call it too soon from your eggie joining a channel, you will not get a list of the channel members.
Hence, you'd need to delay that process until the internal list has been fully updated... Either using a timer, or a raw binding triggering on the numeric for "End of who".
I was not aware of that. Learned something new

Also you can use the raw binding, with the command: /NAMES #channel
This can be done immediately on join and does not need any delay when called. It will give you the member-list of the channel from the server. Also nicks with ops and voices will have their respective operator sign infront of them.

Statistics: Posted by awyeah — Wed Sep 05, 2007 4:51 am

My request script. [wont validate.]

2007-09-04T23:29:44-04:00

chanlist will output the content of eggdrop's internal list of channel-members, it will not trigger a fetch from the server. Thus, if you call it too soon from your eggie joining a channel, you will not get a list of the channel members.
Hence, you'd need to delay that process until the internal list has been fully updated... Either using a timer, or a raw binding triggering on the numeric for "End of who".

I was not aware of that. Learned something new

Statistics: Posted by rosc2112 — Tue Sep 04, 2007 11:29 pm

My request script. [wont validate.]

2007-09-04T16:58:01-04:00

Updated:

Code:

############################################################ Package Name:          Request                          ## Package Author:        Youri < xeonnn@gmail.com >       ## Package Version:       1                                ############################################################bind pub -|- .request pub:requestbind msg -|- .help pub:helpbind raw - {315} request:endofwhoset requestchannel ""set requestnick ""proc pub:help {nick uhost handle text} {  putserv "PRIVMSG $nick : \[HELP\] To request the bot, typ .request "  putserv "PRIVMSG $nick : \[HELP\] The channel needs to have minium 20 people, and you need a operator status."  putserv "PRIVMSG $nick : \[HELP\] If the requested channel doesnt require the rules the bot will leave."}proc pub:request {nick uhost handle chan text} {   global requestchannel requestnick   set requestchannel [string tolower [lindex $text 0]]   set requestnick [split $nick]   set blocked(active) no   set blocked(channels) {    "#help"    "#xeoN.development"   }   foreach block $blocked(channels) {     if { $block == $requestchannel } { set blocked(active) yes  }   }  if { $blocked(active) == yes } {     putserv "PRIVMSG $nick : \[ERROR\] $requestchannel has been blocked from the request service."  } else {     channel add $requestchannel     putserv "PRIVMSG $nick : \[APPROVED\] $requestchannel has been approved, validation will begin in a couple seconds."  }}proc request:endofwho {from raw arg} {   global requestchannel requestnick   if {[string equal -nocase [lindex [split $arg] 1] $requestchannel]} {      request:join_chan $requestchannel $requestnick      return 1   }}proc request:join_chan { requestchannel requestnick } {  set t_users [llength [chanlist $requestchannel]]  set usercheck [expr $t_users - 1]  if { $usercheck >= 20  && [isop $requestnick] } {    putserv "PRIVMSG $requestnick : \[VALIDATION\] Found 20, or more users in $requestchannel ."    putserv "PRIVMSG $requestnick : \[VALIDATION\] You have operator(@)."    putserv "PRIVMSG $requestnick : [\VALIDATION\] The channel meets the requirements, the bot will stay."  } else {    putserv "PRIVMSG $requestnick : \[ERROR\] The channel does not meet the requirements."    putserv "PRIVMSG $requestnick : \[ERROR\] Typ .help to see the requirements."    channel remove $requestchannel  }}

Statistics: Posted by r0t3n — Tue Sep 04, 2007 4:58 pm

My request script. [wont validate.]

2007-09-04T15:29:23-04:00

Still have to add proper return-values to prevent your eggie from going nuts...

(17) RAW (stackable)
bind raw
procname

Description: previous versions of Eggdrop required a special compile
option to enable this binding, but it's now standard. The keyword
is either a numeric, like "368", or a keyword, such as "PRIVMSG".
from will be the server name or the source user (depending on
the keyword); flags are ignored. The order of the arguments is
identical to the order that the IRC server sends to the bot. The
pre-processing only splits it apart enough to determine the
keyword. If the proc returns 1, Eggdrop will not process the line
any further (this could cause unexpected behavior in some cases).
Module: server

Statistics: Posted by nml375 — Tue Sep 04, 2007 3:29 pm

My request script. [wont validate.]

2007-09-04T15:24:13-04:00

if you want the bind active all the time, remove the catch lines and add the bind raw line under the other pub/msg bind lines.

Statistics: Posted by r0t3n — Tue Sep 04, 2007 3:24 pm

My request script. [wont validate.]

2007-09-04T15:11:44-04:00

Idea looks good, a few thoughts tho..
When working with raw-bindings, the returncode of the proc is very important, as it determines wether any further processing will be done, and bindings added with scripts trigger before those built in. If a return-value is not provided explicitly, an implicit return-value will be generated from the last executed command within the proc (in this case; catch {unbind raw - {315} request:endofwho})

Also, would'nt it be easier to keep the binding active at all times, extract the channel-name from the message body, and check wether this matches the channel you're trying to validate (in theory, the triggered binding may be from a different who-query, although very unlikely).

Statistics: Posted by nml375 — Tue Sep 04, 2007 3:11 pm

My request script. [wont validate.]

2007-09-04T14:59:28-04:00

i bind to raw 315 (end of /who), and then continue.

Code:

############################################################ Package Name:          Request                          ## Package Author:        Youri < xeonnn@gmail.com >       ## Package Version:       1                                ############################################################bind pub -|- .request pub:requestbind msg -|- .help pub:helpset requestchannel ""set requestnick ""proc pub:help {nick uhost handle text} {  putserv "PRIVMSG $nick : \[HELP\] To request the bot, typ .request "  putserv "PRIVMSG $nick : \[HELP\] The channel needs to have minium 20 people, and you need a operator status."  putserv "PRIVMSG $nick : \[HELP\] If the requested channel doesnt require the rules the bot will leave."}proc pub:request {nick uhost handle chan text} {   global requestchannel requestnick   set requestchannel [string tolower [lindex $text 0]]   set requestnick [split $nick]   set blocked(active) no   set blocked(channels) {    "#help"    "#xeoN.development"   }   foreach block $blocked(channels) {     if { $block == $requestchannel } { set blocked(active) yes  }   }  if { $blocked(active) == yes } {     putserv "PRIVMSG $nick : \[ERROR\] $requestchannel has been blocked from the request service."  } else {     catch {bind raw - {315} request:endofwho}     channel add $requestchannel     putserv "PRIVMSG $nick : \[APPROVED\] $requestchannel has been approved, validation will begin in a couple seconds."  }}proc request:endofwho {from raw arg} {   global requestchannel requestnick   if {[string equal -nocase [lindex [split $arg] 1] $requestchannel]} {      request:join_chan $requestchannel $requestnick      catch {unbind raw - {315} request:endofwho}   }}proc request:join_chan { requestchannel requestnick } {  set t_users [llength [chanlist $requestchannel]]  set usercheck [expr $t_users - 1]  if { $usercheck >= 20  && [isop $requestnick] } {    putserv "PRIVMSG $requestnick : \[VALIDATION\] Found 20, or more users in $requestchannel ."    putserv "PRIVMSG $requestnick : \[VALIDATION\] You have operator(@)."    putserv "PRIVMSG $requestnick : [\VALIDATION\] The channel meets the requirements, the bot will stay."  } else {    putserv "PRIVMSG $requestnick : \[ERROR\] The channel does not meet the requirements."    putserv "PRIVMSG $requestnick : \[ERROR\] Typ .help to see the requirements."    channel remove $requestchannel  }}

Might work, might not.

Statistics: Posted by r0t3n — Tue Sep 04, 2007 2:59 pm

My request script. [wont validate.]

2007-09-04T14:19:54-04:00

chanlist will output the content of eggdrop's internal list of channel-members, it will not trigger a fetch from the server. Thus, if you call it too soon from your eggie joining a channel, you will not get a list of the channel members.
Hence, you'd need to delay that process until the internal list has been fully updated... Either using a timer, or a raw binding triggering on the numeric for "End of who".

Statistics: Posted by nml375 — Tue Sep 04, 2007 2:19 pm

My request script. [wont validate.]

2007-09-04T14:15:26-04:00

Shouldn't need any timers, since the bot will wait til the result of [chanlist] is returned before doing the next commands..

Try putting some "putcmdlog" lines into your script to aid in debugging the process.

Statistics: Posted by rosc2112 — Tue Sep 04, 2007 2:15 pm

My request script. [wont validate.]

2007-09-04T10:05:50-04:00

thanks user, works HALFY now

i think i need to work with a timer indeed.

Statistics: Posted by Youri — Tue Sep 04, 2007 10:05 am

Re: My request script. [wont validate.]

2007-09-04T09:43:16-04:00

Code:

    putserv "PRIVMSG $requestnick : \[VALIDATION\] You have operator(@)."    putserv "PRIVMSG $requestnick : [\VALIDATION\] The channel meets the requirements, the bot will stay."

"[" != "\["

Statistics: Posted by user — Tue Sep 04, 2007 9:43 am

My request script. [wont validate.]

2007-09-04T09:09:42-04:00

The problem is most likely due to the fact that your bot most likely hav'nt had time to gather any information about the channel by the time you call request:join_chan. The time for this may be from just a few secs for small channels, to 20secs or more for large channels (basically the time it takes to retrieve the output, and parse it, from a "WHO #channel" request).

I would probably use a timer to delay the member-check a minute or two.

A somewhat more advanced way of doing it would be to manually capturing the data of the who-request using raw bindings. Making any mistakes here might result in your bot behaving very oddly however.

So the request:join_chan isnt wrong or something?

Statistics: Posted by Youri — Tue Sep 04, 2007 9:09 am