egghelp/eggheads community

Help with a command code (!day):

2007-06-28T22:17:48-04:00

<|EGG> Currently: if {[channel get $chan djtools] && ![isbotnick $nick]} {

The eggdrop is telling you the offending line here, you haven't closed this conditional before closing the procedure. Just change the last part of the s:day proc like this:

Code:

          return 0          }        }    }    }}

Indentation done to match position of your double stacked if statements that start the procedure.

ok, sorry for that I was just asking, didn`t know what that string will do.

Sorry for what? That the advice I gave you was in a tone that led you to believe your question upset me?...hahah.. It's just that remedial questions (questions easily solved just by reading tcl commands docs) usually get sterner answers than something truly complex. So figured I would chime in to explain that you were incorrect in your interpretation of the logic behind that code nml375 gave you, before I explained your other issues.

Statistics: Posted by speechles — Thu Jun 28, 2007 10:17 pm

Help with a command code (!day):

2007-06-28T21:59:02-04:00

ok, sorry for that I was just asking, didn`t know what that string will do.
so, I`ve made the changes like you suggested and now I`m getting this error wen I`m trying to load the script:

.tcl source scripts/lol.tcl
<@|EGG> Error: missing close-brace: possible unbalanced brace in comment - 41.84 ms

and on the dcc-chat:

.set errorInfo
<|EGG> Currently: missing close-brace: possible unbalanced brace in comment
<|EGG> Currently: while executing
<|EGG> Currently: "proc s:day {nick uhost hand chan text} {
<|EGG> Currently: global botnick dj
<|EGG> Currently: if {[channel get $chan djtools] && ![isbotnick $nick]} {
<|EGG> Currently: if {[matchattr $hand n|MASD..."
<|EGG> Currently: (file "scripts/lol.tcl" line
<|EGG> Currently: invoked from within
<|EGG> Currently: "source scripts/lol.tcl"
<|EGG> Currently: ("eval" body line 1)
<|EGG> Currently: invoked from within
<|EGG> Currently: "eval $args"

Statistics: Posted by Riddler — Thu Jun 28, 2007 9:59 pm

Help with a command code (!day):

2007-06-28T20:25:26-04:00

It's so obviously simple how to do this. Your missing minor logic first and need to look back..

if {![string is -strict integer $target] || $target >= 15 || $target <= 0} {

You said, "doesn`t than mean number form 0 to 15 ?" Quite the opposite, it means string not an integer -or- the value is less than or equal to 0 -or- the value is larger than or equal to 15. This is where you would write your standard error message checks to explain to that user what they did wrong, too long, too short, not a number, etc.. it's simple input sanitizing, and in this situation simple is best.

...and about your error, since the bind isn't calling your s:day:ban proc directly and your invoking it within an already bound proc, you can pass it added parameters easily, meaning.. you can just shove them into passing calls.. like below.. just modify your s:day proc like so:

Code:

             # the line below should replace the regexp line presently used             # if {[string is -strict integer $item] || $item <= 14 || $item >= 1} {             # if you insist on using that dirty regexp, remove the line above or you will get unbalanced brace error             if {![regexp "\[^0-14\]" $item]} {              # the set line below can be removed, and change $days to $item in the s:day:ban call              set days $item              s:day:ban $nick $uhost $hand $chan $days $text              .. rest is here..

then, your s:day:ban proc needs to be changed like this:

Code:

proc s:day:ban {nick uhost hand chan days text} {.. rest continues the same ...

It's easier to understand code if your able to understand it's logic as well. You should follow nml375's advice, as your regexp's are not having their intended purpose in your script and are highly exploitable by lower level ops.

and finally, just as a ps.. heh, type .echo off on your partyline so you don't get those #echo# messages after everything..

Statistics: Posted by speechles — Thu Jun 28, 2007 8:25 pm

Help with a command code (!day):

2007-06-28T20:03:05-04:00

Later UPDATE:

Code:

set dj(br) "Banned!"set dj(xb) 1bind pub n|MASDTO !d s:daysetudef flag djtoolsproc s:day {nick uhost hand chan text} { global botnick dj   if {[channel get $chan djtools] && ![isbotnick $nick]} {   if {[matchattr $hand n|MASDTO $chan] || [string tolower $chan]} {     set target [lindex [split $text] 0]        if {![botisop $chan]} {        puthelp "NOTICE $nick :Error I don't have OP!"        return 0        } elseif {[matchattr $hand -|T $chan]} {          if {$target == ""} {          puthelp "NOTICE $nick :SYNTAX:\002 !d <1-14>  \[reason\] \002"          return 0          }          } else {          foreach not $target {              if {![string is -strict integer $target] || $target >= 15 || $target <= 0} {              puthelp "NOTICE $nick :Error max allowed 1-14 days for Test OP Access Users"              return 0              }            }          }          set options $target          foreach item $options {          if {![regexp "\[^0-14\]" $item]} {            set days $item            s:day:ban $nick $uhost $hand $chan $text          return 0          }        }        } elseif {[matchattr $hand -|O $chan]} {          if {$target == ""} {          puthelp "NOTICE $nick :SYNTAX:\002 !d <1-7>  \[reason\] \002"          return 0          }          } else {          foreach not $target {              if {![string is -strict integer $target] || $target >= 8 || $target <= 0} {              puthelp "NOTICE $nick :Error max allowed 1-7 days for OP Access Users"              return 0              }            }          }          set options $target          foreach item $options {          if {![regexp "\[^0-7\]" $item]} {            set days $item            s:day:ban $nick $uhost $hand $chan $text          return 0          }        }    }}proc s:day:ban {nick uhost hand chan text} { global botnick dj   if {[channel get $chan djtools] && ![isbotnick $nick]} {        set type [lindex [split $text] 1]        set dtype [nick2hand $type]        set reason [join [lrange [split $text] 3 end]]          if {$reason == ""} {          set reason $dj(br)          }          if {[string match *!*@* $type]} {          set dhost $type          } else {          set dhost "*!*@[lindex [split [getchanhost $type] @] 2]"          }          if {![matchattr $dtype n|MASDTOVU $chan] && ![isop $type $chan] && ![isvoice $type $chan] && ![matchattr $dtype b]} {            newchanban $chan $dhost days "($hand) $reason" [expr $days * 1440]            putquick "MODE $chan +b $dhost"            putquick "KICK $chan $type :($hand) $reason"            if {$dj(xb) == 1} {            putquick "PRIVMSG X :ban $chan $dhost 1 100 ($hand) $reason" -next            }            newignore $dhost days "($hand) $reason"          return 0        }    }}

I`ve made some changes and reorder the script and I`m getting this error on dcc-chat:

<|EGG> [01:01] Tcl error [s:day]: can't read "days": no such variable

.set errorInfo
<|EGG> [01:02] #me# set errorInfo
<|EGG> Currently: can't read "days": no such variable
<|EGG> Currently: while executing
<|EGG> Currently: "expr $days * 1440"
<|EGG> Currently: (procedure "s:day:ban" line 16)
<|EGG> Currently: invoked from within
<|EGG> Currently: "s:day:ban $nick $uhost $hand $chan $text"
<|EGG> Currently: (procedure "s:day" line 26)
<|EGG> Currently: invoked from within
<|EGG> Currently: "s:day $_pub1 $_pub2 $_pub3 $_pub4 $_pub5"

How to I make the second proc to recognize a variable form the first proc ?!
In this case, this one :

Code:

proc s:day {nick uhost hand chan text} {(...)          set days $item          s:day:ban $nick $uhost $hand $chan $text          return 0(...)

Statistics: Posted by Riddler — Thu Jun 28, 2007 8:03 pm

Help with a command code (!day):

2007-06-28T19:30:40-04:00

I would probably use something like this:
Code:
if {![string is -strict integer $target] || $target >= 15 || $target <= 0} {

good idea, but... it didn`t work
I`ve used that code, and there is no reaction if the number is higher than 7 ( for user with OP Access) and 14 ( for user with Test OP Access) .... the user didn`t get the warning notice.
I`ve also tested the script with this ( the first pieces of codes):

Code:

if {![regexp "\[^8-99999\]" $target} {

and

Code:

if {![regexp "\[^15-99999\]" $target} {

...still no reaction from the bot ( no notice )

<@OP> !d
-|EGG- SYNTAX: !d <1-7> [reason]
<@OP> !d 8 *!*@*.test.ro
<@OP> !d 7 *!*@*.test.ro
* |EGG sets mode: +b *!*@*.test.ro
.tcl killchanban #chan *!*@*.test.ro
<@|EGG> OK: 1 - 0.246 ms
* |EGG sets mode: -b *!*@*.test.ro

and the same thing happends for a nother user with a higher access flag to the bot

<@TestOP> !d
-|EGG- SYNTAX: !d <1-14> [reason]
<@TestOP> !d 15 *!*@*.test.ro
<@TestOP> !d 100 *!*@*.test.ro
<@TestOP> !d 14 *!*@*.test.ro
* |EGG sets mode: +b *!*@*.test.ro
.tcl killchanban #chan *!*@*.test.ro
<@|EGG> OK: 1 - 0.246 ms
* |EGG sets mode: -b *!*@*.test.ro

btw nm375, this piece of code:

Code:

if {![string is -strict integer $target] || $target >= 15 || $target <= 0} {

doesn`t than mean number form 0 to 15 ?

Statistics: Posted by Riddler — Thu Jun 28, 2007 7:30 pm

Help with a command code (!day):

2007-06-27T16:04:03-04:00

I would probably use something like this:

Code:

if {![string is -strict integer $target] || $target >= 15 || $target <= 0} {

Statistics: Posted by nml375 — Wed Jun 27, 2007 4:04 pm

Help with a command code (!day):

2007-06-28T14:07:02-04:00

In my opinion, the number of spaces/tabs per level is'nt that important, what is however, is using the same fashion all through the script, ie. add one space/tab for each level you descend, as illustrated by rosc.

Also, I'm not sure those regular expressions you're using actually does what you intended, ie:
Code:
if {![regexp "\[^15-99999\]" $target} {
This will match anything starting with the number 1, 5, 6, 7, 8, 9 (such as 1, 10, 19, 91, but not 20). Probably not what you intended.

Ok, thanks for the ie, but if this code

Code:

if {![regexp "\[^15-99999\]" $target]} {

doesn`t except the numbers between 1 to 14 ( that ar the numbers that a specifyed user level will use with the !day command ), what should I use to except numbers form 1 to 14 and for the rest of the numbers to give that notice to the user ( in hope that the user will type the correct number based on his access level )

Statistics: Posted by Riddler — Wed Jun 27, 2007 1:44 pm

Help with a command code (!day):

2007-06-27T11:52:32-04:00

In my opinion, the number of spaces/tabs per level is'nt that important, what is however, is using the same fashion all through the script, ie. add one space/tab for each level you descend, as illustrated by rosc.

Also, I'm not sure those regular expressions you're using actually does what you intended, ie:

Code:

if {![regexp "\[^15-99999\]" $target} {

This will match anything starting with the number 1, 5, 6, 7, 8, 9 (such as 1, 10, 19, 91, but not 20). Probably not what you intended.

Statistics: Posted by nml375 — Wed Jun 27, 2007 11:52 am

Help with a command code (!day):

2007-06-27T10:06:59-04:00

Here's a huge bit of help: Properly TABINATE your scripts... Then you'd be able to see where missing junk is:

Code:

if {this is my first test} {        #tab} else {        if {this is my 2nd test} {                 # tab tab        } else {                  if {this makes it much easier to figure things out} {                             # tab tab tab                 }        }}

Yes I know tabs are a matter of style, but if you're having that much difficulty as a beginner, then learn good coding habits, which begin with TABS (and using small fonts/wider screens so you can read 300+ char length lines because of deeply nested if's/tabs And if your editor allows you to configure tab stops, set it to 4 spaces, not 2, which also makes it easier to read..

Statistics: Posted by rosc2112 — Wed Jun 27, 2007 10:06 am

Help with a command code (!day):

2007-06-27T08:09:59-04:00

This time you're lacking some brackets ([]), check this line again:

Code:

     if {![regexp "\[^15-99999\]" $target} {

Statistics: Posted by nml375 — Wed Jun 27, 2007 8:09 am

Help with a command code (!day):

2007-06-26T20:12:44-04:00

UPDATE:

I`ve closed the missing " } " form the foreach-loop and simplifyed the script for only 1 access flags... to make it a little easy for the script to work...

so here is the code ( simplifyed ):

Code:

set dj(br) "Banned!"set dj(xp) 1bind pub n|MASDTO !day s:bansetudef flag djtoolsproc s:ban {nick uhost hand chan text} { global botnick dj   if {[channel get $chan djtools] && ![isbotnick $nick]} {   if {[matchattr $hand n|MASDTO $chan] || [string tolower $chan]} {     set target [lindex [split $text] 0]        if {![botisop $chan]} {        puthelp "NOTICE $nick :Error I don't have OP!"        return 0        } elseif {[matchattr $hand -|T $chan]} {          if {$target == ""} {          puthelp "NOTICE $nick :SYNTAX:\002 .d <1-14>  \[reason\] \002"          return 0          }          } else {          foreach not $target {              if {![regexp "\[^15-99999\]" $target} {              puthelp "NOTICE $nick :Error max allowed 1-14 days for Test DJ Access Users"              return 0              }            }          }          set options $target             foreach item $options {             if {![regexp "\[^0-14\]" $item]} {             set days $item             set type [lindex [split $text] 1]             set dtype [nick2hand $type]             set reason [join [lrange [split $text] 3 end]]               if {$reason == ""} {               set reason $dj(br)               }             if {[string match *!*@* $type]} {             set dhost $type             } else {             set dhost "*!*@[lindex [split [getchanhost $type] @] 2]"             }             if {![matchattr $dtype n|MASDTOVU $chan] && ![isop $type $chan] && ![isvoice $type $chan] && ![matchattr $dtype b]} {             newchanban $chan $dhost days "($hand) $reason" [expr $days * 1440]             putquick "MODE $chan +b $dhost"             putquick "KICK $chan $type :($hand) $reason"             if {$dj(xb) == 1} {             putquick "PRIVMSG X :ban $chan $dhost 1 100 ($hand) $reason" -next             }             newignore $dhost days "($hand) $reason"            return 0            }        }      }    }  }}

and I`m still getting this error on dcc ..

<|EGG> [01:35] Tcl error [s:ban]: missing close-bracket

and on the .set errorInfo I get this

.set errorInfo
<|EGG> [01:35] #me# set errorInfo
<|EGG> Currently: missing close-bracket
<|EGG> Currently: ("if" test expression)
<|EGG> Currently: while compiling
<|EGG> Currently: "if {![regexp "\[^15-99999\]" $target} {
<|EGG> Currently: puthelp "NOTICE $nick :Error max allowed 1-14 days for Test DJ Access Users"
<|EGG> Currently: retur..."
<|EGG> Currently: ("foreach" body line 2)
<|EGG> Currently: while compiling
<|EGG> Currently: "foreach not $target {
<|EGG> Currently: if {![regexp "\[^15-99999\]" $target} {
<|EGG> Currently: puthelp "NOTICE $nick :Error max allowed 1-14 days for Test ..."
<|EGG> Currently: ("if" else script line 2)
<|EGG> Currently: while compiling
<|EGG> Currently: "if {![botisop $chan]} {
<|EGG> Currently: puthelp "NOTICE $nick :Error I don't have OP!"
<|EGG> Currently: return 0
<|EGG> Currently: } elseif {[matchattr $hand -|T $chan]} {
<|EGG> Currently: ..."
<|EGG> Currently: ("if" then script line 3)
<|EGG> Currently: while compiling
<|EGG> Currently: "if {[matchattr $hand n|MASDTO $chan] || [string tolower $chan]} {
<|EGG> Currently: set target [lindex [split $text] 0]
<|EGG> Currently: if {![botisop $chan]} {
<|EGG> Currently: put..."
<|EGG> Currently: ("if" then script line 2)
<|EGG> Currently: while compiling
<|EGG> Currently: "if {[channel get $chan djtools] && ![isbotnick $nick]} {
<|EGG> Currently: if {[matchattr $hand n|MASDTO $chan] || [string tolower $chan]} {
<|EGG> Currently: set target [lindex ..."
<|EGG> Currently: (compiling body of proc "s:ban", line 3)
<|EGG> Currently: invoked from within
<|EGG> Currently: "s:ban $_pub1 $_pub2 $_pub3 $_pub4 $_pub5"

I`m suppose that my code is a little more complicated and has a lot of if-elseif-else commands in it and maybe that`s why it makes it hard to solve, and I`ll really appreciate is someone helps me to make this script a little more simple than... and also to make it work...

I`ve pointed that I want this script to do something like this:

For OP access user ( +O flag )

!day 7 *!*@*.test.ro
* |EGG sets mode: +b *!*@*.test.ro

How it works:
- sets a chan ban for 1 or 7 days on the banmask with a default ban reason;
- if the OP will type a number higher than 7, like 8 or 9 or 100, the BOT will NOT do the chan ban and will give the specific notice (puthelp "NOTICE $nick :Error max allowed 1-7 days for OP Access Users");

For Test OPs access user ( +T flag )

!day 14 *!*@*.test.ro
* |EGG sets mode: +b *!*@*.test.ro
How it works:
- sets a chan ban for 1 or 14 days on the banmask with a default ban reason;
- if the OP will type a number higher than 14, like 15 or 16 or 100, the BOT will NOT do the chan ban and will give the specific notice (puthelp "NOTICE $nick :Error max allowed 1-14 days for Test OP Access Users");

(...)

and so on for the other flags... the higher the access flag, the more day's you can add to the banmask

It`s a complicated code I`m trying to make... at least I`m trying ( my tcl knowledge are at the beginning ) ...so any help will be appreciated. Thanks

Statistics: Posted by Riddler — Tue Jun 26, 2007 8:12 pm

Help with a command code (!day):

2007-06-26T19:07:16-04:00

You've got a missing } after that foreach-loop, you only closed the if-conditional inside and not the foreach-loop itself.

It would also seem this is the case on several other locations.

Statistics: Posted by nml375 — Tue Jun 26, 2007 7:07 pm

Help with a command code (!day):

2007-06-26T19:00:56-04:00

ok, removed the "unbind`s".. now I`m getting this error..

Code:

(01:57:38)  .set errorInfo(01:57:38) <|EGG> [00:39] #me# set errorInfo(01:57:38) <|EGG> Currently: wrong # args: should be "foreach varList list ?varList list ...? command"(01:57:38) <|EGG> Currently:     while compiling(01:57:38) <|EGG> Currently: "foreach not $target {(01:57:38) <|EGG> Currently:            if {![regexp "\[^101-99999\]" $target} {(01:57:38) <|EGG> Currently:            puthelp "NOTICE $nick :Error max allowed 1-100 days for Administr..."(01:57:38) <|EGG> Currently:     ("if" else script line 2)(01:57:38) <|EGG> Currently:     while compiling(01:57:38) <|EGG> Currently: "if {$target == ""} {(01:57:38) <|EGG> Currently:          puthelp "NOTICE $nick :SYNTAX:\002 .d <1-100>  \[reason\] \002"(01:57:38) <|EGG> Currently:          return 0(01:57:38) <|EGG> Currently:          } else {(01:57:38) <|EGG> Currently:      ..."(01:57:38) <|EGG> Currently:     ("if" then script line 2)(01:57:38) <|EGG> Currently:     while compiling(01:57:38) <|EGG> Currently: "if {![botisop $chan]} {(01:57:38) <|EGG> Currently:         puthelp "NOTICE $nick :Error I don't have OP!"(01:57:38) <|EGG> Currently:         } elseif {[matchattr $hand n|-]} {(01:57:38) <|EGG> Currently:         if {$target == ""} {..."(01:57:38) <|EGG> Currently:     ("if" then script line 3)(01:57:38) <|EGG> Currently:     while compiling(01:57:38) <|EGG> Currently: "if {[matchattr $hand n|MASDTO $chan] || [string tolower $chan]} {(01:57:38) <|EGG> Currently:      set target [lindex [split $text] 0](01:57:38) <|EGG> Currently:         if {![botisop $chan]} {(01:57:38) <|EGG> Currently:         put..."(01:57:38) <|EGG> Currently:     ("if" then script line 2)(01:57:38) <|EGG> Currently:     while compiling(01:57:38) <|EGG> Currently: "if {[channel get $chan djtools] && ![isbotnick $nick]} {(01:57:38) <|EGG> Currently:    if {[matchattr $hand n|MASDTO $chan] || [string tolower $chan]} {(01:57:38) <|EGG> Currently:      set target [lindex ..."(01:57:38) <|EGG> Currently:     (compiling body of proc "s:ban", line 3)(01:57:38) <|EGG> Currently:     invoked from within(01:57:38) <|EGG> Currently: "s:ban $_pub1 $_pub2 $_pub3 $_pub4 $_pub5"(01:58:25) <|EGG> [00:40] @#¹¾ (+stn) : [m/8 o/8 h/0 v/0 n/0 b/0 e/- I/-]

Suggestions ?!

Statistics: Posted by Riddler — Tue Jun 26, 2007 7:00 pm

Help with a command code (!day):

2007-06-23T21:34:27-04:00

Try reading eggdrop.conf. Sir_Fz said to use '.set errorInfo' not run another script.

# Comment these two lines if you wish to enable the .tcl and .set commands.
# If you select your owners wisely, you should be okay enabling these.
unbind dcc n tcl *dcc:tcl
unbind dcc n set *dcc:set

Statistics: Posted by Alchera — Sat Jun 23, 2007 9:34 pm

Help with a command code (!day):

2007-06-23T21:04:06-04:00

.set errorInfo?

do you mean if I use this script ?!

Code:

# .load scriptname.tclbind dcc n|- load script:loadproc script:load { handle idx text } {   if { [catch { uplevel #0 [list source scripts/$text] } error] } {      putlog "0,4Error while loading $text -- Errormsg: $error"      putlog "script: $text -- ::errorInfo: $::errorInfo"      return   }   putlog "script: $text -- loaded without errors."   return}

Statistics: Posted by Riddler — Sat Jun 23, 2007 9:04 pm