egghelp/eggheads community

global variables don't work

2006-08-09T17:27:08-04:00

I have shortened the script above a little bit
So its not the $nick directly who says !afk. The bot who is $nick reproduces everything from a game, so there are people in the game who type !afk. So its [lindex [split $arg] 0] who says !afk.

Statistics: Posted by darton — Wed Aug 09, 2006 5:27 pm

global variables don't work

2006-08-09T17:19:52-04:00

@krimson: Ahh... very true, $nick is the desired nick, while $botnick is the actual.. keep mixing those up all the time :/ *bows before master*

@darton: Then there would be no use to make any variables global at all, go with krimson's example instead or put the checks directly inside the first proc...

Statistics: Posted by nml375 — Wed Aug 09, 2006 5:19 pm

global variables don't work

2006-08-09T16:59:11-04:00

Thank you all for your answers.
By the way, its not a bot who types !afk, its a normal user and if that one types !afk my bot says that that user ($nick) is afk.

Statistics: Posted by darton — Wed Aug 09, 2006 4:59 pm

global variables don't work

2006-08-09T16:24:43-04:00

it's true that his first post was not so clear, but still, for that matter you'd need to use $botnick instead of $nick

Statistics: Posted by krimson — Wed Aug 09, 2006 4:24 pm

global variables don't work

2006-08-09T16:09:58-04:00

1. Depends on the purpose of the proc.. in this case, botaway would indicate it's this bot, hence requiring a nick to be supplied externally would be confusing. If the objective were to check a random nick, you'd be correct tho.
Considdering the ambiguos nature of darton's original code, I'd guess both are equally correct given it's interpretation of that code...

2. True. Just keep a habit of enclosing variable names with {} whenever it is adjacent to any non-whitespace character (Rather do it excessively, rather than forgetting it when really needed)

Statistics: Posted by nml375 — Wed Aug 09, 2006 4:09 pm

global variables don't work

2006-08-09T15:55:59-04:00

here are some tips:

1. don't use global nick, you'd be better off using an argument for proc botaway instead

2. you don't have to use ${nick} there, you use that when you have any non-space char right after the var, and don't want it to get mixed up with something else

Statistics: Posted by krimson — Wed Aug 09, 2006 3:55 pm

global variables don't work

2006-08-09T15:40:51-04:00

Guess that's why one should never code when dead-tired (or quite intoxicated)
(learned that the hard way myself...)

Tho while we're at it, might aswell throw in something like this

Code:

proc botaway { global nick return [expr {[string equal -nocase bla $nick] || [string equal -nocase blabla $nick]}]}proc afk {n u ho ha c t} { global nick if {[botaway]} {  puthelp "PRIVMSG $c :${nick} is AFK" }}

Anyway, what still puzzles me is this: is it the user typing !afk, or the bot, that we are supposed to test against those afk-nicks?
I've never known an eggdrop to be afk sorta.. but then again, why would an user need a bot to tell him/her wether (s)he's afk.. (and quite limited to two possible nicks)

But as it seems darton is'nt putting much more info into this thread, I guess we'll never know *shrug*

Statistics: Posted by nml375 — Wed Aug 09, 2006 3:40 pm

global variables don't work

2006-08-09T15:38:12-04:00

that's no prob :P just wanted to make sure the info is recieved the right way ;)

Statistics: Posted by krimson — Wed Aug 09, 2006 3:38 pm

global variables don't work

2006-08-09T15:11:04-04:00

if you used an argument when declaring the procs, you must use it when calling them too
]

Of course you're right. It was late, i was tired :)

Statistics: Posted by KrzychuG — Wed Aug 09, 2006 3:11 pm

global variables don't work

2006-08-09T04:21:59-04:00

if you used an argument when declaring the procs, you must use it when calling them too

Code:

proc bla { nick } { return [string equal -nocase bla $nick] }proc blabla { nick } { return [string equal -nocase blabla $nick] }bind pubm - "*!afk*" afkproc afk {nick host hand chan arg} { if {[bla $nick] || [blabla $nick]} {  putquick "PRIVMSG $chan :$nick is AFK." }}

Statistics: Posted by krimson — Wed Aug 09, 2006 4:21 am

global variables don't work

2006-08-08T14:59:51-04:00

Can't you convert those global variables to procedures? I don't think you can use variable like you defined.

Code:

proc bla { nick } { return [string equal -nocase bla $nick] }proc blabla { nick } { return [string equal -nocase blabla $nick] }bind pubm - "*!afk*" afk proc afk {nick host hand chan arg} {  if {[bla] || [blabla]} {   putquick "PRIVMSG $chan :$nick is AFK."  } }

Statistics: Posted by KrzychuG — Tue Aug 08, 2006 2:59 pm

global variables don't work

2006-08-08T08:54:58-04:00

As I remember, $nick is a reserved variable, "always" set to whatever nick your bot currently uses..
Hav'nt dug into the source in a while, but I'd guess it's not set during startup..
I also get this distict feeling darton expects bla and blabla to be updated as soon as nick is changed... which is most definetly not the case, all "global" does is to link the local (function-instance) variable to the global one (ie making bla and blabla readable from within the function even tho they exist outside).

It feels like he actually wants to do some variable tracing (man n trace), although coding event-driven tcl isn't that pretty in eggies as I recall...

Statistics: Posted by nml375 — Tue Aug 08, 2006 8:54 am

global variables don't work

2006-08-08T03:23:32-04:00

@darton: the reason why the code in your first post won't work is because (probably) you didn't set $nick before setting $bla and $blabla. this is the reason why you should use both vars inside your procs

Statistics: Posted by krimson — Tue Aug 08, 2006 3:23 am

global variables don't work

2006-08-07T17:43:30-04:00

This is what I'd suggest... Assuming from your first post that you wish to check wether the bot is afk or not, and reply " is AFK" if so...

Code:

proc {unick host hand chan text} { global nick if {[string equal -nocase "bla" $nick] || [string equal -nocase "blabla" $nick]} {  putquick "PRIVMSG $chan :$unick is AFK" }}

The load won't increase much, unless you plan to call this 10 times a second or such...

Also, my first question in my last post should actually have been: do you update those variables anywhere _else_ in the script while the bot runs

Statistics: Posted by nml375 — Mon Aug 07, 2006 5:43 pm

global variables don't work

2006-08-07T17:38:01-04:00

Yes I update it at any time with "global bla blabla". But does that increase load? I think there is no difference if I write "if {$bla || $blabla}" or "if {[string equal -nocase $blabla $nick]}"

Statistics: Posted by darton — Mon Aug 07, 2006 5:38 pm