egghelp/eggheads community

new version of convert.tcl

2006-06-13T21:58:00-04:00

Sounds a lot like one of my coding sessions.. "It works!" - "Crap!"

Statistics: Posted by incith — Tue Jun 13, 2006 9:58 pm

new version of convert.tcl

2006-06-13T06:15:44-04:00

Ok, really need sleep..I broke it =)
Will have to hack on it tomorrow..or tonight..or whatever =)

Statistics: Posted by rosc2112 — Tue Jun 13, 2006 6:15 am

more pestery stuff

2006-06-13T05:50:00-04:00

just noticed this, the "bind each sign" uses "*sign", which was probably on purpose, so the trigger is caught in any sentence, but, it produces an error, at least with the mods I did. It brings up the msg about "Please choose a valid sign"

So I changed

Code:

bind pubm -|- "*${incith::horoscope::command_char}${sign}" incith::horoscope::public_messageto: bind pub -|- "${incith::horoscope::command_char}${sign}" incith::horoscope::public_message

*tweak*
Time to goto sleep before I do any more damage

Statistics: Posted by rosc2112 — Tue Jun 13, 2006 5:50 am

new version of convert.tcl

2006-06-13T05:39:54-04:00

oops, my bad, I must be tired too..It didnt work (I mis-tested it... I did .horoscope leo, the error shows when I do .leo - the 1st letter gets chopped..) Garf..

Statistics: Posted by rosc2112 — Tue Jun 13, 2006 5:39 am

new version of convert.tcl

2006-06-13T05:35:42-04:00

If you do submit any google changes, they'd have to go to the guy I handed the script over to, madwoota.

Ahh, didn't know you handed it off. I'll have to grab a more recent version (I have v1.8 in my archive)

As for horoscope..
The . problem can likely be resolved by changing the regexp to {} instead of ""

Yep, just tried it, and it worked

Tnx

Statistics: Posted by rosc2112 — Tue Jun 13, 2006 5:35 am

new version of convert.tcl

2006-06-13T03:35:13-04:00

You're amazing.

If you do submit any google changes, they'd have to go to the guy I handed the script over to, madwoota.

As for horoscope.. it is probably due for an update, but weather was a priority.

I'll definitely refer back to this thread for a future horoscope release. The . problem can likely be resolved by changing the regexp to {} instead of "", but it is late, and sometimes I think I know Tcl better than I really do (which isn't that well). To be honest, I never use horoscope.. perhaps I'll wait until my luck feels a bit better.

Statistics: Posted by incith — Tue Jun 13, 2006 3:35 am

new version of convert.tcl

2006-06-13T01:59:43-04:00

Hmm, now that I looked at my changes again, I just noticed a bit I can condense:

Code:

                proc send_output {input where} {                      set validsign 0                      foreach sign [split $incith::horoscope::valid_signs " "] {                                if {$input == $sign} {                                        set validsign 1                                }                        }                        if {($validsign == 0) || ($input == "")} {                                puthelp "PRIVMSG $where :Please choose a valid sign: etc etc"                                return                        } else {                              foreach line [incith::horoscope::parse_output [horoscope $input]] {                                        puthelp "PRIVMSG $where :$line"                              }                         }                 }

Statistics: Posted by rosc2112 — Tue Jun 13, 2006 1:59 am

new version of convert.tcl

2006-06-13T01:27:43-04:00

No problem Incith. I actually have your google script in my work dir, haven't had a chance to put it into the bot yet, but it's in my pile of todo stuff

I'm sure once I do start using it, I'll be pestering you with bugreports and suggestions too, like I do with everyone else

I'm also using your horoscope script and did some minor tweaks to my local copy, didn't think they were significant enough to post about. The most significant change I made was to use:

Code:

catch {set http [::http::geturl "${query}daily${input}.html" -timeout [expr 1000 * 15]]} error[..snip..]catch {set http [::http::geturl "${query}dailychinese${input}.html" -timeout [expr 1000 * 15]]} error[..snip..]     if {[string match -nocase "*couldn't open socket*" $error]} {            return "Error: couldn't connect..Try again later"      }if { [::http::status $http] == "timeout" } {[..snip..]

I added the catch and return error msg cos my isp's dns sucks and I've hit 'host unreachable' quite a few times in scripts.

Also had to change:

Code:

       regsub -- "^${incith::horoscope::command_char}" $input "" inputto:        regsub -- ^\\. $input "" input

because I use the . char as a cmd char, and the regsub was thinking that the . was an atom so it was chopping off the 1st letter of the sign name when using .horoscope leo, for example.

Also changed this a bit to give more verbose help:

Code:

Original:   namespace eval horoscope {     # SEND_OUTPUT     # no point having two copies of this in public/private_message{}     #     proc send_output {input where} {       foreach line [incith::horoscope::parse_output [horoscope $input]] {         putquick "PRIVMSG $where :$line"       }     }---My change:namespace eval horoscope { # SEND_OUTPUT # no point having two copies of this in public/private_message{}   proc send_output {input where} {      if {$input == ""} {         puthelp "PRIVMSG $where :Please choose a sign: capricorn aquarius pisces aries taurus gemini cancer leo virgo libra scorpio sagittarius rat ox tiger rabbit dragon snake horse goat monkey rooster dog pig"         return      }      set validsign 0       foreach sign [split $incith::horoscope::valid_signs " "] {            if {$input == $sign} {                  set validsign 1            }       }       if {$validsign == 0} {              puthelp "PRIVMSG $where :Please choose a sign: capricorn aquarius pisces aries taurus gemini cancer leo virgo libra scorpio sagittarius rat ox tiger rabbit dragon snake horse goat monkey rooster dog pig"             return       } else {               foreach line [incith::horoscope::parse_output [horoscope $input]] {                     puthelp "PRIVMSG $where :$line"                }         }  }

And now I've totally mucked up this topic thread

Statistics: Posted by rosc2112 — Tue Jun 13, 2006 1:27 am

new version of convert.tcl

2006-06-12T16:30:33-04:00

I'm not sure how this post will be taken, but by all means I am not trying to prevent people from using your script.

I just thought I would point out, incith:google script, and Google itself, does conversions for just about anything. I can even calculate download times with something like 5 MB / 50 KB/s = (5 MB) / (50 (KB / s)) = 102.4 seconds, or you can do 5 MB / 50 KB/s in minutes, and your result would be in minutes.

Perhaps this post is more directed at those that may already use :google script.

Good job though, a local conversions script will always be faster than one doing net lookups.

Again, sorry if I've intruded this thread, I'm not looking for props on my scripts or anything. *paranoid*

Statistics: Posted by incith — Mon Jun 12, 2006 4:30 pm

v205b

2006-06-10T14:58:29-04:00

Some minor updates to the convert script. v205b. Same url as above.
21/5/06 - Added inch/centimeter conversion..
27/5/06 - A better string2list was posted in egghelp.org and is now incorporated here.

Statistics: Posted by rosc2112 — Sat Jun 10, 2006 2:58 pm

new version of convert.tcl

2006-04-27T19:45:45-04:00

Neat. Thanks

Statistics: Posted by rosc2112 — Thu Apr 27, 2006 7:45 pm

new version of convert.tcl

2006-04-26T18:13:30-04:00

Read last post here.

Statistics: Posted by Sir_Fz — Wed Apr 26, 2006 6:13 pm

new version of convert.tcl

2006-04-26T17:28:25-04:00

Code:

'1 +         1'

I don't see that as a problem, it just makes the script return an error msg.

you might want to take a look at my FAQ post about splitting

It does use split on the user input.

I made one small update to the script as well, to use [split] on the calc $reply, so that replies are properly formated (otherwise it drops chars when [join $rep] is sent to the user.)

Found a few typos too, fixed

Statistics: Posted by rosc2112 — Wed Apr 26, 2006 5:28 pm

new version of convert.tcl

2006-04-26T05:17:32-04:00

You mean like '1 + 1' ? Not sure I follow your meaning.

Code:

'1 +         1'

you might want to take a look at my FAQ post about splitting

Statistics: Posted by demond — Wed Apr 26, 2006 5:17 am

new version of convert.tcl

2006-04-26T05:03:06-04:00

my calc bind looks like that and I am pretty confident about the safety:

Code:

...set text [string map {[ ( ] ) $ " dollar "} $text]...catch {set ergebnis [expr $text]} fehler...

At least I failed with all my imaginations to force a second substitition.

Statistics: Posted by De Kus — Wed Apr 26, 2006 5:03 am