egghelp/eggheads community

logzipper script update

2007-02-08T05:20:45-04:00

I did a little debugging on the logzipper tcl script, and didn't find any probs with my copy, so I can only assume the copy Zircon has was perhaps an old version with some error in how files were named. In any case, I put an updated copy here:

http://members.dandy.net/~fbn/logzipper.tcl.txt

This version uses bzip2 and the mail part does work. I also added notes about the config from the original readme, since that part of the script is a little obscure. You have to specify the user@emailaddress and then the logfile names as written in your eggdrop.conf for your channels and whatever else you have for logfiles, that way each recipient can be sent specific logs. For example, in my config I use:

logfile bcmoswx * "logs/eggdrop_bot.log"
logfile jkp #mychan"logs/mychan_pub.log"
logfile jkp #funo "logs/funo_pub.log"
logfile jkp #friends "logs/friends_pub.log"

So in logzipper's file, if I only wanted to send the eggdrop_bot.log to specific people, I'd use like:

set lz_recipient(1) "admin@mail eggdrop_bot.log"

Then to send other logs to someone else:

set lz_recipient(2) "channelop@mailaddress channelname.log channel2.log"
set lz_recipient(3) "anotherop@localhost eggdrop_bot.log channel2.log"

and so on..

Hope that clarifies the issue and fixes your mailing prob.

Statistics: Posted by rosc2112 — Thu Feb 08, 2007 5:20 am

Using 'set {my-var}' prob

2007-02-06T14:50:52-04:00

Hello rosc2112

Thanks for replying. I think that the mail feature is working, coz i receive a mail, but empty, no file attached too.

The problem is that the script is trying to send the file culture.2007Feb04.Feb-04-2007.bz2 which doesnt exist. The right file to send is culture.2007Feb04.log.bz2.

My problem is that when the script want to send the file, it adds "Feb-04-2007" at the end in the name of the right file.

Thanks

Statistics: Posted by Zircon — Tue Feb 06, 2007 2:50 pm

Using 'set {my-var}' prob

2007-02-06T14:38:06-04:00

I dont use the mail feature, sorry. Try adding debug "putcmdlog" stuff in the script to get the real error messages that came from your shell, apparently there is a problem with mail on your shell, not the script.

Statistics: Posted by rosc2112 — Tue Feb 06, 2007 2:38 pm

Using 'set {my-var}' prob

2007-02-06T01:05:56-04:00

Hi rosc2112

I have a question about ur updated logzipper.tcl for 1.6.17. I used ur version of this script. It s zippin the file, but it doent send it coz it looks for wrong file.

I edited the script to make these settings :

set lz(logloc) "logs/quizz/culture/"
set lz(duration) 1
set lz(sendlogs) 1
set lz_recipient(1) "zircon@gmail.com culture"

and in the config file i have these :

logfile jpk #culture "logs/quizz/culture/culture"
set keep-all-logs 1
set logfile-suffix ".%Y%b%d.log"

When i make the test manually with messaging the bot with logzip, i get these messages in the party line

LogZipper: An error occured while trying to uuencode or mail culture.2007Feb04.Feb-04-2007.bz2

LogZipper: zipped 1 logs, deleted 0 expired logs. Sent 0 logs via email.

So the script made the zip of culture.2007Feb04.log to culture.2007Feb04.log.bz2 as it should be, but couldnt sent it in a mail, cause it was trying to send the file culture.2007Feb04.Feb-04-2007.bz2, which doesnt exist.

Please, do u have some idea to solve this problem, to make the script send the right file ?

Thanks in advance Smile

PSssttt : by the way, what to do to make the script leave the input file there ( the unzipped file ), and not delete it ?

Statistics: Posted by Zircon — Tue Feb 06, 2007 1:05 am

Using 'set {my-var}' prob

2006-04-22T18:59:28-04:00

Either add it to global or use ${::logfile-suffix}.

Statistics: Posted by Sir_Fz — Sat Apr 22, 2006 6:59 pm

logzipper fix

2006-04-22T15:39:08-04:00

If you stated your problem clearly from the 1st post then you would've solved your problem way back in this topic. Your problem is in using a variable with a '-' in it. It's simple, see this example code:
Code:
set myvar-fu "foo"bind msg n testfu testfuproc testfu {nick uhost hand text} { global myvar-fu if {[info exists myvar-fu]} {  puthelp "PRIVMSG $nick :${myvar-fu}" }}

Ok, I think I'm starting to understand how this works (not exactly sure *why* it works this way) but it seems that using myvar-fu with quotes "" changes the behavior (as in, 'set lz(searchstr) "*[strftime ${logfile-suffix} [expr [unixtime] - 86400]]"}' is the section of the original code that was producing the error.

The original script was also trying to set the global 'logfile-suffix' with 'if {[info exists logfile-suffix]}' but this didn't work at all unless I put 'logfile-suffix' into the global section anyway! Silly =)

Apparently the only real fix it needed was to add logfile-suffix to the global var declaration.. dah...

Anyway, here's my fixed version for anyone else that might find it useful:

Code:

# LogZipper             2.0 by Baerchen, May 2001#                              for eggdrop 1.4.x+#                       baerchen@germany-chat.net## HISTORY## 2.0.1-rosc    - Updated by Rosc at rosc2112.net to work with eggdrop 1.6.x (April 2006)#               - Uses bzip2 now, I see no point in making a tarball for a single file.#               - Added bind msg logzip to run the script manually (mainly for testing purposes)## 2.0# Baerchen      - Complete rewrite: 1.01f did not really what it was supposed#                 to do :/ #               - Added possibility of sending various (zipped) logs#                 to various recipients#               - Now works with keep-all-logs set to 1## 1.01f# Baerchen      First public release## CONFIGURATIONset lz(logloc) "logs/"set lz(duration) 90set lz(sendlogs) 0set lz_recipient(1) "user@mail log1.log #channel1.log"# CODEBASE BELOWbind evnt - logfile lz_waitproc lz_wait {logfile} {timer 1 lz_zip}putlog "LogZipper 2.0 by Baerchen (keeping logs for $lz(duration) days)"bind msg n logzip msg:lz_zipproc msg:lz_zip {nick uhost hand text} {lz_zip}proc lz_zip { } {        global lz lz_recipient botnick switch-logfiles-at keep-all-logs logfile-suffix        if {![info exists logfile-suffix]} {# set logfile-suffix is only needed as a fall-back, in some off chance that the global var isn't found..                set logfile-suffix ".%d-%b-%Y"        }        set lz(date) [strftime "%b-%d-%Y" [expr [clock seconds] - 86400]]        set lz(max) [expr [clock seconds] - ($lz(duration) * 86400) + 60]        set lz(filestomail) ""        set i 0; set j 0; set k 0        if {(${keep-all-logs} == 0) && (${switch-logfiles-at} == 2500)} {                putlog "Logzipper: Invalid configuration: log files do not switch. You might want to correct that."                return        }        if {${keep-all-logs} == 1} {                set lz(searchstr) "*[strftime ${logfile-suffix} [expr [unixtime] - 86400]]"        } else {                set lz(searchstr) "*yesterday"        }        set lz(filelist) [glob -directory $lz(logloc) -nocomplain -- $lz(searchstr)]        foreach e $lz(filelist) {                if {$e == ""} {continue}                        set f "[string range $e 0 [string last . $e]]$lz(date).bz2"                        set lz(zerror) [catch {exec bzip2 -z $e}]                        if {$lz(zerror)} {                                putlog "LogZipper: An error occured while trying to zip $e"                                continue                        }                set lz(ferror) [catch {file delete -force $e}]                if {$lz(ferror)} {                        putlog "LogZipper: An error occured while trying to delete $e"                }                lappend lz(filestomail) [string range $f [expr [string last / $f] +1] end]                incr i        }        set lz(filelist) [glob -directory $lz(logloc) -nocomplain -- *.???-??-????.bz2]        foreach e $lz(filelist) {                if {$e == ""} {continue}                if {[file mtime $e] <= $lz(max)} {                        set lz(ferror) [catch {file delete -force $e}]                        if {$lz(ferror)} {                                putlog "LogZipper: An error occured while trying to delete $e"                                continue                        }                        incr j                }        }        set lz_status "LogZipper: zipped $i logs, deleted $j expired logs. "        if {$lz(sendlogs)} {                foreach e $lz(filestomail) {                        if {$e == ""} {continue}                        foreach el [array names lz_recipient] {                                set rec [lindex $lz_recipient($el) 0]                                set what [lrange $lz_recipient($el) 1 end]                                foreach ele $what {                                        if {[string match -nocase *$ele* $e]} {                                                set lz(merror) [catch { exec uuencode $lz(logloc)$e $e | mail $rec }]                                                if {$lz(merror)} {                                                        putlog "LogZipper: An error occured while trying to uuencode or                                                         continue                                                }                                                incr k                                        }                                }                          }                }                append lz_status "Sent $k logs via email."        }        putlog "$lz_status"}

Statistics: Posted by rosc2112 — Sat Apr 22, 2006 3:39 pm

Using 'set {my-var}' prob

2006-04-22T13:35:25-04:00

the issue is something else:

set var $var-var
--> reads from 'var-var'
set var "$var-var"
--> reads from 'var' and adds '-var' as string

nah, these are equivalent, with the latter effect

Statistics: Posted by demond — Sat Apr 22, 2006 1:35 pm

Using 'set {my-var}' prob

2006-04-22T10:34:15-04:00

the issue is something else:

set var $var-var
--> reads from 'var-var'
set var "$var-var"
--> reads from 'var' and adds '-var' as string

Statistics: Posted by De Kus — Sat Apr 22, 2006 10:34 am

Using 'set {my-var}' prob

2006-04-22T09:08:41-04:00

If you stated your problem clearly from the 1st post then you would've solved your problem way back in this topic. Your problem is in using a variable with a '-' in it. It's simple, see this example code:

Code:

set myvar-fu "foo"bind msg n testfu testfuproc testfu {nick uhost hand text} { global myvar-fu if {[info exists myvar-fu]} {  puthelp "PRIVMSG $nick :${myvar-fu}" }}

Statistics: Posted by Sir_Fz — Sat Apr 22, 2006 9:08 am

Using 'set {my-var}' prob

2006-04-22T06:46:51-04:00

Here's a couple of test scripts I made:

Code:

# testscript 1set myvar-fu "foo"bind msg n testfu testfuproc testfu { nick uhost hand text } {global myvar-fuputhelp "PRIVMSG $nick :$myvar-fu"}

Code:

#testscript 2bind msg n testfu testfuproc testfu { nick uhost hand text } {set myvar2-fu "foo2"puthelp "PRIVMSG $nick :$myvar2-fu"}

It didn't matter where the var-fu thing was, in or out of a proc. In both cases, tcl only saw "myvar" or "myvar2" and chops off the -fu

test1
Tcl error [testfu]: can't read "myvar": no such variable

test2
Tcl error [testfu]: can't read "myvar2": no such variable

I've not seen any documentation that says vars cannot use a '-' char, the closest related documentation I have seen is regarding glob. I don't know if that applies to this situation.

Here is the code from logzipper.tcl which is what I'm trying to fix:

Code:

proc lz_zip { } { global lz lz_recipient botnick {switch-logfiles-at} {keep-all-logs} if {[info exists {logfile-suffix}]} {  global {logfile-suffix} } else {  set {logfile-suffix} ".%d%b%Y" }

None of the vars with - chars work, with or without curly braces..

There is also this line further along:

Code:

 if {${keep-all-logs} == 1} {  set lz(searchstr) "*[strftime ${logfile-suffix} [expr [unixtime] - 86400]]"} else {  set lz(searchstr) "*yesterday" }

I've temporarily worked around the problem by renaming the vars to not use dashes '-' and just use the values as found in the eggdrop.conf, but that's not very elegant or portable.

I'm not sure I understand what you mean by using ::var-fu , De Kus. Would you show me an example? Thanks for actually being helpful.

Statistics: Posted by rosc2112 — Sat Apr 22, 2006 6:46 am

Using 'set {my-var}' prob

2006-04-22T02:42:12-04:00

It's most likely you try to use a global var within a proc/namespace. In that case ::logfile-suffix should solve the issue.

Statistics: Posted by De Kus — Sat Apr 22, 2006 2:42 am

Using 'set {my-var}' prob

2006-04-22T01:45:37-04:00

Didn't work for me..

maybe so, but not for the reason you think

Statistics: Posted by demond — Sat Apr 22, 2006 1:45 am

Using 'set {my-var}' prob

2006-04-21T20:01:59-04:00

Didn't work for me..

Statistics: Posted by rosc2112 — Fri Apr 21, 2006 8:01 pm

Using 'set {my-var}' prob

2006-04-21T06:20:28-04:00

you are incorrect, there is nothing wrong with that expression

this will work too, it's equivalent to yours:

Code:

if [info exists logfile-suffix]

Statistics: Posted by demond — Fri Apr 21, 2006 6:20 am

Using 'set {my-var}' prob

2006-04-21T05:25:20-04:00

I should have mentioned I'm using eggdrop 1.6.17.

Statistics: Posted by rosc2112 — Fri Apr 21, 2006 5:25 am